Skip to content

Commit 83d8a87

Browse files
authored
feat(console-api): Update tonic to 0.7 (#318)
This change updates `tonic` and `prost` to their latest versions. In addition this PR changes how the generated protobuf is built from being done in a `build.rs` file to a `tests/boostrap.rs` test. This removes the need for downstream consumers to compile/provide `protoc` for `prost` to generate the protobuf files (which was changed in `0.10`). The bootstrap test will first attempt to compile the protobuf files and check if there is a git diff between the checked in version. If there is a difference it will fail the test waiting for the files to be checked in. This will fail PRs that have updated the protobuf files but not checked in the new versions. BREAKING CHANGE: `console-api` is now no longer compatible with projects using `prost` 0.9 or `tonic` 0.7. These crates must be updated to use `console-api` 0.2.
1 parent 9178ecf commit 83d8a87

19 files changed

+1887
-272
lines changed

Diff for: .github/workflows/ci.yaml

+3-5
Original file line numberDiff line numberDiff line change
@@ -25,11 +25,9 @@ env:
2525
RUSTUP_MAX_RETRIES: 10
2626
# Don't emit giant backtraces in the CI logs.
2727
RUST_BACKTRACE: short
28-
# Make Rust 1.56.0 the minimum supported Rust version.
29-
#
30-
# Some of our dependencies require `edition = "2021"` which is only supported
31-
# on 1.56.0+.
32-
minrust: 1.56.0
28+
# Make 1.58 MSRV due to <=1.57 failing to build console-api due to a bug
29+
# with cargo version resolution.
30+
minrust: 1.58.0
3331

3432
jobs:
3533
check:

0 commit comments

Comments
 (0)