feat: change skipNodeModulesBundle default behavior

Author: tomgao365

examples/react/.vscode/launch.json

@@ -16,6 +16,18 @@
         "${workspaceFolder}/dist/extension/*.js"
       ],
       "preLaunchTask": "${defaultBuildTask}"
+    },
+    {
+      "name": "Preview Extension",
+      "type": "extensionHost",
+      "request": "launch",
+      "args": [
+        "--extensionDevelopmentPath=${workspaceFolder}"
+      ],
+      "outFiles": [
+        "${workspaceFolder}/dist/extension/*.js"
+      ],
+      "preLaunchTask": "npm: build"
     }
   ]
 }

examples/react/.vscode/tasks.json

@@ -10,7 +10,7 @@
         "owner": "typescript",
         "fileLocation": "relative",
         "pattern": {
-          "regexp": "^([a-zA-Z]\\:\/?([\\w\\-]\/?)+\\.\\w+):(\\d+):(\\d+): (ERROR|WARNING)\\: (.*)$",
+          "regexp": "^([a-zA-Z]\\:/?([\\w\\-]/?)+\\.\\w+):(\\d+):(\\d+): (ERROR|WARNING)\\: (.*)$",
           "file": 1,
           "line": 3,
           "column": 4,
@@ -31,6 +31,15 @@
         "kind": "build",
         "isDefault": true
       }
+    },
+    {
+      "type": "npm",
+      "script": "build",
+      "group": {
+        "kind": "build",
+        "isDefault": true
+      },
+      "problemMatcher": []
     }
   ]
 }

examples/vue-import/.vscode/launch.json

@@ -16,6 +16,18 @@
         "${workspaceFolder}/dist/extension/*.js"
       ],
       "preLaunchTask": "${defaultBuildTask}"
+    },
+    {
+      "name": "Preview Extension",
+      "type": "extensionHost",
+      "request": "launch",
+      "args": [
+        "--extensionDevelopmentPath=${workspaceFolder}"
+      ],
+      "outFiles": [
+        "${workspaceFolder}/dist/extension/*.js"
+      ],
+      "preLaunchTask": "npm: build"
     }
   ]
 }

examples/vue-import/.vscode/tasks.json

@@ -10,7 +10,7 @@
         "owner": "typescript",
         "fileLocation": "relative",
         "pattern": {
-          "regexp": "^([a-zA-Z]\\:\/?([\\w\\-]\/?)+\\.\\w+):(\\d+):(\\d+): (ERROR|WARNING)\\: (.*)$",
+          "regexp": "^([a-zA-Z]\\:/?([\\w\\-]/?)+\\.\\w+):(\\d+):(\\d+): (ERROR|WARNING)\\: (.*)$",
           "file": 1,
           "line": 3,
           "column": 4,
@@ -31,6 +31,15 @@
         "kind": "build",
         "isDefault": true
       }
+    },
+    {
+      "type": "npm",
+      "script": "build",
+      "group": {
+        "kind": "build",
+        "isDefault": true
+      },
+      "problemMatcher": []
     }
   ]
 }

examples/vue/.vscode/launch.json

@@ -16,6 +16,18 @@
         "${workspaceFolder}/dist/extension/*.js"
       ],
       "preLaunchTask": "${defaultBuildTask}"
+    },
+    {
+      "name": "Preview Extension",
+      "type": "extensionHost",
+      "request": "launch",
+      "args": [
+        "--extensionDevelopmentPath=${workspaceFolder}"
+      ],
+      "outFiles": [
+        "${workspaceFolder}/dist/extension/*.js"
+      ],
+      "preLaunchTask": "npm: build"
     }
   ]
 }

examples/vue/.vscode/tasks.json

@@ -10,7 +10,7 @@
         "owner": "typescript",
         "fileLocation": "relative",
         "pattern": {
-          "regexp": "^([a-zA-Z]\\:\/?([\\w\\-]\/?)+\\.\\w+):(\\d+):(\\d+): (ERROR|WARNING)\\: (.*)$",
+          "regexp": "^([a-zA-Z]\\:/?([\\w\\-]/?)+\\.\\w+):(\\d+):(\\d+): (ERROR|WARNING)\\: (.*)$",
           "file": 1,
           "line": 3,
           "column": 4,
@@ -31,6 +31,15 @@
         "kind": "build",
         "isDefault": true
       }
+    },
+    {
+      "type": "npm",
+      "script": "build",
+      "group": {
+        "kind": "build",
+        "isDefault": true
+      },
+      "problemMatcher": []
     }
   ]
 }

src/index.ts

@@ -28,8 +28,7 @@ function getPkg() {
 }
 
 function preMergeOptions(options?: PluginOptions): PluginOptions {
-  getPkg();
-
+  const pkg = getPkg();
   const opts: PluginOptions = merge(
     {
       webview: true,
@@ -43,11 +42,12 @@ function preMergeOptions(options?: PluginOptions): PluginOptions {
         shims: true,
         clean: true,
         dts: false,
-        treeshake: !!isDev,
+        treeshake: isDev ? false : 'smallest',
         outExtension() {
           return { js: '.js' };
         },
         external: ['vscode'],
+        skipNodeModulesBundle: isDev,
       } as ExtensionOptions,
     },
     cloneDeep(options),
@@ -71,6 +71,12 @@ function preMergeOptions(options?: PluginOptions): PluginOptions {
     opt.external ?? [],
   );
 
+  if (!opt.skipNodeModulesBundle) {
+    opt.noExternal = Object.keys(pkg.dependencies || {}).concat(
+      Object.keys(pkg.peerDependencies || {}),
+    );
+  }
+
   opts.extension = opt;
 
   if (opts.webview === true) {

src/types.ts

@@ -4,7 +4,10 @@ import type { Options } from 'tsup';
  * vscode extension options. See [tsup](https://tsup.egoist.dev/) and [API Doc](https://paka.dev/npm/tsup) for more information.
  */
 export interface ExtensionOptions
-  extends Omit<Options, 'entry' | 'format' | 'outDir' | 'watch' | 'onSuccess'> {
+  extends Omit<
+    Options,
+    'entry' | 'format' | 'outDir' | 'watch' | 'onSuccess' | 'skipNodeModulesBundle'
+  > {
   /**
    * The extension entry file.
    * @default "extension/index.ts"
@@ -19,6 +22,10 @@ export interface ExtensionOptions
    * The bundle format. Currently only supports cjs.
    */
   format?: 'cjs';
+  /**
+   * Skip dependencies and peerDependencies bundle. Default is false.
+   */
+  skipNodeModulesBundle?: boolean;
   /**
    * A function that will be executed after the build succeeds.
    */