Skip to content

Commit 1b6023a

Browse files
authored
Merge pull request #56 from chadlwilson/upgrade-build-and-dependencies
Update & modernize build and dependencies
2 parents a784a1f + 6a3778c commit 1b6023a

15 files changed

+284
-253
lines changed

CHANGELOG.md

+2-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
### 0.5.1 - Unreleased
1+
### 0.6.0 (2022-Jul-31)
2+
* Upgrade all dependencies to latest, patched versions
23

34
### 0.5.0 (2019-Oct-02)
45

build.gradle

+17-16
Original file line numberDiff line numberDiff line change
@@ -6,14 +6,14 @@ plugins {
66
id "com.github.jk1.dependency-license-report"
77
}
88

9-
group = 'cd.go.plugin.config.json'
10-
version "0.5.2"
9+
group 'cd.go.plugin.config.json'
10+
version "0.6.0"
1111

1212
apply plugin: 'java'
1313

1414
project.ext {
1515
pluginDesc = [
16-
version : project.version,
16+
version: project.version,
1717
goCdVersion: '20.4.0'
1818
]
1919

@@ -28,20 +28,22 @@ repositories {
2828
}
2929

3030
dependencies {
31-
compile group: 'com.google.code.gson', name: 'gson', version: '2.8.5'
32-
compile group: 'commons-io', name: 'commons-io', version: '2.6'
33-
compile group: 'org.apache.ant', name: 'ant', version: '1.10.7'
34-
compile group: 'com.beust', name: 'jcommander', version: '1.78'
31+
implementation group: 'com.google.code.gson', name: 'gson', version: '2.9.1'
32+
implementation group: 'commons-io', name: 'commons-io', version: '2.11.0'
33+
implementation group: 'org.apache.ant', name: 'ant', version: '1.10.12'
34+
implementation group: 'com.beust', name: 'jcommander', version: '1.82'
3535

3636
compileOnly group: 'cd.go.plugin', name: 'go-plugin-api', version: project.pluginApiVersion
37-
testCompile group: 'cd.go.plugin', name: 'go-plugin-api', version: project.pluginApiVersion
37+
testImplementation group: 'cd.go.plugin', name: 'go-plugin-api', version: project.pluginApiVersion
3838

39-
testCompile group: 'junit', name: 'junit', version: '4.12'
40-
testCompile group: 'org.mockito', name: 'mockito-core', version: '3.0.0'
41-
testCompile group: 'org.hamcrest', name: 'hamcrest-core', version: '2.1'
39+
testImplementation group: 'org.junit.jupiter', name: 'junit-jupiter-api', version: '5.9.0'
40+
testRuntimeOnly group: 'org.junit.jupiter', name: 'junit-jupiter-engine', version: '5.9.0'
41+
testImplementation group: 'org.mockito', name: 'mockito-core', version: '4.6.1'
42+
testImplementation group: 'org.hamcrest', name: 'hamcrest', version: '2.2'
4243
}
4344

4445
processResources {
46+
duplicatesStrategy = DuplicatesStrategy.INCLUDE
4547
from("resource-templates") {
4648
filesMatching('*') {
4749
expand project.pluginDesc
@@ -67,18 +69,18 @@ sourceSets {
6769
}
6870

6971
test {
70-
useJUnit {
71-
}
72+
useJUnitPlatform()
7273
testLogging {
7374
events "passed", "skipped", "failed", "standardOut"
7475
}
7576
}
7677

7778
// create a fat jar with all dependencies
7879
jar {
79-
baseName = project.name
80+
archiveBaseName = project.name
8081
preserveFileTimestamps = false
8182
reproducibleFileOrder = true
83+
duplicatesStrategy = DuplicatesStrategy.INCLUDE
8284

8385
manifest {
8486
attributes 'Main-Class': 'com.tw.go.config.json.cli.JsonPluginCli'
@@ -89,10 +91,9 @@ jar {
8991
exclude "NOTICE.txt"
9092
}
9193

92-
from { configurations.compile.collect { it.isDirectory() ? it : zipTree(it) } }
94+
from { configurations.runtimeClasspath.collect { it.isDirectory() ? it : zipTree(it) } }
9395
}
9496

95-
9697
licenseReport {
9798
renderers = [new NoticeFileGenerator(new TeeRenderer(new SimpleHtmlReportRenderer()), "${project.buildDir}/reports/dependency-license/")]
9899
}

buildSrc/build.gradle

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,5 @@ repositories {
66
}
77

88
dependencies {
9-
compile group: 'com.github.jk1.dependency-license-report', name: 'com.github.jk1.dependency-license-report.gradle.plugin', version: '1.3'
9+
implementation group: 'com.github.jk1.dependency-license-report', name: 'com.github.jk1.dependency-license-report.gradle.plugin', version: '2.0'
1010
}

buildSrc/src/main/groovy/cd/go/plugin/buildsrc/license/NoticeFileGenerator.groovy

+5-5
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ package cd.go.plugin.buildsrc.license
22

33
import com.github.jk1.license.ProjectData
44
import com.github.jk1.license.render.ReportRenderer
5-
import com.github.jk1.license.render.SingleInfoReportRenderer
5+
import com.github.jk1.license.render.TextReportRenderer
66

7-
class NoticeFileGenerator extends SingleInfoReportRenderer implements ReportRenderer {
7+
class NoticeFileGenerator extends TextReportRenderer implements ReportRenderer {
88
ReportRenderer toDecorate
99
String licenseFolder
1010

@@ -20,9 +20,9 @@ class NoticeFileGenerator extends SingleInfoReportRenderer implements ReportRend
2020
projectData.allDependencies.collect { data ->
2121
def noticeFile = new File(licenseFolder + 'NOTICE.txt')
2222
if (!data.licenseFiles.empty) {
23-
data.licenseFiles.first().files.collect { file ->
24-
if (new File(file).name.toLowerCase().contains("notice")) {
25-
noticeFile.append(new File(licenseFolder + file).getText('UTF-8'))
23+
data.licenseFiles.first().fileDetails.collect { details ->
24+
if (new File(details.file).name.toLowerCase().contains("notice")) {
25+
noticeFile.append(new File(licenseFolder + details.file).getText('UTF-8'))
2626
noticeFile.append('\n')
2727
}
2828
}

buildSrc/src/main/groovy/cd/go/plugin/buildsrc/license/TeeRenderer.groovy

+3-2
Original file line numberDiff line numberDiff line change
@@ -2,13 +2,14 @@ package cd.go.plugin.buildsrc.license
22

33
import com.github.jk1.license.ProjectData
44
import com.github.jk1.license.render.ReportRenderer
5-
import com.github.jk1.license.render.SingleInfoReportRenderer
5+
import com.github.jk1.license.render.TextReportRenderer
66

7-
class TeeRenderer extends SingleInfoReportRenderer implements ReportRenderer {
7+
class TeeRenderer extends TextReportRenderer implements ReportRenderer {
88
ReportRenderer toDecorate
99
def LICENSES = [
1010
'Apache License, Version 2.0',
1111
'Apache 2.0',
12+
'Apache-2.0',
1213
'The Apache Software License, Version 2.0',
1314
'New BSD License'
1415
]

gradle/wrapper/gradle-wrapper.jar

1.8 KB
Binary file not shown.
+2-1
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-6.5.1-bin.zip
3+
distributionSha256Sum=97a52d145762adc241bad7fd18289bf7f6801e08ece6badf80402fe2b9f250b1
4+
distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-all.zip
45
zipStoreBase=GRADLE_USER_HOME
56
zipStorePath=wrapper/dists

0 commit comments

Comments
 (0)