Remove detach for exec options

Detachable exec commands are handled in the client entirely and the detach option is not used anymore.

PiperOrigin-RevId: 195181272
Change-Id: I6e82a2876d2c173709c099be59670f71702e5bf0
Upstream-commit: a61def1

Author: fvoznika

pkg/sentry/control/proc.go

@@ -72,9 +72,6 @@ type ExecArgs struct {
 	// Capabilities is the list of capabilities to give to the process.
 	Capabilities *auth.TaskCapabilities
 
-	// Detach indicates whether Exec should detach once the process starts.
-	Detach bool
-
 	// FilePayload determines the files to give to the new process.
 	urpc.FilePayload
 }
@@ -135,12 +132,6 @@ func (proc *Proc) Exec(args *ExecArgs, waitStatus *uint32) error {
 		return err
 	}
 
-	// If we're supposed to detach, don't wait for the process to exit.
-	if args.Detach {
-		*waitStatus = 0
-		return nil
-	}
-
 	// Wait for completion.
 	newTG.WaitExited()
 	*waitStatus = newTG.ExitStatus().Status()

runsc/cmd/exec.go

@@ -99,7 +99,6 @@ func (ex *Exec) Execute(_ context.Context, f *flag.FlagSet, args ...interface{})
 	if err != nil {
 		Fatalf("error parsing process spec: %v", err)
 	}
-	e.Detach = ex.detach
 	conf := args[0].(*boot.Config)
 	waitStatus := args[1].(*syscall.WaitStatus)
 
@@ -123,7 +122,7 @@ func (ex *Exec) Execute(_ context.Context, f *flag.FlagSet, args ...interface{})
 	// executed. If detach was specified, starts a child in non-detach mode,
 	// write the child's PID to the pid file. So when the container returns, the
 	// child process will also return and signal containerd.
-	if e.Detach {
+	if ex.detach {
 		binPath, err := specutils.BinPath()
 		if err != nil {
 			Fatalf("error getting bin path: %v", err)