Skip to content

Commit dd98a9f

Browse files
maffootonybruguier
authored andcommitted
Format cirq-google with skip-magic-trailing-comma (quantumlib#5171)
Review: @95-martin-orion
1 parent 42e2118 commit dd98a9f

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

66 files changed

+309
-1115
lines changed

cirq-google/cirq_google/__init__.py

+2-10
Original file line numberDiff line numberDiff line change
@@ -18,9 +18,7 @@
1818
from cirq import _compat
1919
from cirq_google import api
2020

21-
from cirq_google._version import (
22-
__version__,
23-
)
21+
from cirq_google._version import __version__
2422

2523
from cirq_google.calibration import (
2624
ALL_ANGLES_FLOQUET_PHASED_FSIM_CHARACTERIZATION,
@@ -89,13 +87,7 @@
8987
LinePlacementStrategy,
9088
)
9189

92-
from cirq_google.ops import (
93-
CalibrationTag,
94-
FSimGateFamily,
95-
PhysicalZTag,
96-
SycamoreGate,
97-
SYC,
98-
)
90+
from cirq_google.ops import CalibrationTag, FSimGateFamily, PhysicalZTag, SycamoreGate, SYC
9991

10092
from cirq_google.optimizers import (
10193
ConvertToXmonGates,

cirq-google/cirq_google/calibration/__init__.py

+1-3
Original file line numberDiff line numberDiff line change
@@ -12,9 +12,7 @@
1212
# See the License for the specific language governing permissions and
1313
# limitations under the License.
1414

15-
from cirq_google.calibration.engine_simulator import (
16-
PhasedFSimEngineSimulator,
17-
)
15+
from cirq_google.calibration.engine_simulator import PhasedFSimEngineSimulator
1816

1917
from cirq_google.calibration.phased_fsim import (
2018
ALL_ANGLES_FLOQUET_PHASED_FSIM_CHARACTERIZATION,

cirq-google/cirq_google/calibration/engine_simulator.py

+4-23
Original file line numberDiff line numberDiff line change
@@ -1,16 +1,5 @@
11
# pylint: disable=wrong-or-nonexistent-copyright-notice
2-
from typing import (
3-
Any,
4-
Callable,
5-
Dict,
6-
Iterable,
7-
Iterator,
8-
List,
9-
Optional,
10-
Sequence,
11-
Tuple,
12-
Union,
13-
)
2+
from typing import Any, Callable, Dict, Iterable, Iterator, List, Optional, Sequence, Tuple, Union
143

154
import numpy as np
165

@@ -75,9 +64,7 @@ def __init__(
7564

7665
@classmethod
7766
def create_with_ideal_sqrt_iswap(
78-
cls,
79-
*,
80-
simulator: Optional[cirq.Simulator] = None,
67+
cls, *, simulator: Optional[cirq.Simulator] = None
8168
) -> 'PhasedFSimEngineSimulator':
8269
"""Creates a PhasedFSimEngineSimulator that simulates ideal FSimGate(theta=π/4, phi=0).
8370
@@ -452,10 +439,7 @@ def create_gate_with_drift(
452439
return gate_calibration.as_characterized_phased_fsim_gate(parameters)
453440

454441
def run_sweep_iter(
455-
self,
456-
program: cirq.AbstractCircuit,
457-
params: cirq.Sweepable,
458-
repetitions: int = 1,
442+
self, program: cirq.AbstractCircuit, params: cirq.Sweepable, repetitions: int = 1
459443
) -> Iterator[cirq.Result]:
460444
converted = _convert_to_circuit_with_drift(self, program)
461445
yield from self._simulator.run_sweep_iter(converted, params, repetitions)
@@ -479,10 +463,7 @@ def _create_partial_act_on_args(
479463
# Needs an implementation since it's abstract but will never actually be called.
480464
raise NotImplementedError()
481465

482-
def _create_step_result(
483-
self,
484-
sim_state: cirq.OperationTarget,
485-
) -> cirq.SparseSimulatorStep:
466+
def _create_step_result(self, sim_state: cirq.OperationTarget) -> cirq.SparseSimulatorStep:
486467
# Needs an implementation since it's abstract but will never actually be called.
487468
raise NotImplementedError()
488469

cirq-google/cirq_google/calibration/engine_simulator_test.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -346,7 +346,7 @@ def test_from_dictionary_sqrt_iswap_ideal_when_missing_parameter_fails():
346346
circuit = cirq.Circuit(cirq.FSimGate(np.pi / 4, 0.0).on(a, b))
347347

348348
engine_simulator = PhasedFSimEngineSimulator.create_from_dictionary_sqrt_iswap(
349-
parameters={(a, b): parameters_ab},
349+
parameters={(a, b): parameters_ab}
350350
)
351351

352352
with pytest.raises(ValueError):

cirq-google/cirq_google/calibration/phased_fsim.py

+10-29
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,7 @@
3737
import pandas as pd
3838

3939
import cirq
40-
from cirq.experiments.xeb_fitting import (
41-
XEBPhasedFSimCharacterizationOptions,
42-
)
40+
from cirq.experiments.xeb_fitting import XEBPhasedFSimCharacterizationOptions
4341
from cirq_google.api import v2
4442
from cirq_google.engine import Calibration, CalibrationLayer, CalibrationResult, Engine, EngineJob
4543
from cirq_google.ops import FSimGateFamily
@@ -211,9 +209,7 @@ class PhasedFSimCalibrationOptions(abc.ABC, Generic[RequestT]):
211209

212210
@abc.abstractmethod
213211
def create_phased_fsim_request(
214-
self,
215-
pairs: Tuple[Tuple[cirq.Qid, cirq.Qid], ...],
216-
gate: cirq.Gate,
212+
self, pairs: Tuple[Tuple[cirq.Qid, cirq.Qid], ...], gate: cirq.Gate
217213
) -> RequestT:
218214
"""Create a PhasedFSimCalibrationRequest of the correct type for these options.
219215
@@ -304,8 +300,7 @@ def engine_calibration(self) -> Optional[Calibration]:
304300

305301
@classmethod
306302
def _create_parameters_dict(
307-
cls,
308-
parameters: List[Tuple[cirq.Qid, cirq.Qid, PhasedFSimCharacterization]],
303+
cls, parameters: List[Tuple[cirq.Qid, cirq.Qid, PhasedFSimCharacterization]]
309304
) -> Dict[Tuple[cirq.Qid, cirq.Qid], PhasedFSimCharacterization]:
310305
"""Utility function to create parameters from JSON.
311306
@@ -314,10 +309,7 @@ def _create_parameters_dict(
314309
return {(q_a, q_b): params for q_a, q_b, params in parameters}
315310

316311
@classmethod
317-
def _from_json_dict_(
318-
cls,
319-
**kwargs,
320-
) -> 'PhasedFSimCalibrationResult':
312+
def _from_json_dict_(cls, **kwargs) -> 'PhasedFSimCalibrationResult':
321313
"""Magic method for the JSON serialization protocol.
322314
323315
Converts serialized dictionary into a dict suitable for
@@ -482,9 +474,7 @@ def to_args(self) -> Dict[str, Any]:
482474
return args
483475

484476
def create_phased_fsim_request(
485-
self,
486-
pairs: Tuple[Tuple[cirq.Qid, cirq.Qid], ...],
487-
gate: cirq.Gate,
477+
self, pairs: Tuple[Tuple[cirq.Qid, cirq.Qid], ...], gate: cirq.Gate
488478
) -> 'XEBPhasedFSimCalibrationRequest':
489479
return XEBPhasedFSimCalibrationRequest(pairs=pairs, gate=gate, options=self)
490480

@@ -537,9 +527,7 @@ class LocalXEBPhasedFSimCalibrationOptions(XEBPhasedFSimCalibrationOptions):
537527
n_processes: Optional[int] = None
538528

539529
def create_phased_fsim_request(
540-
self,
541-
pairs: Tuple[Tuple[cirq.Qid, cirq.Qid], ...],
542-
gate: cirq.Gate,
530+
self, pairs: Tuple[Tuple[cirq.Qid, cirq.Qid], ...], gate: cirq.Gate
543531
):
544532
return LocalXEBPhasedFSimCalibrationRequest(pairs=pairs, gate=gate, options=self)
545533

@@ -588,9 +576,7 @@ def zeta_chi_gamma_correction_override(self) -> PhasedFSimCharacterization:
588576
)
589577

590578
def create_phased_fsim_request(
591-
self,
592-
pairs: Tuple[Tuple[cirq.Qid, cirq.Qid], ...],
593-
gate: cirq.Gate,
579+
self, pairs: Tuple[Tuple[cirq.Qid, cirq.Qid], ...], gate: cirq.Gate
594580
) -> 'FloquetPhasedFSimCalibrationRequest':
595581
return FloquetPhasedFSimCalibrationRequest(pairs=pairs, gate=gate, options=self)
596582

@@ -693,9 +679,7 @@ def to_calibration_layer(self) -> CalibrationLayer:
693679
self.options.readout_error_tolerance
694680
)
695681
return CalibrationLayer(
696-
calibration_type=_FLOQUET_PHASED_FSIM_HANDLER_NAME,
697-
program=circuit,
698-
args=args,
682+
calibration_type=_FLOQUET_PHASED_FSIM_HANDLER_NAME, program=circuit, args=args
699683
)
700684

701685
def parse_result(
@@ -803,8 +787,7 @@ def _parse_xeb_fidelities_df(metrics: 'cirq_google.Calibration', super_name: str
803787

804788

805789
def _parse_characterized_angles(
806-
metrics: 'cirq_google.Calibration',
807-
super_name: str,
790+
metrics: 'cirq_google.Calibration', super_name: str
808791
) -> Dict[Tuple[cirq.Qid, cirq.Qid], Dict[str, float]]:
809792
"""Parses characterized angles from Metric protos.
810793
@@ -1088,9 +1071,7 @@ def try_convert_gate_to_fsim(gate: cirq.Gate) -> Optional[PhaseCalibratedFSimGat
10881071
return PhaseCalibratedFSimGate(cirq.FSimGate(theta=theta, phi=phi), phase_exponent)
10891072

10901073

1091-
def try_convert_syc_or_sqrt_iswap_to_fsim(
1092-
gate: cirq.Gate,
1093-
) -> Optional[PhaseCalibratedFSimGate]:
1074+
def try_convert_syc_or_sqrt_iswap_to_fsim(gate: cirq.Gate) -> Optional[PhaseCalibratedFSimGate]:
10941075
"""Converts a gate to equivalent PhaseCalibratedFSimGate if possible.
10951076
10961077
Args:

cirq-google/cirq_google/calibration/phased_fsim_test.py

+18-70
Original file line numberDiff line numberDiff line change
@@ -206,9 +206,7 @@ def test_floquet_to_calibration_layer_with_measure_qubits():
206206

207207
assert request.to_calibration_layer() == cirq_google.CalibrationLayer(
208208
calibration_type='floquet_phased_fsim_characterization',
209-
program=cirq.Circuit(
210-
[gate.on(q_00, q_01), gate.on(q_02, q_03), cirq.measure(*qubits)],
211-
),
209+
program=cirq.Circuit([gate.on(q_00, q_01), gate.on(q_02, q_03), cirq.measure(*qubits)]),
212210
args={
213211
'est_theta': True,
214212
'est_zeta': True,
@@ -459,7 +457,7 @@ def test_xeb_parse_bad_fidelities():
459457
metrics = cirq_google.Calibration(
460458
metrics={
461459
'initial_fidelities_depth_5': {
462-
('layer_0', 'pair_0', cirq.GridQubit(0, 0), cirq.GridQubit(1, 1)): [1.0],
460+
('layer_0', 'pair_0', cirq.GridQubit(0, 0), cirq.GridQubit(1, 1)): [1.0]
463461
}
464462
}
465463
)
@@ -478,21 +476,13 @@ def test_xeb_parse_bad_fidelities():
478476
)
479477

480478
metrics = cirq_google.Calibration(
481-
metrics={
482-
'initial_fidelities_depth_5x': {
483-
('layer_0', 'pair_0', '0_0', '1_1'): [1.0],
484-
}
485-
}
479+
metrics={'initial_fidelities_depth_5x': {('layer_0', 'pair_0', '0_0', '1_1'): [1.0]}}
486480
)
487481
df = _parse_xeb_fidelities_df(metrics, 'initial_fidelities')
488482
assert len(df) == 0, 'bad metric name ignored'
489483

490484
metrics = cirq_google.Calibration(
491-
metrics={
492-
'initial_fidelities_depth_5': {
493-
('bad_name_0', 'pair_0', '0_0', '1_1'): [1.0],
494-
}
495-
}
485+
metrics={'initial_fidelities_depth_5': {('bad_name_0', 'pair_0', '0_0', '1_1'): [1.0]}}
496486
)
497487
with pytest.raises(ValueError, match=r'Could not parse layer value for bad_name_0'):
498488
_parse_xeb_fidelities_df(metrics, 'initial_fidelities')
@@ -589,12 +579,8 @@ def test_floquet_parse_result_bad_metric():
589579
metrics=[
590580
cirq_google.api.v2.metrics_pb2.Metric(
591581
name='angles',
592-
targets=[
593-
'1000gerbils',
594-
],
595-
values=[
596-
cirq_google.api.v2.metrics_pb2.Value(str_val='100_10'),
597-
],
582+
targets=['1000gerbils'],
583+
values=[cirq_google.api.v2.metrics_pb2.Value(str_val='100_10')],
598584
)
599585
]
600586
)
@@ -642,33 +628,19 @@ def test_merge_matching_results():
642628
gate = cirq.FSimGate(theta=np.pi / 4, phi=0.0)
643629
options = WITHOUT_CHI_FLOQUET_PHASED_FSIM_CHARACTERIZATION
644630
parameters_1 = {
645-
(q_00, q_01): PhasedFSimCharacterization(
646-
theta=0.1, zeta=0.2, chi=None, gamma=None, phi=0.3
647-
),
631+
(q_00, q_01): PhasedFSimCharacterization(theta=0.1, zeta=0.2, chi=None, gamma=None, phi=0.3)
648632
}
649633
parameters_2 = {
650-
(q_02, q_03): PhasedFSimCharacterization(
651-
theta=0.4, zeta=0.5, chi=None, gamma=None, phi=0.6
652-
),
634+
(q_02, q_03): PhasedFSimCharacterization(theta=0.4, zeta=0.5, chi=None, gamma=None, phi=0.6)
653635
}
654636

655637
results = [
656-
PhasedFSimCalibrationResult(
657-
parameters=parameters_1,
658-
gate=gate,
659-
options=options,
660-
),
661-
PhasedFSimCalibrationResult(
662-
parameters=parameters_2,
663-
gate=gate,
664-
options=options,
665-
),
638+
PhasedFSimCalibrationResult(parameters=parameters_1, gate=gate, options=options),
639+
PhasedFSimCalibrationResult(parameters=parameters_2, gate=gate, options=options),
666640
]
667641

668642
assert merge_matching_results(results) == PhasedFSimCalibrationResult(
669-
parameters={**parameters_1, **parameters_2},
670-
gate=gate,
671-
options=options,
643+
parameters={**parameters_1, **parameters_2}, gate=gate, options=options
672644
)
673645

674646

@@ -681,53 +653,29 @@ def test_merge_matching_results_when_incompatible_fails():
681653
gate = cirq.FSimGate(theta=np.pi / 4, phi=0.0)
682654
options = WITHOUT_CHI_FLOQUET_PHASED_FSIM_CHARACTERIZATION
683655
parameters_1 = {
684-
(q_00, q_01): PhasedFSimCharacterization(
685-
theta=0.1, zeta=0.2, chi=None, gamma=None, phi=0.3
686-
),
656+
(q_00, q_01): PhasedFSimCharacterization(theta=0.1, zeta=0.2, chi=None, gamma=None, phi=0.3)
687657
}
688658
parameters_2 = {
689-
(q_02, q_03): PhasedFSimCharacterization(
690-
theta=0.4, zeta=0.5, chi=None, gamma=None, phi=0.6
691-
),
659+
(q_02, q_03): PhasedFSimCharacterization(theta=0.4, zeta=0.5, chi=None, gamma=None, phi=0.6)
692660
}
693661

694662
with pytest.raises(ValueError):
695663
results = [
696-
PhasedFSimCalibrationResult(
697-
parameters=parameters_1,
698-
gate=gate,
699-
options=options,
700-
),
701-
PhasedFSimCalibrationResult(
702-
parameters=parameters_1,
703-
gate=gate,
704-
options=options,
705-
),
664+
PhasedFSimCalibrationResult(parameters=parameters_1, gate=gate, options=options),
665+
PhasedFSimCalibrationResult(parameters=parameters_1, gate=gate, options=options),
706666
]
707667
assert merge_matching_results(results)
708668

709669
with pytest.raises(ValueError):
710670
results = [
711-
PhasedFSimCalibrationResult(
712-
parameters=parameters_1,
713-
gate=gate,
714-
options=options,
715-
),
716-
PhasedFSimCalibrationResult(
717-
parameters=parameters_2,
718-
gate=cirq.CZ,
719-
options=options,
720-
),
671+
PhasedFSimCalibrationResult(parameters=parameters_1, gate=gate, options=options),
672+
PhasedFSimCalibrationResult(parameters=parameters_2, gate=cirq.CZ, options=options),
721673
]
722674
assert merge_matching_results(results)
723675

724676
with pytest.raises(ValueError):
725677
results = [
726-
PhasedFSimCalibrationResult(
727-
parameters=parameters_1,
728-
gate=gate,
729-
options=options,
730-
),
678+
PhasedFSimCalibrationResult(parameters=parameters_1, gate=gate, options=options),
731679
PhasedFSimCalibrationResult(
732680
parameters=parameters_2,
733681
gate=gate,

0 commit comments

Comments
 (0)