[CIR][CodeGen] Support static references to temporaries

Pull Request: llvm/clangir#872

Author: lanza

clang/lib/CIR/CodeGen/CIRGenCXXABI.h

@@ -263,8 +263,7 @@ class CIRGenCXXABI {
   /// \param Dtor - a function taking a single pointer argument
   /// \param Addr - a pointer to pass to the destructor function.
   virtual void registerGlobalDtor(CIRGenFunction &CGF, const VarDecl *D,
-                                  mlir::cir::FuncOp dtor,
-                                  mlir::Attribute Addr) = 0;
+                                  mlir::cir::FuncOp dtor, mlir::Value Addr) = 0;
 
   virtual size_t getSrcArgforCopyCtor(const CXXConstructorDecl *,
                                       FunctionArgList &Args) const = 0;

clang/lib/CIR/CodeGen/CIRGenItaniumCXXABI.cpp

@@ -4443,7 +4443,7 @@ void CIRGenItaniumCXXABI::buildDestructorCall(
 void CIRGenItaniumCXXABI::registerGlobalDtor(CIRGenFunction &CGF,
                                              const VarDecl *D,
                                              mlir::cir::FuncOp dtor,
-                                             mlir::Attribute Addr) {
+                                             mlir::Value Addr) {
   if (D->isNoDestroy(CGM.getASTContext()))
     return;
 

clang/lib/CIR/CodeGen/CIRGenModule.cpp

@@ -1662,7 +1662,7 @@ CIRGenModule::getAddrOfGlobalTemporary(const MaterializeTemporaryExpr *expr,
   } else {
     // No initializer, the initialization will be provided when we initialize
     // the declaration which performed lifetime extension.
-    llvm_unreachable("else value");
+    type = getTypes().convertTypeForMem(materializedType);
   }
 
   // Create a global variable for this lifetime-extended temporary.

clang/lib/CIR/CodeGen/CIRGenModule.h

@@ -630,8 +630,8 @@ class CIRGenModule : public CIRGenTypeCache {
                                 bool IsTentative = false);
 
   /// Emit the function that initializes the specified global
-  void buildCXXGlobalVarDeclInit(const VarDecl *D, mlir::cir::GlobalOp Addr,
-                                 bool PerformInit);
+  void buildCXXGlobalVarDeclInit(const VarDecl *varDecl,
+                                 mlir::cir::GlobalOp addr, bool performInit);
 
   void buildCXXGlobalVarDeclInitFunc(const VarDecl *D, mlir::cir::GlobalOp Addr,
                                      bool PerformInit);
@@ -673,11 +673,6 @@ class CIRGenModule : public CIRGenTypeCache {
   // or if they are alias to each other.
   mlir::cir::FuncOp codegenCXXStructor(clang::GlobalDecl GD);
 
-  // Produce code for this constructor/destructor for global initialzation.
-  void codegenGlobalInitCxxStructor(const clang::VarDecl *D,
-                                    mlir::cir::GlobalOp Addr, bool NeedsCtor,
-                                    bool NeedsDtor, bool isCstStorage);
-
   bool lookupRepresentativeDecl(llvm::StringRef MangledName,
                                 clang::GlobalDecl &Result) const;