-
-
Notifications
You must be signed in to change notification settings - Fork 699
/
Copy pathreleaseConcurrencyTokenBucketQueue.ts
693 lines (585 loc) · 18.9 KB
/
releaseConcurrencyTokenBucketQueue.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
import { Callback, createRedisClient, Redis, Result, type RedisOptions } from "@internal/redis";
import { Tracer } from "@internal/tracing";
import { Logger } from "@trigger.dev/core/logger";
import { setInterval } from "node:timers/promises";
import { z } from "zod";
export type ReleaseConcurrencyQueueRetryOptions = {
maxRetries?: number;
backoff?: {
minDelay?: number; // Defaults to 1000
maxDelay?: number; // Defaults to 60000
factor?: number; // Defaults to 2
};
};
export type ReleaseConcurrencyQueueOptions<T> = {
redis: RedisOptions;
executor: (releaseQueue: T, releaserId: string) => Promise<void>;
keys: {
fromDescriptor: (releaseQueue: T) => string;
toDescriptor: (releaseQueue: string) => T;
};
maxTokens: (descriptor: T) => Promise<number>;
consumersCount?: number;
masterQueuesKey?: string;
tracer?: Tracer;
logger?: Logger;
pollInterval?: number;
batchSize?: number;
retry?: ReleaseConcurrencyQueueRetryOptions;
disableConsumers?: boolean;
};
const QueueItemMetadata = z.object({
retryCount: z.number(),
lastAttempt: z.number(),
});
type QueueItemMetadata = z.infer<typeof QueueItemMetadata>;
export class ReleaseConcurrencyTokenBucketQueue<T> {
private redis: Redis;
private logger: Logger;
private abortController: AbortController;
private consumers: ReleaseConcurrencyQueueConsumer<T>[];
private keyPrefix: string;
private masterQueuesKey: string;
private consumersCount: number;
private pollInterval: number;
private keys: ReleaseConcurrencyQueueOptions<T>["keys"];
private maxTokens: ReleaseConcurrencyQueueOptions<T>["maxTokens"];
private batchSize: number;
private maxRetries: number;
private backoff: NonNullable<Required<ReleaseConcurrencyQueueRetryOptions["backoff"]>>;
constructor(private readonly options: ReleaseConcurrencyQueueOptions<T>) {
this.redis = createRedisClient(options.redis);
this.keyPrefix = options.redis.keyPrefix ?? "re2:release-concurrency-queue:";
this.logger = options.logger ?? new Logger("ReleaseConcurrencyQueue");
this.abortController = new AbortController();
this.consumers = [];
this.masterQueuesKey = options.masterQueuesKey ?? "master-queue";
this.consumersCount = options.consumersCount ?? 1;
this.pollInterval = options.pollInterval ?? 1000;
this.keys = options.keys;
this.maxTokens = options.maxTokens;
this.batchSize = options.batchSize ?? 5;
this.maxRetries = options.retry?.maxRetries ?? 3;
this.backoff = {
minDelay: options.retry?.backoff?.minDelay ?? 1000,
maxDelay: options.retry?.backoff?.maxDelay ?? 60000,
factor: options.retry?.backoff?.factor ?? 2,
};
this.#registerCommands();
if (!options.disableConsumers) {
this.#startConsumers();
}
}
public async quit() {
this.abortController.abort();
await this.redis.quit();
}
/**
* Attempt to release concurrency for a run.
*
* If there is a token available, then immediately release the concurrency
* If there is no token available, then we'll add the operation to a queue
* and wait until the token is available.
*/
public async attemptToRelease(releaseQueueDescriptor: T, releaserId: string) {
const maxTokens = await this.#callMaxTokens(releaseQueueDescriptor);
if (maxTokens === 0) {
this.logger.debug("No tokens available, skipping release", {
releaseQueueDescriptor,
releaserId,
maxTokens,
});
return;
}
const releaseQueue = this.keys.fromDescriptor(releaseQueueDescriptor);
const result = await this.redis.consumeToken(
this.masterQueuesKey,
this.#bucketKey(releaseQueue),
this.#queueKey(releaseQueue),
this.#metadataKey(releaseQueue),
releaseQueue,
releaserId,
String(maxTokens),
String(Date.now())
);
this.logger.debug("Consumed token in attemptToRelease", {
releaseQueueDescriptor,
releaserId,
maxTokens,
result,
releaseQueue,
});
if (!!result) {
await this.#callExecutor(releaseQueueDescriptor, releaserId, {
retryCount: 0,
lastAttempt: Date.now(),
});
} else {
this.logger.info("No token available, adding to queue", {
releaseQueueDescriptor,
releaserId,
maxTokens,
releaseQueue,
});
}
}
/**
* Consume a token from the token bucket for a release queue.
*
* This is mainly used for testing purposes
*/
public async consumeToken(releaseQueueDescriptor: T, releaserId: string) {
const maxTokens = await this.#callMaxTokens(releaseQueueDescriptor);
const releaseQueue = this.keys.fromDescriptor(releaseQueueDescriptor);
if (maxTokens === 0) {
this.logger.debug("No tokens available, skipping consume", {
releaseQueueDescriptor,
releaserId,
maxTokens,
releaseQueue,
});
return;
}
await this.redis.consumeToken(
this.masterQueuesKey,
this.#bucketKey(releaseQueue),
this.#queueKey(releaseQueue),
this.#metadataKey(releaseQueue),
releaseQueue,
releaserId,
String(maxTokens),
String(Date.now())
);
this.logger.debug("Consumed token in consumeToken", {
releaseQueueDescriptor,
releaserId,
maxTokens,
releaseQueue,
});
}
/**
* Return a token to the token bucket for a release queue.
*
* This is mainly used for testing purposes
*/
public async returnToken(releaseQueueDescriptor: T, releaserId: string) {
const releaseQueue = this.keys.fromDescriptor(releaseQueueDescriptor);
this.logger.debug("Returning token in returnToken", {
releaseQueueDescriptor,
releaserId,
});
await this.redis.returnTokenOnly(
this.masterQueuesKey,
this.#bucketKey(releaseQueue),
this.#queueKey(releaseQueue),
this.#metadataKey(releaseQueue),
releaseQueue,
releaserId
);
this.logger.debug("Returned token in returnToken", {
releaseQueueDescriptor,
releaserId,
releaseQueue,
});
}
/**
* Refill the token bucket for a release queue.
*
* This will add the amount of tokens to the token bucket.
*/
public async refillTokens(releaseQueueDescriptor: T, amount: number = 1) {
const maxTokens = await this.#callMaxTokens(releaseQueueDescriptor);
const releaseQueue = this.keys.fromDescriptor(releaseQueueDescriptor);
if (amount < 0) {
this.logger.debug("Cannot refill with negative tokens", {
releaseQueueDescriptor,
amount,
});
throw new Error("Cannot refill with negative tokens");
}
if (amount === 0) {
this.logger.debug("Cannot refill with 0 tokens", {
releaseQueueDescriptor,
amount,
});
return [];
}
await this.redis.refillTokens(
this.masterQueuesKey,
this.#bucketKey(releaseQueue),
this.#queueKey(releaseQueue),
releaseQueue,
String(amount),
String(maxTokens)
);
this.logger.debug("Refilled tokens in refillTokens", {
releaseQueueDescriptor,
releaseQueue,
amount,
maxTokens,
});
}
/**
* Get the next queue that has available capacity and process one item from it
* Returns true if an item was processed, false if no items were available
*/
public async processNextAvailableQueue(): Promise<boolean> {
const result = await this.redis.processMasterQueue(
this.masterQueuesKey,
this.keyPrefix,
this.batchSize,
String(Date.now())
);
if (!result || result.length === 0) {
return false;
}
await Promise.all(
result.map(([queue, releaserId, metadata]) => {
const itemMetadata = QueueItemMetadata.parse(JSON.parse(metadata));
const releaseQueueDescriptor = this.keys.toDescriptor(queue);
return this.#callExecutor(releaseQueueDescriptor, releaserId, itemMetadata);
})
);
return true;
}
async #callExecutor(releaseQueueDescriptor: T, releaserId: string, metadata: QueueItemMetadata) {
try {
this.logger.info("Executing run:", { releaseQueueDescriptor, releaserId });
await this.options.executor(releaseQueueDescriptor, releaserId);
} catch (error) {
this.logger.error("Error executing run:", { error });
if (metadata.retryCount >= this.maxRetries) {
this.logger.error("Max retries reached:", {
releaseQueueDescriptor,
releaserId,
retryCount: metadata.retryCount,
});
// Return the token but don't requeue
const releaseQueue = this.keys.fromDescriptor(releaseQueueDescriptor);
await this.redis.returnTokenOnly(
this.masterQueuesKey,
this.#bucketKey(releaseQueue),
this.#queueKey(releaseQueue),
this.#metadataKey(releaseQueue),
releaseQueue,
releaserId
);
this.logger.info("Returned token:", { releaseQueueDescriptor, releaserId });
return;
}
const updatedMetadata: QueueItemMetadata = {
...metadata,
retryCount: metadata.retryCount + 1,
lastAttempt: Date.now(),
};
const releaseQueue = this.keys.fromDescriptor(releaseQueueDescriptor);
await this.redis.returnTokenAndRequeue(
this.masterQueuesKey,
this.#bucketKey(releaseQueue),
this.#queueKey(releaseQueue),
this.#metadataKey(releaseQueue),
releaseQueue,
releaserId,
JSON.stringify(updatedMetadata),
this.#calculateBackoffScore(updatedMetadata)
);
}
}
// Make sure maxTokens is an integer (round down)
// And if it throws, return 0
async #callMaxTokens(releaseQueueDescriptor: T) {
try {
const maxTokens = await this.maxTokens(releaseQueueDescriptor);
return Math.floor(maxTokens);
} catch (error) {
return 0;
}
}
#bucketKey(releaseQueue: string) {
return `${releaseQueue}:bucket`;
}
#queueKey(releaseQueue: string) {
return `${releaseQueue}:queue`;
}
#metadataKey(releaseQueue: string) {
return `${releaseQueue}:metadata`;
}
#startConsumers() {
const consumerCount = this.consumersCount;
for (let i = 0; i < consumerCount; i++) {
const consumer = new ReleaseConcurrencyQueueConsumer(
this,
this.pollInterval,
this.abortController.signal,
this.logger
);
this.consumers.push(consumer);
// Start the consumer and don't await it
consumer.start().catch((error) => {
this.logger.error("Consumer failed to start:", { error, consumerId: i });
});
}
}
#calculateBackoffScore(item: QueueItemMetadata): string {
const delay = Math.min(
this.backoff.maxDelay,
this.backoff.minDelay * Math.pow(this.backoff.factor, item.retryCount)
);
return String(Date.now() + delay);
}
#registerCommands() {
this.redis.defineCommand("consumeToken", {
numberOfKeys: 4,
lua: `
local masterQueuesKey = KEYS[1]
local bucketKey = KEYS[2]
local queueKey = KEYS[3]
local metadataKey = KEYS[4]
local releaseQueue = ARGV[1]
local releaserId = ARGV[2]
local maxTokens = tonumber(ARGV[3])
local score = ARGV[4]
-- Get the current token count
local currentTokens = tonumber(redis.call("GET", bucketKey) or maxTokens)
-- If we have enough tokens, then consume them
if currentTokens >= 1 then
redis.call("SET", bucketKey, currentTokens - 1)
redis.call("ZREM", queueKey, releaserId)
-- Clean up metadata when successfully consuming
redis.call("HDEL", metadataKey, releaserId)
-- Get queue length after removing the item
local queueLength = redis.call("ZCARD", queueKey)
-- If we still have tokens and items in queue, update available queues
if currentTokens > 0 and queueLength > 0 then
redis.call("ZADD", masterQueuesKey, currentTokens, releaseQueue)
else
redis.call("ZREM", masterQueuesKey, releaseQueue)
end
return true
end
-- If we don't have enough tokens, then we need to add the operation to the queue
redis.call("ZADD", queueKey, score, releaserId)
-- Initialize or update metadata
local metadata = cjson.encode({
retryCount = 0,
lastAttempt = tonumber(score)
})
redis.call("HSET", metadataKey, releaserId, metadata)
-- Remove from the master queue
redis.call("ZREM", masterQueuesKey, releaseQueue)
return false
`,
});
this.redis.defineCommand("refillTokens", {
numberOfKeys: 3,
lua: `
local masterQueuesKey = KEYS[1]
local bucketKey = KEYS[2]
local queueKey = KEYS[3]
local releaseQueue = ARGV[1]
local amount = tonumber(ARGV[2])
local maxTokens = tonumber(ARGV[3])
local currentTokens = tonumber(redis.call("GET", bucketKey) or maxTokens)
-- Add the amount of tokens to the token bucket
local newTokens = currentTokens + amount
-- If we have more tokens than the max, then set the token bucket to the max
if newTokens > maxTokens then
newTokens = maxTokens
end
redis.call("SET", bucketKey, newTokens)
-- Get the number of items in the queue
local queueLength = redis.call("ZCARD", queueKey)
-- If we have tokens available and items in the queue, add to available queues
if newTokens > 0 and queueLength > 0 then
redis.call("ZADD", masterQueuesKey, newTokens, releaseQueue)
else
redis.call("ZREM", masterQueuesKey, releaseQueue)
end
`,
});
this.redis.defineCommand("processMasterQueue", {
numberOfKeys: 1,
lua: `
local masterQueuesKey = KEYS[1]
local keyPrefix = ARGV[1]
local batchSize = tonumber(ARGV[2])
local currentTime = tonumber(ARGV[3])
-- Get the queue with the highest number of available tokens
local queues = redis.call("ZREVRANGE", masterQueuesKey, 0, 0, "WITHSCORES")
if #queues == 0 then
return nil
end
local queueName = queues[1]
local availableTokens = tonumber(queues[2])
local bucketKey = keyPrefix .. queueName .. ":bucket"
local queueKey = keyPrefix .. queueName .. ":queue"
local metadataKey = keyPrefix .. queueName .. ":metadata"
-- Get the oldest item from the queue
local items = redis.call("ZRANGEBYSCORE", queueKey, 0, currentTime, "LIMIT", 0, batchSize)
if #items == 0 then
-- No items ready to be processed yet
return nil
end
-- Calculate how many items we can actually process
local itemsToProcess = math.min(#items, availableTokens)
local results = {}
-- Consume tokens and collect results
local currentTokens = tonumber(redis.call("GET", bucketKey))
redis.call("SET", bucketKey, currentTokens - itemsToProcess)
-- Remove the items from the queue and add to results
for i = 1, itemsToProcess do
local releaserId = items[i]
redis.call("ZREM", queueKey, releaserId)
-- Get metadata before removing it
local metadata = redis.call("HGET", metadataKey, releaserId)
redis.call("HDEL", metadataKey, releaserId)
table.insert(results, { queueName, releaserId, metadata })
end
-- Get remaining queue length
local queueLength = redis.call("ZCARD", queueKey)
-- Update available queues score or remove if no more tokens
local remainingTokens = currentTokens - itemsToProcess
if remainingTokens > 0 and queueLength > 0 then
redis.call("ZADD", masterQueuesKey, remainingTokens, queueName)
else
redis.call("ZREM", masterQueuesKey, queueName)
end
return results
`,
});
this.redis.defineCommand("returnTokenAndRequeue", {
numberOfKeys: 4,
lua: `
local masterQueuesKey = KEYS[1]
local bucketKey = KEYS[2]
local queueKey = KEYS[3]
local metadataKey = KEYS[4]
local releaseQueue = ARGV[1]
local releaserId = ARGV[2]
local metadata = ARGV[3]
local score = ARGV[4]
-- Return the token to the bucket
local currentTokens = tonumber(redis.call("GET", bucketKey))
local remainingTokens = currentTokens + 1
redis.call("SET", bucketKey, remainingTokens)
-- Add the item back to the queue
redis.call("ZADD", queueKey, score, releaserId)
-- Add the metadata back to the item
redis.call("HSET", metadataKey, releaserId, metadata)
-- Update the master queue
local queueLength = redis.call("ZCARD", queueKey)
if queueLength > 0 then
redis.call("ZADD", masterQueuesKey, remainingTokens, releaseQueue)
else
redis.call("ZREM", masterQueuesKey, releaseQueue)
end
return true
`,
});
this.redis.defineCommand("returnTokenOnly", {
numberOfKeys: 4,
lua: `
local masterQueuesKey = KEYS[1]
local bucketKey = KEYS[2]
local queueKey = KEYS[3]
local metadataKey = KEYS[4]
local releaseQueue = ARGV[1]
local releaserId = ARGV[2]
-- Return the token to the bucket
local currentTokens = tonumber(redis.call("GET", bucketKey))
local remainingTokens = currentTokens + 1
redis.call("SET", bucketKey, remainingTokens)
-- Clean up metadata
redis.call("HDEL", metadataKey, releaserId)
-- Update the master queue based on remaining queue length
local queueLength = redis.call("ZCARD", queueKey)
if queueLength > 0 then
redis.call("ZADD", masterQueuesKey, remainingTokens, releaseQueue)
else
redis.call("ZREM", masterQueuesKey, releaseQueue)
end
return true
`,
});
}
}
declare module "@internal/redis" {
interface RedisCommander<Context> {
consumeToken(
masterQueuesKey: string,
bucketKey: string,
queueKey: string,
metadataKey: string,
releaseQueue: string,
releaserId: string,
maxTokens: string,
score: string,
callback?: Callback<string>
): Result<string, Context>;
refillTokens(
masterQueuesKey: string,
bucketKey: string,
queueKey: string,
releaseQueue: string,
amount: string,
maxTokens: string,
callback?: Callback<void>
): Result<void, Context>;
processMasterQueue(
masterQueuesKey: string,
keyPrefix: string,
batchSize: number,
currentTime: string,
callback?: Callback<[string, string, string][]>
): Result<[string, string, string][], Context>;
returnTokenAndRequeue(
masterQueuesKey: string,
bucketKey: string,
queueKey: string,
metadataKey: string,
releaseQueue: string,
releaserId: string,
metadata: string,
score: string,
callback?: Callback<void>
): Result<void, Context>;
returnTokenOnly(
masterQueuesKey: string,
bucketKey: string,
queueKey: string,
metadataKey: string,
releaseQueue: string,
releaserId: string,
callback?: Callback<void>
): Result<void, Context>;
}
}
class ReleaseConcurrencyQueueConsumer<T> {
private logger: Logger;
constructor(
private readonly queue: ReleaseConcurrencyTokenBucketQueue<T>,
private readonly pollInterval: number,
private readonly signal: AbortSignal,
logger?: Logger
) {
this.logger = logger ?? new Logger("QueueConsumer");
}
async start() {
try {
for await (const _ of setInterval(this.pollInterval, null, { signal: this.signal })) {
try {
const processed = await this.queue.processNextAvailableQueue();
if (!processed) {
continue;
}
} catch (error) {
this.logger.error("Error processing queue:", { error });
}
}
} catch (error) {
if (error instanceof Error && error.name !== "AbortError") {
this.logger.error("Consumer loop error:", { error });
}
}
}
}