If we’re keeping the run alive then set socket.data.requiresCheckpointResumeWithMessage to undefined

matt-aitken · matt-aitken · commit 0efed1427cbc · 2024-09-18T09:27:11.000+01:00
diff --git a/apps/coordinator/src/index.ts b/apps/coordinator/src/index.ts
@@ -853,6 +853,7 @@ class TaskCoordinator {
           });
 
           if (ack?.keepRunAlive) {
+            socket.data.requiresCheckpointResumeWithMessage = undefined;
             logger.log("keeping run alive after task checkpoint", { runId: socket.data.runId });
             return;
           }
@@ -930,6 +931,7 @@ class TaskCoordinator {
           });
 
           if (ack?.keepRunAlive) {
+            socket.data.requiresCheckpointResumeWithMessage = undefined;
             logger.log("keeping run alive after batch checkpoint", { runId: socket.data.runId });
             return;
           }

Original file line number	Diff line number	Diff line change
`@@ -853,6 +853,7 @@ class TaskCoordinator {`
`853`	`853`	`});`
`854`	`854`
`855`	`855`	`if (ack?.keepRunAlive) {`
	`856`	`+ socket.data.requiresCheckpointResumeWithMessage = undefined;`
`856`	`857`	`logger.log("keeping run alive after task checkpoint", { runId: socket.data.runId });`
`857`	`858`	`return;`
`858`	`859`	`}`
`@@ -930,6 +931,7 @@ class TaskCoordinator {`
`930`	`931`	`});`
`931`	`932`
`932`	`933`	`if (ack?.keepRunAlive) {`
	`934`	`+ socket.data.requiresCheckpointResumeWithMessage = undefined;`
`933`	`935`	`logger.log("keeping run alive after batch checkpoint", { runId: socket.data.runId });`
`934`	`936`	`return;`
`935`	`937`	`}`