Set the final error on the task run if it exists

ericallam · ericallam · commit a0c75921107b · 2024-09-26T13:25:26.000+01:00
diff --git a/apps/webapp/app/v3/services/finalizeTaskRun.server.ts b/apps/webapp/app/v3/services/finalizeTaskRun.server.ts
@@ -66,7 +66,7 @@ export class FinalizeTaskRunService extends BaseService {
       await this.finalizeAttempt({ attemptStatus, error, run });
     }
 
-    if (isFailedRunStatus(run.status)) {
+    if (error) {
       await this.finalizeRunError(run, error);
     }
 
@@ -88,11 +88,7 @@ export class FinalizeTaskRunService extends BaseService {
     return run as Output<T>;
   }
 
-  async finalizeRunError(run: TaskRun, error?: TaskRunError) {
-    if (!error) {
-      return;
-    }
-
+  async finalizeRunError(run: TaskRun, error: TaskRunError) {
     await this._prisma.taskRun.update({
       where: { id: run.id },
       data: {

Original file line number	Diff line number	Diff line change
`@@ -66,7 +66,7 @@ export class FinalizeTaskRunService extends BaseService {`
`66`	`66`	`await this.finalizeAttempt({ attemptStatus, error, run });`
`67`	`67`	`}`
`68`	`68`
`69`		`- if (isFailedRunStatus(run.status)) {`
	`69`	`+ if (error) {`
`70`	`70`	`await this.finalizeRunError(run, error);`
`71`	`71`	`}`
`72`	`72`
`@@ -88,11 +88,7 @@ export class FinalizeTaskRunService extends BaseService {`
`88`	`88`	`return run as Output<T>;`
`89`	`89`	`}`
`90`	`90`
`91`		`- async finalizeRunError(run: TaskRun, error?: TaskRunError) {`
`92`		`- if (!error) {`
`93`		`- return;`
`94`		`- }`
`95`		`-`
	`91`	`+ async finalizeRunError(run: TaskRun, error: TaskRunError) {`
`96`	`92`	`await this._prisma.taskRun.update({`
`97`	`93`	`where: { id: run.id },`
`98`	`94`	`data: {`