Skip to content

Commit d1206c3

Browse files
committed
chore(aws-protocoltests-restxml-s3): disable experimentalIdentityAndAuth
1 parent 1001848 commit d1206c3

File tree

7 files changed

+23
-450
lines changed

7 files changed

+23
-450
lines changed

private/aws-protocoltests-restxml-s3/package.json

+1-2
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@
2828
"@aws-sdk/middleware-logger": "*",
2929
"@aws-sdk/middleware-recursion-detection": "*",
3030
"@aws-sdk/middleware-sdk-s3": "*",
31+
"@aws-sdk/middleware-signing": "*",
3132
"@aws-sdk/middleware-user-agent": "*",
3233
"@aws-sdk/region-config-resolver": "*",
3334
"@aws-sdk/signature-v4-multi-region": "*",
@@ -41,7 +42,6 @@
4142
"@smithy/hash-node": "^3.0.3",
4243
"@smithy/invalid-dependency": "^3.0.3",
4344
"@smithy/middleware-content-length": "^3.0.3",
44-
"@smithy/middleware-endpoint": "^3.0.4",
4545
"@smithy/middleware-retry": "^3.0.7",
4646
"@smithy/middleware-serde": "^3.0.3",
4747
"@smithy/middleware-stack": "^3.0.3",
@@ -57,7 +57,6 @@
5757
"@smithy/util-body-length-node": "^3.0.0",
5858
"@smithy/util-defaults-mode-browser": "^3.0.7",
5959
"@smithy/util-defaults-mode-node": "^3.0.7",
60-
"@smithy/util-middleware": "^3.0.3",
6160
"@smithy/util-retry": "^3.0.3",
6261
"@smithy/util-utf8": "^3.0.0",
6362
"tslib": "^2.6.2",

private/aws-protocoltests-restxml-s3/src/S3Client.ts

+21-39
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,19 @@ import {
1414
import { getLoggerPlugin } from "@aws-sdk/middleware-logger";
1515
import { getRecursionDetectionPlugin } from "@aws-sdk/middleware-recursion-detection";
1616
import { getRegionRedirectMiddlewarePlugin, getValidateBucketNamePlugin } from "@aws-sdk/middleware-sdk-s3";
17+
import {
18+
AwsAuthInputConfig,
19+
AwsAuthResolvedConfig,
20+
getAwsAuthPlugin,
21+
resolveAwsAuthConfig,
22+
} from "@aws-sdk/middleware-signing";
1723
import {
1824
getUserAgentPlugin,
1925
resolveUserAgentConfig,
2026
UserAgentInputConfig,
2127
UserAgentResolvedConfig,
2228
} from "@aws-sdk/middleware-user-agent";
29+
import { Credentials as __Credentials } from "@aws-sdk/types";
2330
import {
2431
EndpointsInputConfig,
2532
EndpointsResolvedConfig,
@@ -28,7 +35,6 @@ import {
2835
resolveEndpointsConfig,
2936
resolveRegionConfig,
3037
} from "@smithy/config-resolver";
31-
import { DefaultIdentityProviderConfig, getHttpAuthSchemePlugin, getHttpSigningPlugin } from "@smithy/core";
3238
import { getContentLengthPlugin } from "@smithy/middleware-content-length";
3339
import { getRetryPlugin, resolveRetryConfig, RetryInputConfig, RetryResolvedConfig } from "@smithy/middleware-retry";
3440
import { HttpHandlerUserInput as __HttpHandlerUserInput } from "@smithy/protocol-http";
@@ -39,7 +45,6 @@ import {
3945
SmithyResolvedConfiguration as __SmithyResolvedConfiguration,
4046
} from "@smithy/smithy-client";
4147
import {
42-
AwsCredentialIdentityProvider,
4348
BodyLengthCalculator as __BodyLengthCalculator,
4449
CheckOptionalClientConfig as __CheckOptionalClientConfig,
4550
ChecksumConstructor as __ChecksumConstructor,
@@ -56,12 +61,6 @@ import {
5661
UserAgent as __UserAgent,
5762
} from "@smithy/types";
5863

59-
import {
60-
defaultS3HttpAuthSchemeParametersProvider,
61-
HttpAuthSchemeInputConfig,
62-
HttpAuthSchemeResolvedConfig,
63-
resolveHttpAuthSchemeConfig,
64-
} from "./auth/httpAuthSchemeProvider";
6564
import {
6665
DeleteObjectTaggingCommandInput,
6766
DeleteObjectTaggingCommandOutput,
@@ -183,6 +182,12 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
183182
*/
184183
region?: string | __Provider<string>;
185184

185+
/**
186+
* Default credentials provider; Not available in browser runtime.
187+
* @internal
188+
*/
189+
credentialDefaultProvider?: (input: any) => __Provider<__Credentials>;
190+
186191
/**
187192
* Fetch related hostname, signing name or signing region with given region.
188193
* @internal
@@ -204,13 +209,6 @@ export interface ClientDefaults extends Partial<__SmithyConfiguration<__HttpHand
204209
*/
205210
defaultUserAgentProvider?: Provider<__UserAgent>;
206211

207-
/**
208-
* Default credentials provider; Not available in browser runtime.
209-
* @deprecated
210-
* @internal
211-
*/
212-
credentialDefaultProvider?: (input: any) => AwsCredentialIdentityProvider;
213-
214212
/**
215213
* Value for how many times a request will be made at most in case of retry.
216214
*/
@@ -248,9 +246,9 @@ export type S3ClientConfigType = Partial<__SmithyConfiguration<__HttpHandlerOpti
248246
EndpointsInputConfig &
249247
RetryInputConfig &
250248
HostHeaderInputConfig &
249+
AwsAuthInputConfig &
251250
BucketEndpointInputConfig &
252-
UserAgentInputConfig &
253-
HttpAuthSchemeInputConfig;
251+
UserAgentInputConfig;
254252
/**
255253
* @public
256254
*
@@ -268,9 +266,9 @@ export type S3ClientResolvedConfigType = __SmithyResolvedConfiguration<__HttpHan
268266
EndpointsResolvedConfig &
269267
RetryResolvedConfig &
270268
HostHeaderResolvedConfig &
269+
AwsAuthResolvedConfig &
271270
BucketEndpointResolvedConfig &
272-
UserAgentResolvedConfig &
273-
HttpAuthSchemeResolvedConfig;
271+
UserAgentResolvedConfig;
274272
/**
275273
* @public
276274
*
@@ -298,9 +296,9 @@ export class S3Client extends __Client<
298296
const _config_2 = resolveEndpointsConfig(_config_1);
299297
const _config_3 = resolveRetryConfig(_config_2);
300298
const _config_4 = resolveHostHeaderConfig(_config_3);
301-
const _config_5 = resolveBucketEndpointConfig(_config_4);
302-
const _config_6 = resolveUserAgentConfig(_config_5);
303-
const _config_7 = resolveHttpAuthSchemeConfig(_config_6);
299+
const _config_5 = resolveAwsAuthConfig(_config_4);
300+
const _config_6 = resolveBucketEndpointConfig(_config_5);
301+
const _config_7 = resolveUserAgentConfig(_config_6);
304302
const _config_8 = resolveRuntimeExtensions(_config_7, configuration?.extensions || []);
305303
super(_config_8);
306304
this.config = _config_8;
@@ -309,17 +307,11 @@ export class S3Client extends __Client<
309307
this.middlewareStack.use(getHostHeaderPlugin(this.config));
310308
this.middlewareStack.use(getLoggerPlugin(this.config));
311309
this.middlewareStack.use(getRecursionDetectionPlugin(this.config));
310+
this.middlewareStack.use(getAwsAuthPlugin(this.config));
312311
this.middlewareStack.use(getValidateBucketNamePlugin(this.config));
313312
this.middlewareStack.use(getAddExpectContinuePlugin(this.config));
314313
this.middlewareStack.use(getRegionRedirectMiddlewarePlugin(this.config));
315314
this.middlewareStack.use(getUserAgentPlugin(this.config));
316-
this.middlewareStack.use(
317-
getHttpAuthSchemePlugin(this.config, {
318-
httpAuthSchemeParametersProvider: this.getDefaultHttpAuthSchemeParametersProvider(),
319-
identityProviderConfigProvider: this.getIdentityProviderConfigProvider(),
320-
})
321-
);
322-
this.middlewareStack.use(getHttpSigningPlugin(this.config));
323315
}
324316

325317
/**
@@ -330,14 +322,4 @@ export class S3Client extends __Client<
330322
destroy(): void {
331323
super.destroy();
332324
}
333-
private getDefaultHttpAuthSchemeParametersProvider() {
334-
return defaultS3HttpAuthSchemeParametersProvider;
335-
}
336-
private getIdentityProviderConfigProvider() {
337-
return async (config: S3ClientResolvedConfig) =>
338-
new DefaultIdentityProviderConfig({
339-
"aws.auth#sigv4": config.credentials,
340-
"aws.auth#sigv4a": config.credentials,
341-
});
342-
}
343325
}

private/aws-protocoltests-restxml-s3/src/auth/httpAuthExtensionConfiguration.ts

-72
This file was deleted.

0 commit comments

Comments
 (0)