Skip to content

Commit f31bf4a

Browse files
authored
Merge pull request rust-lang#2323 from smanilov/patch-2
Align advice to discourage issue-number-only names
2 parents f52e1be + d87763d commit f31bf4a

File tree

1 file changed

+6
-0
lines changed

1 file changed

+6
-0
lines changed

src/doc/rustc-dev-guide/src/tests/best-practices.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,11 @@ related tests.
7070
> //!
7171
> //! Regression test for <https://github.com/rust-lang/rust/issues/123456>.
7272
> ```
73+
>
74+
> One exception to this rule is [crashes tests]: there it is canonical that
75+
> tests are named only after issue numbers because its purpose is to track
76+
> snippets from which issues no longer ICE/crash, and they would either be
77+
> removed or converted into proper ui/other tests in the fix PRs.
7378
7479
## Test organization
7580
@@ -194,3 +199,4 @@ See [LLVM FileCheck guide][FileCheck] for details.
194199
[compiletest directives]: ./directives.md
195200
[`run-make`]: ./compiletest.md#run-make-tests
196201
[FileCheck]: https://llvm.org/docs/CommandGuide/FileCheck.html
202+
[crashes tests]: ./compiletest.md#crashes-tests

0 commit comments

Comments
 (0)