Skip to content

Commit 2b7c3c5

Browse files
[7.x][ML] Rename standardize_columns to standardization_enabled (elastic#716) (elastic#719)
Backport of elastic#716
1 parent a0291ac commit 2b7c3c5

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

include/api/CDataFrameOutliersRunner.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ class API_EXPORT CDataFrameOutliersRunner final : public CDataFrameAnalysisRunne
5757
std::size_t m_Method;
5858

5959
//! If true then standardise the feature values.
60-
bool m_StandardizeColumns = true;
60+
bool m_StandardizationEnabled = true;
6161

6262
//! Compute the significance of features responsible for each point being outlying.
6363
bool m_ComputeFeatureInfluence = true;

lib/api/CDataFrameOutliersRunner.cc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ namespace ml {
2727
namespace api {
2828
namespace {
2929
// Configuration
30-
const std::string STANDARDIZE_COLUMNS{"standardize_columns"};
30+
const std::string STANDARDIZATION_ENABLED{"standardization_enabled"};
3131
const std::string N_NEIGHBORS{"n_neighbors"};
3232
const std::string METHOD{"method"};
3333
const std::string COMPUTE_FEATURE_INFLUENCE{"compute_feature_influence"};
@@ -40,7 +40,7 @@ const CDataFrameAnalysisConfigReader PARAMETER_READER{[] {
4040
const std::string knn{"distance_kth_nn"};
4141
const std::string tnn{"distance_knn"};
4242
CDataFrameAnalysisConfigReader theReader;
43-
theReader.addParameter(STANDARDIZE_COLUMNS,
43+
theReader.addParameter(STANDARDIZATION_ENABLED,
4444
CDataFrameAnalysisConfigReader::E_OptionalParameter);
4545
theReader.addParameter(N_NEIGHBORS, CDataFrameAnalysisConfigReader::E_OptionalParameter);
4646
theReader.addParameter(METHOD, CDataFrameAnalysisConfigReader::E_OptionalParameter,
@@ -66,7 +66,7 @@ CDataFrameOutliersRunner::CDataFrameOutliersRunner(
6666
const CDataFrameAnalysisConfigReader::CParameters& parameters)
6767
: CDataFrameOutliersRunner{spec} {
6868

69-
m_StandardizeColumns = parameters[STANDARDIZE_COLUMNS].fallback(true);
69+
m_StandardizationEnabled = parameters[STANDARDIZATION_ENABLED].fallback(true);
7070
m_NumberNeighbours = parameters[N_NEIGHBORS].fallback(std::size_t{0});
7171
m_Method = parameters[METHOD].fallback(maths::COutliers::E_Ensemble);
7272
m_ComputeFeatureInfluence = parameters[COMPUTE_FEATURE_INFLUENCE].fallback(true);
@@ -113,7 +113,7 @@ void CDataFrameOutliersRunner::runImpl(const TStrVec&, core::CDataFrame& frame)
113113

114114
maths::COutliers::SComputeParameters params{this->spec().numberThreads(),
115115
this->numberPartitions(),
116-
m_StandardizeColumns,
116+
m_StandardizationEnabled,
117117
static_cast<maths::COutliers::EMethod>(m_Method),
118118
m_NumberNeighbours,
119119
m_ComputeFeatureInfluence,
@@ -138,7 +138,7 @@ CDataFrameOutliersRunner::estimateBookkeepingMemoryUsage(std::size_t numberParti
138138
std::size_t numberColumns) const {
139139
maths::COutliers::SComputeParameters params{this->spec().numberThreads(),
140140
numberPartitions,
141-
m_StandardizeColumns,
141+
m_StandardizationEnabled,
142142
static_cast<maths::COutliers::EMethod>(m_Method),
143143
m_NumberNeighbours,
144144
m_ComputeFeatureInfluence,

0 commit comments

Comments
 (0)