chore: upgrade typescript and angular (bazel-contrib#2625)

Co-authored-by: Alex Eagle <[email protected]>

Author: 2 people

internal/linker/index.js

@@ -9,6 +9,7 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
     });
 };
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.main = exports.reduceModules = void 0;
 const fs = require("fs");
 const path = require("path");
 const { runfiles: _defaultRunfiles, _BAZEL_OUT_REGEX } = require('../runfiles/index.js');

internal/node/BUILD.bazel

@@ -58,4 +58,6 @@ generated_file_test(
     name = "checked_in_node_patches",
     src = "node_patches.js",
     generated = "//packages/node-patches:bundle",
+    # For some reason rollup produces different, non-matching output with --config=no-runfiles
+    tags = ["fix-windows"],
 )

internal/npm_install/index.js

@@ -1,5 +1,6 @@
 /* THIS FILE GENERATED FROM .ts; see BUILD.bazel */ /* clang-format off */'use strict';
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.printIndexBzl = exports.printPackageBin = exports.parsePackage = exports.getDirectDependencySet = exports.main = void 0;
 const fs = require("fs");
 const path = require("path");
 const crypto = require("crypto");

internal/runfiles/index.js

@@ -1,8 +1,6 @@
 // clang-format off
 'use strict';
 
-Object.defineProperty(exports, '__esModule', { value: true });
-
 var path = require('path');
 var fs = require('fs');
 
@@ -11,18 +9,33 @@ function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'defau
 var path__default = /*#__PURE__*/_interopDefaultLegacy(path);
 var fs__default = /*#__PURE__*/_interopDefaultLegacy(fs);
 
+function getDefaultExportFromCjs (x) {
+	return x && x.__esModule && Object.prototype.hasOwnProperty.call(x, 'default') ? x['default'] : x;
+}
+
+function createCommonjsModule(fn) {
+  var module = { exports: {} };
+	return fn(module, module.exports), module.exports;
+}
+
+var paths = createCommonjsModule(function (module, exports) {
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.BAZEL_OUT_REGEX = void 0;
 // NB: on windows thanks to legacy 8-character path segments it might be like
 // c:/b/ojvxx6nx/execroot/build_~1/bazel-~1/x64_wi~1/bin/internal/npm_in~1/test
-var BAZEL_OUT_REGEX = /(\/bazel-out\/|\/bazel-~1\/x64_wi~1\/)/;
+exports.BAZEL_OUT_REGEX = /(\/bazel-out\/|\/bazel-~1\/x64_wi~1\/)/;
+});
+
+var runfiles$1 = createCommonjsModule(function (module, exports) {
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.Runfiles = void 0;
+
 
-var paths = /*#__PURE__*/Object.defineProperty({
-	BAZEL_OUT_REGEX: BAZEL_OUT_REGEX
-}, '__esModule', {value: true});
 
 /**
  * Class that provides methods for resolving Bazel runfiles.
  */
-class Runfiles$1 {
+class Runfiles {
     constructor(_env) {
         this._env = _env;
         // If Bazel sets a variable pointing to a runfiles manifest,
@@ -180,25 +193,20 @@ class Runfiles$1 {
         return this._resolve(dirname, path__default['default'].join(path__default['default'].basename(moduleBase), moduleTail || ''));
     }
 }
-var Runfiles_1 = Runfiles$1;
+exports.Runfiles = Runfiles;
+});
 
-var runfiles$1 = /*#__PURE__*/Object.defineProperty({
-	Runfiles: Runfiles_1
-}, '__esModule', {value: true});
+var runfiles = createCommonjsModule(function (module, exports) {
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.runfiles = exports._BAZEL_OUT_REGEX = exports.Runfiles = void 0;
 
-var Runfiles = runfiles$1.Runfiles;
+Object.defineProperty(exports, "Runfiles", { enumerable: true, get: function () { return runfiles$1.Runfiles; } });
 
-var _BAZEL_OUT_REGEX = paths.BAZEL_OUT_REGEX;
+Object.defineProperty(exports, "_BAZEL_OUT_REGEX", { enumerable: true, get: function () { return paths.BAZEL_OUT_REGEX; } });
 /** Instance of the runfile helpers. */
-var runfiles_2 = new runfiles$1.Runfiles(process.env);
+exports.runfiles = new runfiles$1.Runfiles(process.env);
+});
 
-var runfiles = /*#__PURE__*/Object.defineProperty({
-	Runfiles: Runfiles,
-	_BAZEL_OUT_REGEX: _BAZEL_OUT_REGEX,
-	runfiles: runfiles_2
-}, '__esModule', {value: true});
+var index = /*@__PURE__*/getDefaultExportFromCjs(runfiles);
 
-exports.Runfiles = Runfiles;
-exports._BAZEL_OUT_REGEX = _BAZEL_OUT_REGEX;
-exports.default = runfiles;
-exports.runfiles = runfiles_2;
+module.exports = index;

package.json

@@ -14,10 +14,10 @@
         "yarn": ">=1.13.0"
     },
     "devDependencies": {
-        "@angular/common": "^9.1.0",
-        "@angular/compiler": "^9.1.0",
-        "@angular/compiler-cli": "^9.1.0",
-        "@angular/core": "^9.1.0",
+        "@angular/common": "^11.2.11",
+        "@angular/compiler": "^11.2.11",
+        "@angular/compiler-cli": "^11.2.11",
+        "@angular/core": "^11.2.11",
         "@babel/cli": "^7.6.2",
         "@babel/core": "^7.6.2",
         "@babel/preset-env": "^7.6.2",
@@ -92,11 +92,11 @@
         "tsickle": "0.38.0",
         "tsutils": "2.27.2",
         "typeorm": "0.2.18",
-        "typescript": "^3.7.5",
+        "typescript": "4.0.2",
         "unidiff": "1.0.1",
         "yarn": "1.22.0",
         "c8": "7.5.0",
-        "zone.js": "0.8.29"
+        "zone.js": "^0.11.4"
     },
     "// resolutions/**/jest-serializer": "need to resolve to a version that doesn't have a /// <reference path='../v8.d.ts' /> in build/index.d.ts which exposes a bug in ts_library",
     "resolutions": {

packages/esbuild/test/typescript/bundle.golden.txt

@@ -32,6 +32,7 @@ var require_module_dynamic = __commonJS((exports, module) => {
   })(function(require2, exports2) {
     "use strict";
     Object.defineProperty(exports2, "__esModule", {value: true});
+    exports2.getId = void 0;
     exports2.getId = () => "dynamic-id";
   });
 });

packages/protractor/test/protractor/conf.ts

@@ -33,7 +33,7 @@ exports.config = {
 
       browser.baseUrl = `http://localhost:${port}`;
 
-      return new Promise(resolve => {
+      return new Promise<void>(resolve => {
         app.listen(port, () => {
           resolve();
         });

packages/rollup/test/multi_linker/BUILD.bazel

@@ -16,6 +16,7 @@ rollup_bundle(
     name = "bundle",
     config_file = "rollup.config.js",
     entry_point = "main.js",
+    sourcemap = "hidden",
     deps = [
         "tsconfig",
         "@rollup_test_multi_linker_deps//@rollup/plugin-commonjs",

packages/rollup/test/multi_linker/golden.js_

@@ -14,9 +14,9 @@ function commonjsRequire () {
 
 var lib = createCommonjsModule(function (module, exports) {
 exports.__esModule = true;
+exports.key = void 0;
 exports.key = 'rollup';
 });
 
 var key = lib.key;
 console.log(key);
-//# sourceMappingURL=data:application/json;charset=utf-8;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiYnVuZGxlLmpzIiwic291cmNlcyI6WyJsaWIuanMiLCJtYWluLmpzIl0sInNvdXJjZXNDb250ZW50IjpbIlwidXNlIHN0cmljdFwiO1xuZXhwb3J0cy5fX2VzTW9kdWxlID0gdHJ1ZTtcbmV4cG9ydHMua2V5ID0gJ3JvbGx1cCc7XG4iLCJ2YXIga2V5ID0gcmVxdWlyZSgnLi9saWInKS5rZXk7XG5jb25zb2xlLmxvZyhrZXkpO1xuIl0sIm5hbWVzIjpbInJlcXVpcmUkJDAiXSwibWFwcGluZ3MiOiI7Ozs7Ozs7Ozs7Ozs7OztBQUNBLGtCQUFrQixHQUFHLElBQUksQ0FBQztBQUMxQixXQUFXLEdBQUcsUUFBUTs7O0FDRnRCLElBQUksR0FBRyxHQUFHQSxHQUFnQixDQUFDLEdBQUcsQ0FBQztBQUMvQixPQUFPLENBQUMsR0FBRyxDQUFDLEdBQUcsQ0FBQyJ9

packages/typescript/internal/worker/index.js

@@ -51,14 +51,13 @@ function getWatchProgram(args) {
     return cachedWatchedProgram;
 }
 function emitOnce(args) {
-    var _a;
     return __awaiter(this, void 0, void 0, function* () {
         const watchProgram = getWatchProgram(args);
         if (consolidateChangesCallback) {
             consolidateChangesCallback();
         }
         workerRequestTimestamp = Date.now();
-        const result = yield ((_a = watchProgram) === null || _a === void 0 ? void 0 : _a.getProgram().emit(undefined, undefined, {
+        const result = yield (watchProgram === null || watchProgram === void 0 ? void 0 : watchProgram.getProgram().emit(undefined, undefined, {
             isCancellationRequested: function (timestamp) {
                 return timestamp !== workerRequestTimestamp;
             }.bind(null, workerRequestTimestamp),
@@ -94,7 +93,7 @@ function main() {
             argsFilePath = argsFilePath.slice(1);
         }
         const args = fs.readFileSync(argsFilePath).toString().split('\n');
-        emitOnce(args).finally(() => { var _a; return (_a = cachedWatchedProgram) === null || _a === void 0 ? void 0 : _a.close(); });
+        emitOnce(args).finally(() => cachedWatchedProgram === null || cachedWatchedProgram === void 0 ? void 0 : cachedWatchedProgram.close());
     }
 }
 if (require.main === module) {

packages/typescript/test/errorchecks/BUILD.bazel

@@ -18,7 +18,7 @@ ts_library(
     name = "erroneous",
     srcs = glob(["*.ts"]),
     expected_diagnostics = [
-        "TS2322: Type '\"not a number\"' is not assignable to type 'number'",
+        "TS2322: Type 'string' is not assignable to type 'number'",
         "TS2304: Cannot find name 'TypeThatDoesNotExist'",
     ],
 )

packages/typescript/test/target_module_attributes/override_output_test.js

@@ -16,9 +16,10 @@ describe('googmodule', () => {
   });
 
   it('should have es5 in devmode', () => {
-    expect(fs.readFileSync(devmodeOutput, {
-      encoding: 'utf-8'
-    })).toContain(`exports.a = function () { return 'hello world'; };`);
+    const devoutput = fs.readFileSync(devmodeOutput, {encoding: 'utf-8'});
+
+    expect(devoutput).toContain(`a = function () { return 'hello world'; };`);
+    expect(devoutput).toContain(`exports.a = `);
   });
 
   it('should have amd module syntax in prodmode', () => {
@@ -28,8 +29,9 @@ describe('googmodule', () => {
   });
 
   it('should have es5 in prodmode', () => {
-    expect(fs.readFileSync(prodmodeOutput, {
-      encoding: 'utf-8'
-    })).toContain(`exports.a = function () { return 'hello world'; };`);
+    const prodoutput = fs.readFileSync(prodmodeOutput, {encoding: 'utf-8'});
+
+    expect(prodoutput).toContain(`a = function () { return 'hello world'; };`);
+    expect(prodoutput).toContain(`exports.a = `);
   });
 });

packages/typescript/test/ts_project/generated_tsconfig/default/expected.js_

@@ -1,3 +1,4 @@
 "use strict";
 exports.__esModule = true;
+exports.a = void 0;
 exports.a = 'hello world';

packages/typescript/test/ts_project/generated_tsconfig/extends/expected.js_

@@ -1,3 +1,4 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
+exports.a = void 0;
 exports.a = 'hello world';

packages/typescript/test/ts_project/generated_tsconfig/gen_src/expected.js_

@@ -1,3 +1,4 @@
 "use strict";
 exports.__esModule = true;
+exports.a = void 0;
 exports.a = 'hello world';

packages/typescript/test/ts_project/outdir/a.golden.cjs

@@ -1,3 +1,4 @@
 "use strict";
 exports.__esModule = true;
+exports.a = void 0;
 exports.a = 1;

packages/typescript/test/ts_project/simple/index.golden.js

@@ -1,3 +1,4 @@
 "use strict";
 exports.__esModule = true;
+exports.a = void 0;
 exports.a = 'hello';