Skip to content
This repository was archived by the owner on Feb 3, 2022. It is now read-only.

Use fixed window size if it is not available #24

Closed
philnash opened this issue Oct 3, 2019 · 3 comments
Closed

Use fixed window size if it is not available #24

philnash opened this issue Oct 3, 2019 · 3 comments
Assignees
Labels
good first issue Good for newcomers hacktoberfest A good hacktoberfest issue for someone new to the project

Comments

@philnash
Copy link
Contributor

philnash commented Oct 3, 2019

This package uses the window-size module to make sure the success message formats correctly based on the window size of the user's terminal.

Like in twilio-run/#82, it could break if the window-size module cannot return a width and height.

We should default to a fixed width of, say, 80 in the case where window-size doesn't return a value.

Steps to implement:

  • Create a new file in src/create-twilio-function called window-size.js
  • implement a get function that returns either the object that the window-size module would return or a default of { width: 80, height: 300 } (including tests)
  • replace the use of window-size in success-message.js with this new module
@philnash philnash added good first issue Good for newcomers hacktoberfest A good hacktoberfest issue for someone new to the project labels Oct 3, 2019
@whitneyrosenberg
Copy link
Contributor

Would it be alright if I took this task?

@philnash
Copy link
Contributor Author

philnash commented Oct 3, 2019

@whitneyrosenberg go for it!

@philnash
Copy link
Contributor Author

philnash commented Oct 3, 2019

Closed by #25 .

@philnash philnash closed this as completed Oct 3, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers hacktoberfest A good hacktoberfest issue for someone new to the project
Projects
None yet
Development

No branches or pull requests

2 participants