Skip to content

Commit 50eae0a

Browse files
authored
fix: update links to route to regional console (#535)
* fix: update links to route to regional console * chore: add changeset
1 parent 14e4d32 commit 50eae0a

File tree

5 files changed

+28
-13
lines changed

5 files changed

+28
-13
lines changed
+5
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'twilio-run': patch
3+
---
4+
Display access visibility for public assets and functions on deploy.
5+
Update links to route to regional console

packages/twilio-run/src/commands/promote.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -94,7 +94,7 @@ export async function handler(
9494
config.targetEnvironment || 'production'
9595
}`
9696
);
97-
printActivateResult(result, config.outputFormat);
97+
printActivateResult(result, config.outputFormat, config.region);
9898
} catch (err) {
9999
handleError(err, spinner);
100100
}

packages/twilio-run/src/printers/activate.ts

+7-2
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,8 @@ export function printActivateConfig(
2525

2626
export function printActivateResult(
2727
result: ActivateResult,
28-
outputFormat: OutputFormat
28+
outputFormat: OutputFormat,
29+
region = 'us1'
2930
) {
3031
if (outputFormat === 'json') {
3132
writeJSONOutput(result);
@@ -36,7 +37,11 @@ export function printActivateResult(
3637

3738
const twilioConsoleLogsLink = terminalLink(
3839
'Open the Twilio Console',
39-
getTwilioConsoleDeploymentUrl(result.serviceSid, result.environmentSid),
40+
getTwilioConsoleDeploymentUrl(
41+
result.serviceSid,
42+
result.environmentSid,
43+
region
44+
),
4045
{
4146
fallback: (text: string, url: string) => chalk.dim(url),
4247
}

packages/twilio-run/src/printers/deploy.ts

+11-7
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,8 @@ function plainPrintDeployedResources(
6464
runtime: result.runtime,
6565
viewLiveLogs: getTwilioConsoleDeploymentUrl(
6666
result.serviceSid,
67-
result.environmentSid
67+
result.environmentSid,
68+
config.region
6869
),
6970
};
7071

@@ -132,7 +133,11 @@ function prettyPrintDeployedResources(
132133
) {
133134
const twilioConsoleLogsLink = terminalLink(
134135
'Open the Twilio Console',
135-
getTwilioConsoleDeploymentUrl(result.serviceSid, result.environmentSid),
136+
getTwilioConsoleDeploymentUrl(
137+
result.serviceSid,
138+
result.environmentSid,
139+
config.region
140+
),
136141
{
137142
fallback: (text: string, url: string) => chalk.dim(url),
138143
}
@@ -159,8 +164,7 @@ function prettyPrintDeployedResources(
159164
const functionMessage = result.functionResources
160165
.sort(sortByAccess)
161166
.map((fn) => {
162-
const accessPrefix =
163-
chalk`{bold [${fn.access}]} `;
167+
const accessPrefix = chalk`{bold [${fn.access}]} `;
164168
return chalk` ${accessPrefix}{dim https://${result.domain}}${fn.path}`;
165169
})
166170
.join('\n');
@@ -172,8 +176,7 @@ function prettyPrintDeployedResources(
172176
const assetMessage = result.assetResources
173177
.sort(sortByAccess)
174178
.map((asset) => {
175-
const accessPrefix =
176-
chalk`{bold [${asset.access}]} `;
179+
const accessPrefix = chalk`{bold [${asset.access}]} `;
177180
const accessUrl =
178181
asset.access === 'private'
179182
? chalk`{dim Runtime.getAssets()['}${asset.path}{dim ']}`
@@ -223,7 +226,8 @@ export function printJsonDeployedResources(
223226
runtime: result.runtime,
224227
viewLiveLogs: getTwilioConsoleDeploymentUrl(
225228
result.serviceSid,
226-
result.environmentSid
229+
result.environmentSid,
230+
config.region
227231
),
228232
functions: result.functionResources.sort(sortByAccess).map(formatResource),
229233
assets: result.assetResources.sort(sortByAccess).map(formatResource),

packages/twilio-run/src/printers/utils.ts

+4-3
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,10 @@ export const supportsEmoji =
1111

1212
export function getTwilioConsoleDeploymentUrl(
1313
serviceSid: string,
14-
environmentSid: string
14+
environmentSid: string,
15+
region = 'us1'
1516
) {
16-
return `https://www.twilio.com/console/functions/editor/${serviceSid}/environment/${environmentSid}`;
17+
return `https://console.twilio.com/${region}/develop/functions/editor/${serviceSid}/environment/${environmentSid}`;
1718
}
1819

1920
export function printObjectWithoutHeaders(obj: {}): string {
@@ -27,7 +28,7 @@ export function terminalLink(name: string, link: string): string {
2728
export function borderLeft(text: string, color: string): string {
2829
return text
2930
.split('\n')
30-
.map(str => `${chalk.keyword(color)('│')} ${str}`)
31+
.map((str) => `${chalk.keyword(color)('│')} ${str}`)
3132
.join('\n');
3233
}
3334

0 commit comments

Comments
 (0)