chore(plugin-assets): updates to @twilio/cli-core v7 (#419)

* chore(plugin-assets): updates to @twilio/cli-core v7

Replaces @oclif/command and @oclif/config with @oclif/core
Updates ./bin/run command and adds ./bin/dev command
Sets engines property in package to Node 14 (matches @oclif/core)

* chore(plugin-serverless): updates to @twilio/cli-core v7

Replaces `@oclif/command` and `@oclif/config` with `@oclif/core`
Updates `./bin/run` command and adds `./bin/dev` command
Sets engines property in package to Node 14 (matches `@oclif/core`)

Updates commands to call `await this.parse`
  - For commands that inherit from `TwilioClientCommand`, flags and args
    are already parsed into `this.flags` and `this.args` when
    `super.run()` is called. This removes the call to parse a second
    time and uses `this.flags` and `this.args` instead

* fix(plugin-assets): make *.cmd files runnable

* chore(plugin-assets): adds package.json main property

Copied from: https://github.com/oclif/hello-world/blob/main/src/index.ts

Co-authored-by: Dominik Kundel <[email protected]>

Author: philnash

Diff for: packages/plugin-assets/bin/dev

@@ -0,0 +1,15 @@
+#!/usr/bin/env node
+
+const oclif = require('@oclif/core');
+
+// In dev mode -> use ts-node and dev plugins
+process.env.NODE_ENV = 'development';
+
+// In dev mode, always show stack traces
+oclif.settings.debug = true;
+
+// Configure the Twilio CLI environment
+require('@twilio/cli-core').configureEnv();
+
+// Start the CLI
+oclif.run().then(oclif.flush).catch(oclif.Errors.handle);

Diff for: packages/plugin-assets/bin/dev.cmd

@@ -0,0 +1,3 @@
+@echo off
+
+node "%~dp0\dev" %*

Diff for: packages/plugin-assets/bin/run

@@ -1,9 +1,12 @@
 #!/usr/bin/env node
 // Load up the command module *first* so that we're the parent rather than
 // some other dependency.
-const command = require('@oclif/command');
+
+const oclif = require('@oclif/core');
 
 require('@twilio/cli-core').configureEnv();
-command.run()
-  .then(require('@oclif/command/flush'))
-  .catch(require('@oclif/errors/handle'));
+
+oclif
+  .run()
+  .then(require('@oclif/core/flush'))
+  .catch(require('@oclif/core/handle'));

Diff for: packages/plugin-assets/bin/run.cmd

@@ -6,25 +6,24 @@
   "contributors": [
     "Phil Nash <[email protected]>"
   ],
+  "main": "src/index.js",
   "dependencies": {
-    "@oclif/command": "^1.5.19",
-    "@oclif/config": "^1.13.3",
+    "@oclif/core": "^1.14.2",
     "@twilio-labs/serverless-api": "^5.4.4",
-    "@twilio/cli-core": "^6.0.0",
+    "@twilio/cli-core": "^7.0.0",
     "inquirer": "^8.0.0",
     "ora": "^5.4.0",
     "project-name-generator": "^2.1.9"
   },
   "devDependencies": {
-    "@oclif/dev-cli": "^1.22.2",
-    "@oclif/plugin-help": "^2.2.1",
+    "@oclif/plugin-help": "^5.1.12",
     "@oclif/test": "^1.2.5",
     "@twilio/cli-test": "^2.1.1",
     "jest": "^26.6.3",
     "rimraf": "^3.0.2"
   },
   "engines": {
-    "node": ">=10"
+    "node": ">=14"
   },
   "files": [
     "/oclif.manifest.json",

Diff for: packages/plugin-assets/package.json

@@ -1,4 +1,4 @@
-const { flags } = require('@oclif/command');
+const { Flags } = require('@oclif/core');
 const { TwilioClientCommand } = require('@twilio/cli-core').baseCommands;
 const { getPluginConfig } = require('../../pluginConfig');
 const generateProjectName = require('project-name-generator');
@@ -28,11 +28,11 @@ class InitCommand extends TwilioClientCommand {
 }
 
 InitCommand.flags = {
-  'service-name': flags.string({
+  'service-name': Flags.string({
     description:
       'A unique name for your asset service. May only contain alphanumeric characters and hyphens.',
   }),
-  properties: flags.string({
+  properties: Flags.string({
     default: 'service_sid, sid, domain_name',
     description:
       'The asset service environment properties you would like to display (JSON output always shows all properties).',

Diff for: packages/plugin-assets/src/commands/assets/init.js

@@ -1,4 +1,4 @@
-const { flags } = require('@oclif/command');
+const { Flags } = require('@oclif/core');
 const { TwilioClientCommand } = require('@twilio/cli-core').baseCommands;
 const { getPluginConfig } = require('../../pluginConfig');
 const { list } = require('../../list');
@@ -25,7 +25,7 @@ class ListCommand extends TwilioClientCommand {
 ListCommand.description = 'List all the assets in the service';
 
 ListCommand.flags = {
-  properties: flags.string({
+  properties: Flags.string({
     default: 'sid, path, url, visibility',
     description:
       'The asset properties you would like to display (JSON output always shows all properties).',

Diff for: packages/plugin-assets/src/commands/assets/list.js

@@ -1,4 +1,4 @@
-const { flags } = require('@oclif/command');
+const { Flags } = require('@oclif/core');
 const { TwilioClientCommand } = require('@twilio/cli-core').baseCommands;
 const { getPluginConfig } = require('../../pluginConfig');
 const { upload } = require('../../upload');
@@ -37,11 +37,11 @@ UploadCommand.args = [
 ];
 
 UploadCommand.flags = {
-  protected: flags.boolean({
+  protected: Flags.boolean({
     default: false,
     description: "Sets the uploaded asset's visibility to 'protected'",
   }),
-  properties: flags.string({
+  properties: Flags.string({
     default: 'sid, path, url, visibility',
     description:
       'The asset properties you would like to display (JSON output always shows all properties).',

Diff for: packages/plugin-assets/src/commands/assets/upload.js

@@ -0,0 +1,2 @@
+const { run } = require('@oclif/core');
+module.exports = run;