Better error messages if the cli fails to create a directory. Fixes #14

Author: philnash

packages/create-twilio-function/CHANGELOG.md

@@ -2,7 +2,8 @@
 
 ## Ongoing [☰](https://github.com/twilio-labs/create-twilio-function/compare/v1.0.1...master)
 
-...
+- Minor updates
+  - Better error messages if the cli fails to create a directory. Fixes #14
 
 ## 1.0.1 (May 4, 2018) [☰](https://github.com/twilio-labs/create-twilio-function/compare/v1.0.0...v1.0.1)
 

packages/create-twilio-function/src/create-twilio-function.js

@@ -21,11 +21,24 @@ async function createTwilioFunction(config) {
   try {
     await createDirectory(config.path, config.name);
   } catch (e) {
-    console.error(
-      `A directory called '${
-        config.name
-      }' already exists. Please create your function in a new directory.`
-    );
+    switch (e.code) {
+      case 'EEXIST':
+        console.error(
+          `A directory called '${
+            config.name
+          }' already exists. Please create your function in a new directory.`
+        );
+        break;
+      case 'EACCES':
+        console.error(
+          `You do not have permission to create files or directories in the path '${
+            config.path
+          }'.`
+        );
+        break;
+      default:
+        console.error(e.message);
+    }
     return;
   }
 

packages/create-twilio-function/tests/create-twilio-function.test.js

@@ -88,9 +88,35 @@ describe('createTwilioFunction', () => {
 
     await createTwilioFunction({ name, path: './scratch' });
 
-    expect.assertions(3);
+    expect.assertions(4);
 
     expect(console.error).toHaveBeenCalledTimes(1);
+    expect(console.error).toHaveBeenCalledWith(
+      `A directory called '${name}' already exists. Please create your function in a new directory.`
+    );
+    expect(console.log).not.toHaveBeenCalled();
+
+    try {
+      await stat(`./scratch/${name}/package.json`);
+    } catch (e) {
+      expect(e.toString()).toMatch('no such file or directory');
+    }
+  });
+
+  it("fails gracefully if it doesn't have permission to create directories", async () => {
+    const name = 'test-function';
+    const chmod = promisify(fs.chmod);
+    await chmod('./scratch', 0o555);
+    console.error = jest.fn();
+
+    await createTwilioFunction({ name, path: './scratch' });
+
+    expect.assertions(4);
+
+    expect(console.error).toHaveBeenCalledTimes(1);
+    expect(console.error).toHaveBeenCalledWith(
+      `You do not have permission to create files or directories in the path './scratch'.`
+    );
     expect(console.log).not.toHaveBeenCalled();
 
     try {