refactor(assets): starting work on tests

Author: philnash

Diff for: packages/plugin-assets/jest.config.js

@@ -0,0 +1,10 @@
+const base = require('../../jest.config.base.js');
+const { join } = require('path');
+
+module.exports = {
+  ...base,
+  preset: null,
+  name: 'plugin-assets',
+  displayName: 'plugin-assets',
+  globalTeardown: join(__dirname, 'jest.teardown.js'),
+};

Diff for: packages/plugin-assets/jest.teardown.js

@@ -0,0 +1,7 @@
+const { join } = require('path');
+const { tmpdir } = require('os');
+const rimraf = require('rimraf');
+
+module.exports = () => {
+  rimraf.sync(join(tmpdir(), 'scratch'));
+};

Diff for: packages/plugin-assets/package.json

@@ -21,7 +21,9 @@
     "@oclif/dev-cli": "^1.22.2",
     "@oclif/plugin-help": "^2.2.1",
     "@oclif/test": "^1.2.5",
-    "@twilio/cli-test": "^2.0.2"
+    "@twilio/cli-test": "^2.0.2",
+    "jest": "^26.6.3",
+    "rimraf": "^3.0.2"
   },
   "engines": {
     "node": ">=10"
@@ -76,6 +78,7 @@
   "scripts": {
     "postpack": "rm -f oclif.manifest.json",
     "prepack": "oclif-dev manifest && oclif-dev readme",
-    "version": "oclif-dev readme && git add README.md"
+    "version": "oclif-dev readme && git add README.md",
+    "test": "jest"
   }
 }

Diff for: packages/plugin-assets/src/configStore.js

@@ -1,5 +1,5 @@
 const { join } = require('path');
-const { readFile, writeFile } = require('fs/promises');
+const { readFile, writeFile, mkdir } = require('fs/promises');
 
 const CONFIG_FILE_NAME = 'plugin-assets-config.json';
 
@@ -21,6 +21,7 @@ class ConfigStore {
   }
 
   async save(config) {
+    await mkdir(this.configDir, { recursive: true });
     writeFile(this.configPath, JSON.stringify(config), { encoding: 'utf-8' });
   }
 }

Diff for: packages/plugin-assets/src/init.js

@@ -10,7 +10,7 @@ const { ConfigStore } = require('./configStore');
 const { createUtils } = require('./utils');
 const { printInBox } = require('./print');
 
-const { spinner, debug, handleError } = createUtils('init');
+const { spinner, handleError } = createUtils('init');
 
 const DEFAULT_ASSET_SERVICE_NAME = 'CLI-Assets-Bucket';
 

Diff for: packages/plugin-assets/tests/init.test.js

@@ -0,0 +1,42 @@
+const { init } = require('../src/init');
+const path = require('path');
+const fs = require('fs/promises');
+const { tmpdir } = require('os');
+const { equal } = require('assert');
+
+jest.mock('@twilio-labs/serverless-api/dist/api/services', () => {
+  return { createService: jest.fn().mockResolvedValue('new-service-sid') };
+});
+jest.mock('@twilio-labs/serverless-api/dist/api/environments', () => {
+  return {
+    createEnvironmentFromSuffix: jest
+      .fn()
+      .mockResolvedValue({ sid: 'new-environment-sid' }),
+  };
+});
+
+describe('init', () => {
+  describe('with nothing in the config', () => {
+    it('creates a new service and environment and writes it to config', async () => {
+      const configPath = path.join(
+        tmpdir(),
+        'scratch',
+        'plugin-assets-config.json'
+      );
+      await init({
+        apiKey: 'apiKey',
+        apiSecret: 'apiSecret',
+        accountSid: 'test-account-sid',
+        configDir: path.dirname(configPath),
+      });
+
+      const config = JSON.parse(
+        await fs.readFile(configPath, { encoding: 'utf-8' })
+      );
+      expect(config['test-account-sid']['serviceSid']).toBe('new-service-sid');
+      expect(config['test-account-sid']['environmentSid']).toBe(
+        'new-environment-sid'
+      );
+    });
+  });
+});