Skip to content

Commit e1602db

Browse files
authored
fix: update node runtime versions available (#376)
* fix: update node runtime versions available node10 is no longer available, node14 is coming * fix(deploy): don't show runtime as undefined
1 parent 989307d commit e1602db

File tree

4 files changed

+5
-7
lines changed

4 files changed

+5
-7
lines changed

Diff for: packages/serverless-api/src/types/deploy.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ type DeployProjectConfigBase = {
4444
*/
4545
overrideExistingService?: boolean;
4646
/**
47-
* Version of Node.js to deploy with in Twilio Runtime. Can be "node10" or "node12"
47+
* Version of Node.js to deploy with in Twilio Runtime. Can be "node12" or "node14"
4848
*/
4949
runtime?: string;
5050
};

Diff for: packages/twilio-run/__tests__/templating/__snapshots__/defaultConfig.test.ts.snap

+1-1
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@ exports[`writeDefaultConfigFile default file should match snapshot 1`] = `
3636
// \\"production\\": false /* Promote build to the production environment (no domain suffix). Overrides environment flag */,
3737
// \\"properties\\": null /* Specify the output properties you want to see. Works best on single types */,
3838
// \\"region\\": null /* Twilio API Region */,
39-
// \\"runtime\\": null /* The version of Node.js to deploy the build to. (node10 or node12) */,
39+
// \\"runtime\\": null /* The version of Node.js to deploy the build to. (node12 or node14) */,
4040
// \\"serviceName\\": null /* Overrides the name of the Serverless project. Default: the name field in your package.json */,
4141
// \\"serviceSid\\": null /* SID of the Twilio Serverless Service to deploy to */,
4242
// \\"sourceEnvironment\\": null /* SID or suffix of an existing environment you want to deploy from. */,

Diff for: packages/twilio-run/src/flags.ts

+2-4
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ export const ALL_FLAGS = {
229229
runtime: {
230230
type: 'string',
231231
describe:
232-
'The version of Node.js to deploy the build to. (node10 or node12)',
232+
'The version of Node.js to deploy the build to. (node12 or node14)',
233233
} as Options,
234234
key: {
235235
type: 'string',
@@ -251,9 +251,7 @@ export const ALL_FLAGS = {
251251
export type AvailableFlags = typeof ALL_FLAGS;
252252
export type FlagNames = keyof AvailableFlags;
253253

254-
export function getRelevantFlags(
255-
flags: FlagNames[]
256-
): {
254+
export function getRelevantFlags(flags: FlagNames[]): {
257255
[flagName: string]: Options;
258256
} {
259257
return flags.reduce((current: { [flagName: string]: Options }, flagName) => {

Diff for: packages/twilio-run/src/printers/deploy.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ ${serviceInfo}
9898
{bold.cyan Root Directory}\t${config.cwd}
9999
{bold.cyan Dependencies}\t${dependencyString}
100100
{bold.cyan Env Variables}\t${Object.keys(config.env).join(', ')}
101-
{bold.cyan Runtime}\t\t${config.runtime}
101+
{bold.cyan Runtime}\t\t${config.runtime || 'default'}
102102
`
103103
);
104104
}

0 commit comments

Comments
 (0)