Adds nvmrc file when creating new function.

Fixes #8.

Author: philnash

packages/create-twilio-function/src/create-twilio-function.js

@@ -3,7 +3,8 @@ const {
   createDirectory,
   createEnvFile,
   createExampleFunction,
-  createPackageJSON
+  createPackageJSON,
+  createNvmrcFile
 } = require('./create-twilio-function/create-files');
 const createGitignore = require('./create-twilio-function/create-gitignore');
 const importCredentials = require('./create-twilio-function/import-credentials');
@@ -44,6 +45,7 @@ async function createTwilioFunction(config) {
     accountSid: config.accountSid,
     authToken: config.authToken
   });
+  await createNvmrcFile(projectDir);
   await createExampleFunction(`${projectDir}/functions`);
   await createPackageJSON(projectDir, config.name);
   spinner.succeed();

packages/create-twilio-function/src/create-twilio-function/create-files.js

@@ -1,3 +1,4 @@
+const versions = require('./versions');
 const fs = require('fs');
 const { promisify } = require('util');
 const mkdir = promisify(fs.mkdir);
@@ -26,8 +27,9 @@ function createPackageJSON(path, name) {
         start: 'twilio-run --env'
       },
       devDependencies: {
-        'twilio-run': '^1.0.0-beta.4'
-      }
+        'twilio-run': versions.twilioRun
+      },
+      engines: { node: versions.node }
     },
     null,
     2
@@ -52,9 +54,16 @@ AUTH_TOKEN=${authToken}`;
   return createFile(fullPath, content);
 }
 
+function createNvmrcFile(path) {
+  const fullPath = `${path}/.nvmrc`;
+  const content = versions.node;
+  return createFile(fullPath, content);
+}
+
 module.exports = {
   createDirectory,
   createPackageJSON,
   createExampleFunction,
-  createEnvFile
+  createEnvFile,
+  createNvmrcFile
 };

packages/create-twilio-function/src/create-twilio-function/versions.js

@@ -0,0 +1,4 @@
+module.exports = {
+  twilioRun: '^1.0.1',
+  node: '8.10.0'
+};

packages/create-twilio-function/tests/create-files.test.js

@@ -2,8 +2,10 @@ const {
   createPackageJSON,
   createDirectory,
   createExampleFunction,
-  createEnvFile
+  createEnvFile,
+  createNvmrcFile
 } = require('../src/create-twilio-function/create-files');
+const versions = require('../src/create-twilio-function/versions');
 const fs = require('fs');
 const { promisify } = require('util');
 const rimraf = promisify(require('rimraf'));
@@ -48,6 +50,10 @@ describe('createPackageJSON', () => {
     expect(file.isFile());
     const packageJSON = JSON.parse(await readFile('./scratch/package.json'));
     expect(packageJSON.name).toEqual('project-name');
+    expect(packageJSON.engines.node).toEqual(versions.node);
+    expect(packageJSON.devDependencies['twilio-run']).toEqual(
+      versions.twilioRun
+    );
   });
 
   test('it rejects if there is already a package.json', async () => {
@@ -109,3 +115,23 @@ describe('createEnvFile', () => {
     }
   });
 });
+
+describe('createNvmrcFile', () => {
+  test('it creates a new .nvmrc file', async () => {
+    await createNvmrcFile('./scratch');
+    const file = await stat('./scratch/.nvmrc');
+    expect(file.isFile());
+    const contents = await readFile('./scratch/.nvmrc', { encoding: 'utf-8' });
+    expect(contents).toMatch(versions.node);
+  });
+
+  test('it rejects if there is already an .nvmrc file', async () => {
+    fs.closeSync(fs.openSync('./scratch/.nvmrc', 'w'));
+    expect.assertions(1);
+    try {
+      await createNvmrcFile('./scratch');
+    } catch (e) {
+      expect(e.toString()).toMatch('file already exists');
+    }
+  });
+});

packages/create-twilio-function/tests/create-twilio-function.test.js

@@ -58,6 +58,8 @@ describe('createTwilioFunction', () => {
     expect(dir.isDirectory());
     const env = await stat(`./scratch/${name}/.env`);
     expect(env.isFile());
+    const nvmrc = await stat(`./scratch/${name}/.nvmrc`);
+    expect(nvmrc.isFile());
 
     const packageJSON = await stat(`./scratch/${name}/package.json`);
     expect(packageJSON.isFile());