Skip to content

Add a way to change the location of function templates #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dkundel opened this issue Feb 26, 2020 · 0 comments · Fixed by #115
Closed

Add a way to change the location of function templates #113

dkundel opened this issue Feb 26, 2020 · 0 comments · Fixed by #115

Comments

@dkundel
Copy link
Contributor

dkundel commented Feb 26, 2020

In order to be more friendly to contributors and allow them to test their templates before submitting them to github.com/twilio-labs/function-templates. It would also allow us to verify that they are working before merging the PR.

Since this is not a common feature (for now), I would propose to do this as an environment variable along the lines of TWILIO_FUNCTION_TEMPLATES_ENDPOINT that can be set to override the actual variables used in data.ts: https://github.com/twilio-labs/twilio-run/blob/8fbe2e1867bafa840afab774994b46c71752f337/src/templating/data.ts#L8-L11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant