Skip to content

activate does not send and enable new --env configuration #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
bpartridge83 opened this issue Feb 3, 2020 · 1 comment · Fixed by #142
Closed

activate does not send and enable new --env configuration #109

bpartridge83 opened this issue Feb 3, 2020 · 1 comment · Fixed by #142
Assignees
@philnash
Milestone
v3

Comments

@bpartridge83
Copy link

When activating between two environments, --env files specified during the command aren't enabled in the new environment.

Example:

  • Deploy to dev: twilio serverless:deploy --env=.env.dev --environment=dev
  • dev now running with .env.dev variables
  • Activate (promote) from dev to stage: twilio serverless:activate --env=.env.stage --source-environment=dev --environment=stage
  • stage now running with .env.dev variables, not .env.stage variables
@welcome
Copy link

welcome bot commented Feb 3, 2020

Thank you so much for opening your first issue in this project! We'll try to get back to it as quickly as possible. While you are waiting...here's a random picture of a corgi (powered by dog.ceo)

picture of dog

@dkundel dkundel added this to the v3 milestone May 18, 2020
@philnash philnash self-assigned this Jun 15, 2020
philnash added a commit to philnash/serverless-api that referenced this issue Jun 15, 2020
@philnash
fix(activate): activating with environment variables
6fd07c8 
Previously activating a build would not set any env vars, this fixes that.
twilio-labs/serverless-toolkit#109
philnash added a commit to philnash/serverless-api that referenced this issue Jun 15, 2020
@philnash
fix(activate): activating with environment variables
6da7976 
Previously activating a build would not set any env vars, this fixes that.
twilio-labs/serverless-toolkit#109
philnash added a commit to philnash/twilio-run that referenced this issue Jun 15, 2020
@philnash
fix(activate): prepare and pass env vars to serverless-api activateBuild
14d25d2 
Fixes: twilio-labs#109
This was referenced Jun 15, 2020
Merged
Merged
philnash added a commit that referenced this issue Jun 16, 2020
@philnash
fix(activate): prepare and pass env vars to serverless-api activateBu…
808fe47 
…ild (#142)

* fix(activate): prepare and pass env vars to serverless-api activateBuild

* chore: rename prepareEnvForDeploy to filterEnvVariablesForDeploy

* chore: adds test for filterEnvVariablesForDeploy

* chore(deps): updates @twilio-labs/serverless-api to 3.1.0

Fixes: #109
@snyk-bot snyk-bot mentioned this issue Jul 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@philnash philnash

Labels
None yet
Projects
None yet
Milestone
v3
Development

Successfully merging a pull request may close this issue.

fix(activate): prepare and pass env vars to serverless-api activateBuild philnash/twilio-run
3 participants
@philnash @bpartridge83 @dkundel