Skip to content

Add config support #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dkundel opened this issue Jun 27, 2019 · 0 comments
Closed

Add config support #15

dkundel opened this issue Jun 27, 2019 · 0 comments
Labels
v-next

Comments

@dkundel
Copy link
Contributor

dkundel commented Jun 27, 2019

It would be nice to have config support especially for deployment configuration or to override dependencies you want to install.
@dkundel dkundel added the v-next label Jun 28, 2019
dkundel added a commit that referenced this issue Jul 17, 2019
@dkundel
feat: introduce config file functionality (#15)
bc66edf 
With this change we are starting to allow .twilio-functions for more than just storing some build
outcomes. It supprts grouping configs by environment, command or project or nested combinations of
these

fix: #15
@dkundel dkundel mentioned this issue Jul 17, 2019
Merged
1 task
dkundel added a commit that referenced this issue Jul 17, 2019
@dkundel
feat: add config support for list,activate,deploy (#15)
19a4124 
This commit adds config file support for the list, activate and deploy
command.

It also deprecates the --functions-env flag

BREAKING CHANGE: Deprecating --functions-env as an option

fix: #15, fix: #27
dkundel added a commit that referenced this issue Jul 21, 2019
@dkundel
feat: introduce config file functionality (#15)
b8a14e1 
With this change we are starting to allow .twilio-functions for more than just storing some build
outcomes. It supprts grouping configs by environment, command or project or nested combinations of
these

fix: #15
dkundel added a commit that referenced this issue Jul 21, 2019
@dkundel
feat: add config support for list,activate,deploy (#15)
d0b77a8 
This commit adds config file support for the list, activate and deploy
command.

It also deprecates the --functions-env flag

BREAKING CHANGE: Deprecating --functions-env as an option

fix: #15, fix: #27
dkundel added a commit that referenced this issue Jul 25, 2019
@dkundel
feat: introduce config file functionality (#15)
a40b9e2 
With this change we are starting to allow .twilio-functions for more than just storing some build
outcomes. It supprts grouping configs by environment, command or project or nested combinations of
these

fix: #15
dkundel added a commit that referenced this issue Jul 25, 2019
@dkundel
feat: add config support for list,activate,deploy (#15)
ae8ba8f 
This commit adds config file support for the list, activate and deploy
command.

It also deprecates the --functions-env flag

BREAKING CHANGE: Deprecating --functions-env as an option

fix: #15, fix: #27
dkundel added a commit that referenced this issue Jul 26, 2019
@dkundel
feat: introduce config file functionality (#15) (#38)
a86f017 
* feat: introduce config file functionality (#15)

With this change we are starting to allow .twilio-functions for more than just storing some build outcomes. It supports grouping configs by environment, command or project or nested combinations of these.

Very extended config:

```json
{
	"startConfig": {
		"ngrok": "dom",
		"inspect": ""
	},
	"environments": {
		"dev": {
			"deployConfig": {
				"env": ".env"
			}
		},
		"prod": {
			"deployConfig": {
				"env": ".env.prod"
			}
		}
	},
	"projects": {
		"ACc2bdaa19578061b45a518axxxxxxxxxx": {
			"serviceSid": "ZSd6e3037c5710c8e8c979f5xxxxxxxxxx",
			"latestBuild": "ZBdf824389570e3ee2ebcec7xxxxxxxxxx",
			"deployConfig": {
				"environment": "prod"
			}
		}
	},
	"serviceSid": "ZSd6e3037c5710c8e8c979fxxxxxxxxxx",
	"latestBuild": "ZBdf824389570e3ee2ebcec7xxxxxxxxxx"
}
```

fix: #15

* feat: add config support for list,activate,deploy (#15)

This commit adds config file support for the list, activate and deploy
command.

It also deprecates the --functions-env flag

BREAKING CHANGE: Deprecating --functions-env as an option

fix: #15, fix: #27

* refactor(config): factor out common code for testability

* fix(config): write serviceSid to config

This creates compatibility of config files for twilio-run

* test(config): add basic test for list config

* feat(runtime): handle invalid account sid & new error page

This change will check for valid Account SIDs in local development mode and create an appropriate
error message. It also introduces a new Error response page

BREAKING CHANGE: Error page layout changed

fix #45

* chore(release): 2.0.0-beta.13

* fix: update code for new version of severless-api (#46)

* fix: update code for new version of severless-api

re twilio-labs/serverless-api#8

* chore(npm): upgrade @twilio-labs/serverless-api

* fix(tests): fix integration tests

Remove the reliance on stacktraces in the error integration tests

* chore(release): 2.0.0-rc.0

* chore(npm): upgrade serverless-api library

* chore(release): 2.0.0-rc.1

* feat(new): change from prompts to inquirer (#36)

Prompts has a bug for screens that are smaller than the content. This fix hasn't been launched yet
so we are switching to inquirer.

fixes #36

* fix(templates): switch template list endpoint to next branch

The templates are currently pulled from the next branch but the list was from master, causing some
templates to crash

* feat: introduce config file functionality (#15)

With this change we are starting to allow .twilio-functions for more than just storing some build
outcomes. It supprts grouping configs by environment, command or project or nested combinations of
these

fix: #15

* feat: add config support for list,activate,deploy (#15)

This commit adds config file support for the list, activate and deploy
command.

It also deprecates the --functions-env flag

BREAKING CHANGE: Deprecating --functions-env as an option

fix: #15, fix: #27

* refactor(config): factor out common code for testability

* fix(config): write serviceSid to config

This creates compatibility of config files for twilio-run

* test(config): add basic test for list config

* feat(config): accept external config options

* test(config): add more tests for configs

* fix(config): store under accountSid not API key
@dkundel dkundel closed this as completed Jul 26, 2019
dkundel added a commit that referenced this issue Aug 10, 2020
@dkundel
fix(build): reject promise on failed build
49ba3c7 
fix #15
dkundel added a commit that referenced this issue Aug 10, 2020
@dkundel
fix(build): reject promise on failed build
afa2f8c 
fix #15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v-next
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dkundel