Skip to content

Replace projectName #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
dkundel opened this issue Jun 28, 2019 · 0 comments
Closed

Replace projectName #17

dkundel opened this issue Jun 28, 2019 · 0 comments
Labels
v-next

Comments

@dkundel
Copy link
Contributor

dkundel commented Jun 28, 2019 •
edited
Loading

Right now we are using projectName as a way to configure the name of your deployment. This is confusing especially with the Twilio CLI having a different concept of projects. Let's move to serviceName instead.

We should support projectName as a fallback with a warning.
@dkundel dkundel added the v-next label Jun 28, 2019
@dkundel dkundel changed the title Replace projectName with serviceName for consistency Replace projectName Jun 28, 2019
dkundel added a commit that referenced this issue Jul 10, 2019
@dkundel
feat: replace projectName with serviceName
c5c8ab2 
The term "project" is being used a lot in the Twilio CLI and causes a lot of confusion

BREAKING CHANGE: --project-name is now deprecated and --service-name should be used instead

fix #17
dkundel added a commit that referenced this issue Aug 10, 2020
@dkundel
feat: replace projectName with serviceName for consistency
e598ba5 
The term "project" is being used a lot in the Twilio CLI and causes a lot of confusion

BREAKING CHANGE: projectName is no longer valid and serviceName has to be used instead

fix #17
dkundel pushed a commit that referenced this issue Aug 10, 2020
@butuzov
docs(readme): update (absolute) link to CONTRIBUTING.md (#17)
01b20de 
link to contributing.md changed to absolute

Reason for this - is website https://serverless-api.twilio-labs.com/  that generated by this readme
doesn't actually have CONTRIBUTING.md
dkundel added a commit that referenced this issue Aug 10, 2020
@dkundel
feat: replace projectName with serviceName for consistency
2e35c8b 
The term "project" is being used a lot in the Twilio CLI and causes a lot of confusion

BREAKING CHANGE: projectName is no longer valid and serviceName has to be used instead

fix #17
dkundel pushed a commit that referenced this issue Aug 10, 2020
@butuzov @dkundel
docs(readme): update (absolute) link to CONTRIBUTING.md (#17)
a96eab2 
link to contributing.md changed to absolute

Reason for this - is website https://serverless-api.twilio-labs.com/  that generated by this readme
doesn't actually have CONTRIBUTING.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v-next
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dkundel