Skip to content

--logLevel=debug overwrites context variable AUTH_TOKEN #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ShelbyZ opened this issue Aug 27, 2019 · 1 comment · Fixed by #79
Closed

--logLevel=debug overwrites context variable AUTH_TOKEN #78

ShelbyZ opened this issue Aug 27, 2019 · 1 comment · Fixed by #79

Comments

@ShelbyZ
Copy link
Contributor

ShelbyZ commented Aug 27, 2019

Using the run option --logLevel=debug will redact AUTH_TOKEN if part of the context object.

image

This becomes a problem when a function uses the context object to interact with the twilio library via context.getTwilioClient() as it will use ACCOUNT_SID and AUTH_TOKEN to authenticate. Printing the values stored in context results in below:

image

It looks like the redaction code is permanently changing the context variable and it seems like it should not.

@dkundel
Copy link
Contributor

dkundel commented Aug 27, 2019

Thanks for catching that! I created a PR to fix it. I also didn't forget about the Windows commit hooks issue but haven't gotten around to fixing that one yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants