Skip to content

fix(debug): fix redaction of logger overwriting values #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 30, 2019

Conversation

dkundel
Copy link
Contributor

@dkundel dkundel commented Aug 27, 2019

As described by @ShelbyZ, the redaction apparently overrides the original object. I added tests to catch that going forward and fixed the behavior by copying the original object. I think that's a fine behavior because this is only happening when debug logs are enabled. Therefore performance is less of a concern.

fix #78

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

@dkundel dkundel requested a review from philnash August 27, 2019 23:00
Copy link
Contributor

@philnash philnash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dkundel dkundel merged commit c5c6081 into master Aug 30, 2019
@dkundel dkundel deleted the dkundel/fix-redactor branch August 30, 2019 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--logLevel=debug overwrites context variable AUTH_TOKEN
2 participants