Skip to content

feat: allow the same namespace but different files #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Oct 18, 2019

Closes #69

this allows you to install multiple templates under the same
namepace

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

this allows you to install multiple templates under the same
namepace
@imnotjames
Copy link
Contributor Author

Need to add tests..

@imnotjames imnotjames changed the title allow the same namespace but different files improvement: allow the same namespace but different files Oct 19, 2019
@imnotjames imnotjames changed the title improvement: allow the same namespace but different files chore: allow the same namespace but different files Oct 19, 2019
@imnotjames imnotjames changed the title chore: allow the same namespace but different files feat: allow the same namespace but different files Oct 19, 2019
@imnotjames
Copy link
Contributor Author

A few comments:

The templating/filesystem tests were completely missing so I added some.

I moved mkdir to utils/fs out of templating/filesystem to simplify testing.

I removed a definition of debug and an export of fileExists - neither of which were in use.

There seems to be a few bugs that I found during writing tests. I'll make sure to open issues & eventual PRs to fix them. However, for now I've gone ahead and "documented" the bugs with tests that verify the behavior.

I pulled in listr-silent-renderer explicitly instead of transitively so listr output can be disabled for tests.

I experimented with mock-fs for testing these filesystem changes and it interacted poorly with some dynamic module loading being done.

@imnotjames imnotjames marked this pull request as ready for review October 21, 2019 08:47
@dkundel
Copy link
Contributor

dkundel commented Nov 2, 2019

Hey @imnotjames! Sorry for the late review and thank you so much for your contribution. I'll try to get back to this as soon as possible to take a look at it. Thank you!

@dkundel dkundel merged commit b4fde66 into twilio-labs:master Jan 10, 2020
@welcome
Copy link

welcome bot commented Jan 10, 2020

Congratulations on your first contribution to the Serverless Toolkit!
We'd love to say thank you and send you some swag. If you are interested please fill out this form at https://twil.io/hacktoberfest-swag
If you are on the look out for more ways to contribute to open-source, check out a list of some of our repositories at https://github.com/twilio/opensource.
And if you love Twilio as much as we do, make sure to check out our Twilio Champions program!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Function creation in the same namespace throws
2 participants