fix!: only camelCase object keys when a schema is specified for the value (#83)

childish-sambino · Sam Harrison · commit 42d94fdd8aa5 · 2020-04-14T09:03:41.000-05:00
diff --git a/src/services/api-schema/twilio-converter.js b/src/services/api-schema/twilio-converter.js
@@ -18,7 +18,11 @@ class TwilioSchemaConverter extends JsonSchemaConverter {
       propValue = this.convertSchema(propSchema, propValue);
     }
 
-    return { propName: camelCase(propName), propValue };
+    if (propSchema) {
+      propName = camelCase(propName);
+    }
+
+    return { propName, propValue };
   }
 
   convertString(schema, value) {
diff --git a/test/services/api-schema.test.js b/test/services/api-schema.test.js
@@ -37,7 +37,7 @@ describe('services', () => {
           dateCreated: new Date('September 15, 2008 15:53 GMT+0500'),
           dateUpdated: new Date('September 15, 2008 15:53 GMT+0500'),
           messageType: ['not', 'a', 'message'],
-          freeFormObj: { firstKey: 'first_value', secondKey: 'second_value' },
+          freeFormObj: { first_key: 'first_value', second_key: 'second_value' },
           someUri: '/2010-04-01/Accounts/ACXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXXX.json'
         };
 

Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,11 @@ class TwilioSchemaConverter extends JsonSchemaConverter {`
`18`	`18`	`propValue = this.convertSchema(propSchema, propValue);`
`19`	`19`	`}`
`20`	`20`
`21`		`- return { propName: camelCase(propName), propValue };`
	`21`	`+ if (propSchema) {`
	`22`	`+ propName = camelCase(propName);`
	`23`	`+ }`
	`24`	`+`
	`25`	`+ return { propName, propValue };`
`22`	`26`	`}`
`23`	`27`
`24`	`28`	`convertString(schema, value) {`