Skip to content

Maximum allowed jwt version (2.5) is outdated #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
MarcPer opened this issue Jan 2, 2023 · 1 comment · Fixed by #626
Closed

Maximum allowed jwt version (2.5) is outdated #625

MarcPer opened this issue Jan 2, 2023 · 1 comment · Fixed by #626
Labels
type: twilio enhancement feature request on Twilio's roadmap

Comments

@MarcPer
Copy link
Contributor

MarcPer commented Jan 2, 2023 •
edited
Loading

Issue Summary

A new version of JWT was released (2.6.0), but twilio-ruby requires it to be <= 2.5.

According to JWT's changelog, the new version only adds features. I've ran existing integration tests from my codebase, and twilio-ruby's own tests, using twilio-ruby 3.11.6 together with jwt 2.6.0, and they all passed.

Technical details:

  • twilio-ruby version: 3.11.6
  • ruby version: 3.1.2
@MarcPer MarcPer mentioned this issue Jan 2, 2023
Merged
4 tasks
@MarcPer MarcPer changed the title Maximum allowed jwt version (2.5.0) is outdated Maximum allowed jwt version (2.5) is outdated Jan 3, 2023
@Hunga1 Hunga1 added type: twilio enhancement feature request on Twilio's roadmap status: waiting for feature feature will be implemented in the future labels Jan 4, 2023
@Hunga1
Copy link
Contributor

Hunga1 commented Jan 4, 2023

This issue has been added to our internal backlog to be prioritized. Pull requests and +1s on the issue summary will help it move up the backlog (internal ref: DI-2507).

@childish-sambino childish-sambino removed the status: waiting for feature feature will be implemented in the future label Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: Bump jwt version max version to 2.6
3 participants
@MarcPer @Hunga1 @childish-sambino