fix(action): add support of http.HTTPMethod to action decorator

Signed-off-by: Sergei Shishov <[email protected]>

Author: sshishov

rest_framework-stubs/decorators.pyi

@@ -1,4 +1,5 @@
 from collections.abc import Callable, Mapping, Sequence
+from http import HTTPMethod
 from typing import Any, Literal, Protocol, TypeVar
 
 from django.http import HttpRequest
@@ -29,43 +30,24 @@ class MethodMapper(dict):
     def options(self, func: _View) -> _View: ...
     def trace(self, func: _View) -> _View: ...
 
-_LOWER_CASE_HTTP_VERBS: TypeAlias = Sequence[
-    Literal[
-        "get",
-        "post",
-        "delete",
-        "put",
-        "patch",
-        "trace",
-        "head",
-        "options",
-    ]
-]
-
 _MIXED_CASE_HTTP_VERBS: TypeAlias = Sequence[
+    # fmt: off
     Literal[
-        "GET",
-        "POST",
-        "DELETE",
-        "PUT",
-        "PATCH",
-        "TRACE",
-        "HEAD",
-        "OPTIONS",
-        "get",
-        "post",
-        "delete",
-        "put",
-        "patch",
-        "trace",
-        "head",
-        "options",
+        "get"    , "GET"    , HTTPMethod.GET    ,
+        "post"   , "POST"   , HTTPMethod.POST   ,
+        "delete" , "DELETE" , HTTPMethod.DELETE ,
+        "put"    , "PUT"    , HTTPMethod.PUT    ,
+        "patch"  , "PATCH"  , HTTPMethod.PATCH  ,
+        "trace"  , "TRACE"  , HTTPMethod.TRACE  ,
+        "head"   , "HEAD"   , HTTPMethod.HEAD   ,
+        "options", "OPTIONS", HTTPMethod.OPTIONS,
     ]
+    # fmt: on
 ]
 
 class ViewSetAction(Protocol[_View]):
     detail: bool
-    methods: _LOWER_CASE_HTTP_VERBS
+    methods: _MIXED_CASE_HTTP_VERBS
     url_path: str
     url_name: str
     kwargs: Mapping[str, Any]

tests/typecheck/test_decorators.yml

@@ -49,6 +49,8 @@
 
 - case: method_decorator
   main: |
+    from http import HTTPMethod
+
     from rest_framework import viewsets
     from rest_framework.decorators import action
     from rest_framework.request import Request
@@ -59,5 +61,11 @@
       @action(methods=("get",), detail=False)
       def view_func_1(self, request: Request) -> Response: ...
 
-      @action(methods=["post",], detail=False)
+      @action(methods=["post"], detail=False)
       def view_func_2(self, request: Request) -> Response: ...
+
+      @action(methods=("GET",), detail=False)
+      def view_func_3(self, request: Request) -> Response: ...
+
+      @action(methods=[HTTPMethod.POST], detail=False)
+      def view_func_4(self, request: Request) -> Response: ...