From 9ae4c0f205ba249e652f1a400acb8b596fa4acc4 Mon Sep 17 00:00:00 2001 From: DongwookKim0823 Date: Wed, 3 Jul 2024 20:04:44 +0900 Subject: [PATCH] Remove unnecessary variables and add required types in APIRequestFactory method signatures --- rest_framework-stubs/test.pyi | 12 ++++++------ scripts/stubtest/allowlist_todo.txt | 6 ------ 2 files changed, 6 insertions(+), 12 deletions(-) diff --git a/rest_framework-stubs/test.pyi b/rest_framework-stubs/test.pyi index 156ce89ed..ceaf3b0bf 100644 --- a/rest_framework-stubs/test.pyi +++ b/rest_framework-stubs/test.pyi @@ -59,12 +59,12 @@ class APIRequestFactory(DjangoRequestFactory): renderer_classes: Any def __init__(self, enforce_csrf_checks: bool = ..., **defaults: Any) -> None: ... def request(self, **kwargs: Any) -> Request: ... # type: ignore[override] - def get(self, path: str, data: _GetDataType = ..., follow: bool = ..., **extra: Any) -> Request: ... # type: ignore[override] - def post(self, path: str, data: Any | None = ..., format: str | None = ..., content_type: str | None = ..., follow: bool = ..., **extra: Any) -> Request: ... # type: ignore[override] - def put(self, path: str, data: Any | None = ..., format: str | None = ..., content_type: str | None = ..., follow: bool = ..., **extra: Any) -> Request: ... # type: ignore[override] - def patch(self, path: str, data: Any | None = ..., format: str | None = ..., content_type: str | None = ..., follow: bool = ..., **extra: Any) -> Request: ... # type: ignore[override] - def delete(self, path: str, data: Any | None = ..., format: str | None = ..., content_type: str | None = ..., follow: bool = ..., **extra: Any) -> Request: ... # type: ignore[override] - def options(self, path: str, data: dict[str, str] | str = ..., format: str | None = ..., content_type: Any | None = ..., follow: bool = ..., **extra: Any) -> Request: ... # type: ignore[override] + def get(self, path: str, data: _GetDataType = ..., **extra: Any) -> Request: ... # type: ignore[override] + def post(self, path: str, data: Any | None = ..., format: str | None = ..., content_type: str | None = ..., **extra: Any) -> Request: ... # type: ignore[override] + def put(self, path: str, data: Any | None = ..., format: str | None = ..., content_type: str | None = ..., **extra: Any) -> Request: ... # type: ignore[override] + def patch(self, path: str, data: Any | None = ..., format: str | None = ..., content_type: str | None = ..., **extra: Any) -> Request: ... # type: ignore[override] + def delete(self, path: str, data: Any | None = ..., format: str | None = ..., content_type: str | None = ..., **extra: Any) -> Request: ... # type: ignore[override] + def options(self, path: str, data: dict[str, str] | str | None = ..., format: str | None = ..., content_type: Any | None = ..., **extra: Any) -> Request: ... # type: ignore[override] def generic( # type: ignore[override] self, method: str, path: str, data: str = ..., content_type: str = ..., secure: bool = ..., **extra: Any ) -> Request: ... diff --git a/scripts/stubtest/allowlist_todo.txt b/scripts/stubtest/allowlist_todo.txt index 17a706b3d..9b407de32 100644 --- a/scripts/stubtest/allowlist_todo.txt +++ b/scripts/stubtest/allowlist_todo.txt @@ -103,12 +103,6 @@ rest_framework.settings.DefaultsSettings rest_framework.settings.api_settings rest_framework.templatetags.rest_framework.urlize_quoted_links rest_framework.test.APIClient.options -rest_framework.test.APIRequestFactory.delete -rest_framework.test.APIRequestFactory.get -rest_framework.test.APIRequestFactory.options -rest_framework.test.APIRequestFactory.patch -rest_framework.test.APIRequestFactory.post -rest_framework.test.APIRequestFactory.put rest_framework.test.RequestsClient.__init__ rest_framework.throttling.SimpleRateThrottle.cache rest_framework.utils.encoders.JSONEncoder.default