Skip to content

Commit ebc5278

Browse files
author
Josh Goldberg
authored
Removed plugin prefixes from converter and merger paths (#1203)
* Removed plugin prefixes from conveter and merger paths * Moved up ngrx- and rxjs- * Cleaned up rxjs converters * A couple cleanups * Fix add too * Missing rxjs-no-unsafe-takeuntil ruleName * Corrected ngrx-no-duplicate-action-types.test.ts * Added prefer-inline-decorator.test.ts * Ugh one more
1 parent a63c8bc commit ebc5278

File tree

351 files changed

+785
-782
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

351 files changed

+785
-782
lines changed

Diff for: src/converters/lintConfigs/rules/ruleConverters.ts

+230-231
Large diffs are not rendered by default.

Diff for: src/converters/lintConfigs/rules/ruleConverters/codelyzer/angular-whitespace.ts renamed to src/converters/lintConfigs/rules/ruleConverters/angular-whitespace.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertAngularWhitespace: RuleConverter = () => {
44
return {};

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-sonarjs/cognitive-complexity.ts renamed to src/converters/lintConfigs/rules/ruleConverters/cognitive-complexity.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertCognitiveComplexity: RuleConverter = (tslintRule) => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/codelyzer/component-class-suffix.ts renamed to src/converters/lintConfigs/rules/ruleConverters/component-class-suffix.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertComponentClassSuffix: RuleConverter = (tslintRule) => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/codelyzer/component-max-inline-declarations.ts renamed to src/converters/lintConfigs/rules/ruleConverters/component-max-inline-declarations.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertComponentMaxInlineDeclarations: RuleConverter = (tslintRule) => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/codelyzer/component-selector.ts renamed to src/converters/lintConfigs/rules/ruleConverters/component-selector.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertComponentSelector: RuleConverter = (tslintRule) => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-sonarjs/consecutive-overloads.ts renamed to src/converters/lintConfigs/rules/ruleConverters/consecutive-overloads.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertConsecutiveOverloads: RuleConverter = () => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/codelyzer/contextual-decorator.ts renamed to src/converters/lintConfigs/rules/ruleConverters/contextual-decorator.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertContextualDecorator: RuleConverter = () => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/codelyzer/contextual-lifecycle.ts renamed to src/converters/lintConfigs/rules/ruleConverters/contextual-lifecycle.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertContextualLifecycle: RuleConverter = () => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/codelyzer/directive-class-suffix.ts renamed to src/converters/lintConfigs/rules/ruleConverters/directive-class-suffix.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertDirectiveClassSuffix: RuleConverter = (tslintRule) => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/codelyzer/directive-selector.ts renamed to src/converters/lintConfigs/rules/ruleConverters/directive-selector.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertDirectiveSelector: RuleConverter = (tslintRule) => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/add.ts

-5
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/deep-operators.ts

-5
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-add.ts

-5
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-deep-operators.ts

-5
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-operator.ts

-5
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-patched.ts

-5
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-unsafe-scope.ts

-5
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-unused-add.ts

-5
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/no-wholesale.ts

-5
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/prefer-add.ts

-5
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/add.test.ts

-11
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/deep-operators.test.ts

-11
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-deep-operators.test.ts

-11
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-operator.test.ts

-11
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-unsafe-scope.test.ts

-11
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-unused-add.test.ts

-11
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/no-wholesale.test.ts

-11
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-rxjs/tests/prefer-add.test.ts

-11
This file was deleted.

Diff for: src/converters/lintConfigs/rules/ruleConverters/codelyzer/import-destructuring-spacing.ts renamed to src/converters/lintConfigs/rules/ruleConverters/import-destructuring-spacing.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertImportDestructuringSpacing: RuleConverter = () => {
44
return {};

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-react/jsx-ban-props.ts renamed to src/converters/lintConfigs/rules/ruleConverters/jsx-ban-props.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertJsxBanProps: RuleConverter = (tslintRule) => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-react/jsx-boolean-value.ts renamed to src/converters/lintConfigs/rules/ruleConverters/jsx-boolean-value.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertJsxBooleanValue: RuleConverter = (tslintRule) => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-react/jsx-curly-spacing.ts renamed to src/converters/lintConfigs/rules/ruleConverters/jsx-curly-spacing.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertJsxCurlySpacing: RuleConverter = (tslintRule) => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-react/jsx-equals-spacing.ts renamed to src/converters/lintConfigs/rules/ruleConverters/jsx-equals-spacing.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertJsxEqualsSpacing: RuleConverter = (tslintRule) => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-react/jsx-key.ts renamed to src/converters/lintConfigs/rules/ruleConverters/jsx-key.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertJsxKey: RuleConverter = () => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-react/jsx-no-bind.ts renamed to src/converters/lintConfigs/rules/ruleConverters/jsx-no-bind.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertJsxNoBind: RuleConverter = () => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-react/jsx-no-lambda.ts renamed to src/converters/lintConfigs/rules/ruleConverters/jsx-no-lambda.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertJsxNoLambda: RuleConverter = () => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-react/jsx-self-close.ts renamed to src/converters/lintConfigs/rules/ruleConverters/jsx-self-close.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertJsxSelfClose: RuleConverter = () => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-react/jsx-space-before-trailing-slash.ts renamed to src/converters/lintConfigs/rules/ruleConverters/jsx-space-before-trailing-slash.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertJsxSpaceBeforeTrailingSlash: RuleConverter = () => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-react/jsx-wrap-multiline.ts renamed to src/converters/lintConfigs/rules/ruleConverters/jsx-wrap-multiline.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertJsxWrapMultiline: RuleConverter = () => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/eslint-plugin-sonarjs/max-switch-cases.ts renamed to src/converters/lintConfigs/rules/ruleConverters/max-switch-cases.ts

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

33
export const convertMaxSwitchCases: RuleConverter = (tslintRule) => {
44
return {

Diff for: src/converters/lintConfigs/rules/ruleConverters/ngrx-tslint-rules/action-hygiene.ts renamed to src/converters/lintConfigs/rules/ruleConverters/ngrx-action-hygiene.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

3-
export const convertActionHygiene: RuleConverter = () => {
3+
export const convertNgrxActionHygiene: RuleConverter = () => {
44
return {
55
rules: [
66
{

Diff for: src/converters/lintConfigs/rules/ruleConverters/ngrx-tslint-rules/avoid-dispatching-multiple-actions-sequentially.ts renamed to src/converters/lintConfigs/rules/ruleConverters/ngrx-avoid-dispatching-multiple-actions-sequentially.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

3-
export const convertAvoidDispatchingMultipleActionsSequentially: RuleConverter = () => {
3+
export const convertNgrxAvoidDispatchingMultipleActionsSequentially: RuleConverter = () => {
44
return {
55
rules: [
66
{

Diff for: src/converters/lintConfigs/rules/ruleConverters/ngrx-tslint-rules/effect-creator-and-decorator.ts renamed to src/converters/lintConfigs/rules/ruleConverters/ngrx-effect-creator-and-decorator.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

3-
export const convertEffectCreatorAndDecorator: RuleConverter = () => {
3+
export const convertNgrxEffectCreatorAndDecorator: RuleConverter = () => {
44
return {
55
rules: [
66
{

Diff for: src/converters/lintConfigs/rules/ruleConverters/ngrx-tslint-rules/no-dispatch-in-effects.ts renamed to src/converters/lintConfigs/rules/ruleConverters/ngrx-no-dispatch-in-effects.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

3-
export const convertNoDispatchInEffects: RuleConverter = () => {
3+
export const convertNgrxNoDispatchInEffects: RuleConverter = () => {
44
return {
55
rules: [
66
{
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
import { RuleConverter } from "../ruleConverter";
2+
3+
export const convertNgrxNoDuplicateActionTypes: RuleConverter = () => {
4+
return {
5+
rules: [],
6+
};
7+
};

Diff for: src/converters/lintConfigs/rules/ruleConverters/ngrx-tslint-rules/no-effect-decorator.ts renamed to src/converters/lintConfigs/rules/ruleConverters/ngrx-no-effect-decorator.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

3-
export const convertNoEffectDecorator: RuleConverter = () => {
3+
export const convertNgrxNoEffectDecorator: RuleConverter = () => {
44
return {
55
rules: [
66
{

Diff for: src/converters/lintConfigs/rules/ruleConverters/ngrx-tslint-rules/no-effects-in-providers.ts renamed to src/converters/lintConfigs/rules/ruleConverters/ngrx-no-effects-in-providers.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

3-
export const convertNoEffectsInProviders: RuleConverter = () => {
3+
export const convertNgrxNoEffectsInProviders: RuleConverter = () => {
44
return {
55
rules: [
66
{

Diff for: src/converters/lintConfigs/rules/ruleConverters/ngrx-tslint-rules/no-multiple-actions-in-effects.ts renamed to src/converters/lintConfigs/rules/ruleConverters/ngrx-no-multiple-actions-in-effects.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

3-
export const convertNoMultipleActionsInEffects: RuleConverter = () => {
3+
export const convertNgrxNoMultipleActionsInEffects: RuleConverter = () => {
44
return {
55
rules: [
66
{

Diff for: src/converters/lintConfigs/rules/ruleConverters/ngrx-tslint-rules/no-reducer-in-key-names.ts renamed to src/converters/lintConfigs/rules/ruleConverters/ngrx-no-reducer-in-key-names.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

3-
export const convertNoReducerInKeyNames: RuleConverter = () => {
3+
export const convertNgrxNoReducerInKeyNames: RuleConverter = () => {
44
return {
55
rules: [
66
{

Diff for: src/converters/lintConfigs/rules/ruleConverters/ngrx-tslint-rules/no-typed-store.ts renamed to src/converters/lintConfigs/rules/ruleConverters/ngrx-no-typed-store.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

3-
export const convertNoTypedStore: RuleConverter = () => {
3+
export const convertNgrxNoTypedStore: RuleConverter = () => {
44
return {
55
rules: [
66
{

Diff for: src/converters/lintConfigs/rules/ruleConverters/ngrx-tslint-rules/on-reducer-explicit-return-type.ts renamed to src/converters/lintConfigs/rules/ruleConverters/ngrx-on-reducer-explicit-return-type.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

3-
export const convertOnReducerExplicitReturnType: RuleConverter = () => {
3+
export const convertNgrxOnReducerExplicitReturnType: RuleConverter = () => {
44
return {
55
rules: [
66
{

Diff for: src/converters/lintConfigs/rules/ruleConverters/ngrx-tslint-rules/selector-for-select.ts renamed to src/converters/lintConfigs/rules/ruleConverters/ngrx-selector-for-select.ts

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
import { RuleConverter } from "../../ruleConverter";
1+
import { RuleConverter } from "../ruleConverter";
22

3-
export const convertSelectorForSelect: RuleConverter = () => {
3+
export const convertNgrxSelectorForSelect: RuleConverter = () => {
44
return {
55
rules: [
66
{

0 commit comments

Comments
 (0)