fix: accept negative timezone in isDateString (#564)

alencarandre · web-flow · commit 2012d7235a75 · 2020-03-26T15:52:23.000+01:00
Close #565
diff --git a/src/validation/Validator.ts b/src/validation/Validator.ts
@@ -402,7 +402,7 @@ export class Validator {
      * Checks if a given value is a ISOString date.
      */
     isDateString(value: unknown): boolean {
-        const regex = /^\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d:[0-5]\d(?:\.\d+)?(?:Z|\+[0-2]\d(?:\:[0-5]\d)?)?$/g;
+        const regex = /^\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d:[0-5]\d(?:\.\d+)?(?:Z|[\+\-][0-2]\d(?:\:[0-5]\d)?)?$/g;
         return this.isString(value) && regex.test(value);
     }
 
diff --git a/test/functional/validation-functions-and-decorators.spec.ts b/test/functional/validation-functions-and-decorators.spec.ts
@@ -729,6 +729,8 @@ describe("IsDateString", function() {
         "2018-01-04T08:15:30Z",
         "2018-01-04T08:15:30+04:00",
         "2018-01-04T08:15:30+04",
+        "2020-03-26T11:00:01-03:00",
+        "2020-03-26T11:00:01-03",
     ];
     const invalidValues = [
         true,

Original file line number	Diff line number	Diff line change
`@@ -402,7 +402,7 @@ export class Validator {`
`402`	`402`	`* Checks if a given value is a ISOString date.`
`403`	`403`	`*/`
`404`	`404`	`isDateString(value: unknown): boolean {`
`405`		`- const regex = /^\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d:[0-5]\d(?:\.\d+)?(?:Z\|\+[0-2]\d(?:\:[0-5]\d)?)?$/g;`
	`405`	`+ const regex = /^\d{4}-[01]\d-[0-3]\dT[0-2]\d:[0-5]\d:[0-5]\d(?:\.\d+)?(?:Z\|[\+\-][0-2]\d(?:\:[0-5]\d)?)?$/g;`
`406`	`406`	`return this.isString(value) && regex.test(value);`
`407`	`407`	`}`
`408`	`408`