Skip to content

Commit 908be83

Browse files
6by9ksacilotto
authored andcommitted
net: lan78xx: Allow for VLAN headers in timeout.
BugLink: http://bugs.launchpad.net/bugs/1784025 The frame abort timeout being set by lan78xx_set_rx_max_frame_length didn't account for any VLAN headers, resulting in very low throughput if used with tagged VLANs. Use VLAN_ETH_HLEN instead of ETH_HLEN to correct for this. See raspberrypi/linux#2458 Signed-off-by: Dave Stevenson <[email protected]> (cherry picked from commit 2259b7a64d71f27311a19fd7a5bed47413d75985) Signed-off-by: Paolo Pisati <[email protected]> Acked-by: Stefan Bader <[email protected]> Acked-by: Kleber Sacilotto de Souza <[email protected]> Signed-off-by: Kleber Sacilotto de Souza <[email protected]>
1 parent 0a41650 commit 908be83

File tree

1 file changed

+3
-2
lines changed

1 file changed

+3
-2
lines changed

drivers/net/usb/lan78xx.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1681,7 +1681,7 @@ static int lan78xx_change_mtu(struct net_device *netdev, int new_mtu)
16811681
if ((ll_mtu % dev->maxpacket) == 0)
16821682
return -EDOM;
16831683

1684-
ret = lan78xx_set_rx_max_frame_length(dev, new_mtu + ETH_HLEN);
1684+
ret = lan78xx_set_rx_max_frame_length(dev, new_mtu + VLAN_ETH_HLEN);
16851685

16861686
netdev->mtu = new_mtu;
16871687

@@ -1971,7 +1971,8 @@ static int lan78xx_reset(struct lan78xx_net *dev)
19711971
buf |= FCT_TX_CTL_EN_;
19721972
ret = lan78xx_write_reg(dev, FCT_TX_CTL, buf);
19731973

1974-
ret = lan78xx_set_rx_max_frame_length(dev, dev->net->mtu + ETH_HLEN);
1974+
ret = lan78xx_set_rx_max_frame_length(dev,
1975+
dev->net->mtu + VLAN_ETH_HLEN);
19751976

19761977
ret = lan78xx_read_reg(dev, MAC_RX, &buf);
19771978
buf |= MAC_RX_RXEN_;

0 commit comments

Comments
 (0)