Skip to content

Commit 28ee475

Browse files
committed
Remove adding resources from README
1 parent 8f5e7f0 commit 28ee475

File tree

2 files changed

+4
-34
lines changed

2 files changed

+4
-34
lines changed

ReleaseTooling/Sources/ZipBuilder/ZipBuilder.swift

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -43,14 +43,6 @@ struct Constants {
4343
init() { fatalError() }
4444
}
4545

46-
/// The text added to the README for a product if it contains Resources. The empty line at the end
47-
/// is intentional.
48-
static let resourcesRequiredText = """
49-
You'll also need to add the resources in the Resources
50-
directory into your target's main bundle.
51-
52-
"""
53-
5446
// Make the struct un-initializable.
5547
@available(*, unavailable)
5648
init() { fatalError() }
@@ -655,23 +647,6 @@ struct ZipBuilder {
655647

656648
result += "\n" // Necessary for Resource message to print properly in markdown.
657649

658-
// Check if there is a Resources directory, and if so, add the disclaimer to the dependency
659-
// string.
660-
do {
661-
let fileManager = FileManager.default
662-
let resourceDirs = try fileManager.recursivelySearch(for: .directories(name: "Resources"),
663-
in: dir)
664-
if !resourceDirs.isEmpty {
665-
result += Constants.resourcesRequiredText
666-
result += "\n" // Separate from next pod in listing for text version.
667-
}
668-
} catch {
669-
fatalError("""
670-
Tried to find Resources directory for \(podName) in order to build the README, but an error
671-
occurred: \(error).
672-
""")
673-
}
674-
675650
return result
676651
}
677652

ReleaseTooling/Template/README.md

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -36,25 +36,20 @@ To integrate a Firebase SDK with your app:
3636
[static frameworks](https://www.raywenderlich.com/65964/create-a-framework-for-ios)
3737
which cannot be embedded into your application's bundle.*
3838

39-
7. If the SDK has resources, go into the Resources folders, which will be in
40-
the SDK folder. Drag all of those resources into the Project Navigator, just
41-
like the frameworks, again making sure that the target you want to add these
42-
resources to has a checkmark next to it, and that you've selected "Copy items
43-
if needed".
44-
8. Add the -ObjC flag to "Other Linker Settings":
39+
7. Add the -ObjC flag to "Other Linker Settings":
4540
a. In your project settings, open the Settings panel for your target
4641
b. Go to the Build Settings tab and find the "Other Linker Flags" setting
4742
in the Linking section.
4843
c. Double-click the setting, click the '+' button, and add "-ObjC" (without
4944
quotes)
50-
9. Drag the `Firebase.h` header in this directory into your project. This will
45+
8. Drag the `Firebase.h` header in this directory into your project. This will
5146
allow you to `#import "Firebase.h"` and start using any Firebase SDK that you
5247
have.
53-
10. If you're using Swift or want to use modules from Objective C, drag
48+
9. If you're using Swift or want to use modules from Objective C, drag
5449
`module.modulemap` into your project and update the
5550
"User Header Search Paths" in your project's Build Settings to include the
5651
directory that contains the added module map.
57-
11. You're done! Compile your target and start using Firebase.
52+
10. You're done! Compile your target and start using Firebase.
5853

5954
If you want to add another SDK, repeat the steps above with the frameworks for
6055
the new SDK. You only need to add each framework once, so if you've already

0 commit comments

Comments
 (0)