Skip to content

"currentValue" is not current in Umbraco.BlockList element properties #18872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PeterKvayt opened this issue Mar 30, 2025 · 4 comments · May be fixed by #18976
Open

"currentValue" is not current in Umbraco.BlockList element properties #18872

PeterKvayt opened this issue Mar 30, 2025 · 4 comments · May be fixed by #18976

Comments

@PeterKvayt
Copy link
Contributor

Which Umbraco version are you using?

15.3.0

Bug summary

I encountered the following issue:

I created a document type called "Root Container," which includes a property named "Block List Property" with the data type "Umbraco.BlockList." This data type contains an element-type document called "Element," which has a property named "Text."

Next, I created a node of type "Root Container" and added a new element node to the "Block List Property." I then set the "Text" property within the element node to "Some text."

To investigate further, I placed a breakpoint at the beginning of the FromEditor method in Umbraco.Cms.Core.PropertyEditors.DataValueEditor and observed how currentValue changed. However, I found that currentValue always remained the same as editorValue.Value.

Interestingly, when the property editor is used outside of a Block List, it functions correctly. While this discrepancy is not a major issue for textboxes (as they do not depend on currentValue), it can affect other property editors that do.

This behavior is caused by code (Umbraco.Cms.Core.PropertyEditors.BlockValuePropertyValueEditorBase):

Image

Here, as you can see, we set the same value as current.

The behavior should remain consistent regardless of whether the property is inside a "Umbraco.BlockList" element or not.

Specifics

No response

Steps to reproduce

Watch the video

2025-03-30.20-53-35.mp4

Expected result / actual result

Actual: currentValue contains editorValue.Value when it is in element.
Expected: currentValue should contain the actual current value.

Copy link

Hi there @PeterKvayt!

Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better.

We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.

  • We'll assess whether this issue relates to something that has already been fixed in a later version of the release that it has been raised for.
  • If it's a bug, is it related to a release that we are actively supporting or is it related to a release that's in the end-of-life or security-only phase?
  • We'll replicate the issue to ensure that the problem is as described.
  • We'll decide whether the behavior is an issue or if the behavior is intended.

We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

Copy link

github-actions bot commented Apr 7, 2025

Hi @PeterKvayt,

We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know.

For more information about issues and states, have a look at this blog post.

Thanks muchly, from your friendly Umbraco GitHub bot :-)

@PeterKvayt
Copy link
Contributor Author

I am going to fix it

PeterKvayt added a commit to PeterKvayt/Umbraco-CMS that referenced this issue Apr 8, 2025
@PeterKvayt
Copy link
Contributor Author

@nielslyngsoe
PR is ready)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants