-
Notifications
You must be signed in to change notification settings - Fork 2.8k
"currentValue" is not current in Umbraco.BlockList element properties #18872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Hi there @PeterKvayt! Firstly, a big thank you for raising this issue. Every piece of feedback we receive helps us to make Umbraco better. We really appreciate your patience while we wait for our team to have a look at this but we wanted to let you know that we see this and share with you the plan for what comes next.
We wish we could work with everyone directly and assess your issue immediately but we're in the fortunate position of having lots of contributions to work with and only a few humans who are able to do it. We are making progress though and in the meantime, we will keep you in the loop and let you know when we have any questions. Thanks, from your friendly Umbraco GitHub bot 🤖 🙂 |
Hi @PeterKvayt, We're writing to let you know that we would love some help with this issue. We feel that this issue is ideal to flag for a community member to work on it. Once flagged here, folk looking for issues to work on will know to look at yours. Of course, please feel free work on this yourself ;-). If there are any changes to this status, we'll be sure to let you know. For more information about issues and states, have a look at this blog post. Thanks muchly, from your friendly Umbraco GitHub bot :-) |
I am going to fix it |
@nielslyngsoe |
Which Umbraco version are you using?
15.3.0
Bug summary
I encountered the following issue:
I created a document type called "Root Container," which includes a property named "Block List Property" with the data type "Umbraco.BlockList." This data type contains an element-type document called "Element," which has a property named "Text."
Next, I created a node of type "Root Container" and added a new element node to the "Block List Property." I then set the "Text" property within the element node to "Some text."
To investigate further, I placed a breakpoint at the beginning of the
FromEditor
method inUmbraco.Cms.Core.PropertyEditors.DataValueEditor
and observed howcurrentValue
changed. However, I found thatcurrentValue
always remained the same aseditorValue.Value
.Interestingly, when the property editor is used outside of a Block List, it functions correctly. While this discrepancy is not a major issue for textboxes (as they do not depend on currentValue), it can affect other property editors that do.
This behavior is caused by code (
Umbraco.Cms.Core.PropertyEditors.BlockValuePropertyValueEditorBase
):Here, as you can see, we set the same value as current.
The behavior should remain consistent regardless of whether the property is inside a "Umbraco.BlockList" element or not.
Specifics
No response
Steps to reproduce
Watch the video
2025-03-30.20-53-35.mp4
Expected result / actual result
Actual:
currentValue
containseditorValue.Value
when it is in element.Expected:
currentValue
should contain the actual current value.The text was updated successfully, but these errors were encountered: