Maintenance help

[wolfv]

Dear @uniphil we rely on this crate in rattler-build - would you accept help in maintaining the parser? We have users that run into issues parsing existing patch files and would love to help review existing PRs, merge and release things.

[vrmiguel]

It'd be great to have a more well-maintained version of this crate. Looking at the PRs and issues, there seems to be a reasonable amount of interested developers

I've forked this crate into https://github.com/gitpatch-rs/gitpatch and merged #26 from @sourcefrog and #28 from @gagath into it, and would gladly accept more maintainers

Tagging other possibly interested folks: @NeuralModder, @traversaro

Edit: added a fix for #24 in gitpatch-rs/gitpatch@79b35fc

[sourcefrog]

Thanks for stepping up on this and taking my patch.

#26 I think just ignores birthday file changes, which is ok for me but perhaps other people would want an API change that exposes the information. Still, it's probably a step forward as it is.

[psandana]

@vrmiguel thanks for the effort! Count me in if you need help with it.

[psandana]

@uniphil I will proceed to create a RUSTSEC advisory PR of this crate being unmaintained. There is tooling that depends on this crate, which is great, but because of that we urge to fix the issues. Hope you understand.

[psandana]

PR in RUSTSEC advisory created: rustsec/advisory-db#2280

[uniphil]

hey all, really sorry for being unreachable. i'm catching up a bit now.

to start, i'll grant write access to @wolfv , @vrmiguel , and @psandana in this repo.

next week i'll make some time to review the patches and changes and if everything seems fine i'll either directly release to crates, or move toward sharing release permissions.

if for any reason things aren't looking like they're moving in a productive direction, i'll put a clear notice up to redirect people to whichever forks are being maintained.

does that work?

again, sorry for letting this get this far.

[wolfv]

Hey @uniphil - I can confirm that I have permissions on the repository now, thanks! I think ideally we setup release-plz so that anyone with merge rights can release a new version to cargo and we get proper semver.

https://github.com/release-plz/release-plz

[uniphil]

i just realized part of my last message probably read as kind of the opposite of what i meant it to: if there is interest in sharing maintenance work here, i'd love to review how that goes after some movement on any of the open issues/prs, now that more people have write on the repo. sorry if you were waiting on me here!

i hadn't heard of release-plz before, it looks cool! i'd like to do a couple releases with final review before automating that, but i'm very into it as where this ends up.