Skip to content

Commit 15c1cad

Browse files
committed
avoid calling checkbox checked setting save code at startup (#54)
1 parent 607b176 commit 15c1cad

File tree

1 file changed

+40
-11
lines changed

1 file changed

+40
-11
lines changed

Diff for: UnityLauncherPro/MainWindow.xaml.cs

+40-11
Original file line numberDiff line numberDiff line change
@@ -1526,12 +1526,16 @@ private void BtnOpenWebsite_Click(object sender, RoutedEventArgs e)
15261526

15271527
private void ChkMinimizeToTaskbar_CheckedChanged(object sender, RoutedEventArgs e)
15281528
{
1529+
if (this.IsActive == false) return; // dont run code on window init
1530+
15291531
Settings.Default.minimizeToTaskbar = (bool)chkMinimizeToTaskbar.IsChecked;
15301532
Settings.Default.Save();
15311533
}
15321534

15331535
private void ChkRegisterExplorerMenu_CheckedChanged(object sender, RoutedEventArgs e)
15341536
{
1537+
if (this.IsActive == false) return; // dont run code on window init
1538+
15351539
if ((bool)chkRegisterExplorerMenu.IsChecked)
15361540
{
15371541
Tools.AddContextMenuRegistry(contextRegRoot);
@@ -1548,6 +1552,7 @@ private void ChkRegisterExplorerMenu_CheckedChanged(object sender, RoutedEventAr
15481552
private void ChkShowLauncherArgumentsColumn_CheckedChanged(object sender, RoutedEventArgs e)
15491553
{
15501554
if (this.IsActive == false) return; // dont run code on window init
1555+
15511556
Settings.Default.showArgumentsColumn = (bool)chkShowLauncherArgumentsColumn.IsChecked;
15521557
Settings.Default.Save();
15531558
gridRecent.Columns[4].Visibility = (bool)chkShowLauncherArgumentsColumn.IsChecked ? Visibility.Visible : Visibility.Collapsed;
@@ -1557,6 +1562,7 @@ private void ChkShowLauncherArgumentsColumn_CheckedChanged(object sender, Routed
15571562
private void ChkShowGitBranchColumn_CheckedChanged(object sender, RoutedEventArgs e)
15581563
{
15591564
if (this.IsActive == false) return; // dont run code on window init
1565+
15601566
Settings.Default.showGitBranchColumn = (bool)chkShowGitBranchColumn.IsChecked;
15611567
Settings.Default.Save();
15621568
gridRecent.Columns[5].Visibility = (bool)chkShowGitBranchColumn.IsChecked ? Visibility.Visible : Visibility.Collapsed;
@@ -1565,12 +1571,16 @@ private void ChkShowGitBranchColumn_CheckedChanged(object sender, RoutedEventArg
15651571

15661572
private void ChkQuitAfterOpen_CheckedChanged(object sender, RoutedEventArgs e)
15671573
{
1574+
if (this.IsActive == false) return; // dont run code on window init
1575+
15681576
Settings.Default.closeAfterProject = (bool)chkQuitAfterOpen.IsChecked;
15691577
Settings.Default.Save();
15701578
}
15711579

15721580
private void ChkQuitAfterCommandline_CheckedChanged(object sender, RoutedEventArgs e)
15731581
{
1582+
if (this.IsActive == false) return; // dont run code on window init
1583+
15741584
Settings.Default.closeAfterExplorer = (bool)chkQuitAfterCommandline.IsChecked;
15751585
Settings.Default.Save();
15761586
}
@@ -1793,12 +1803,16 @@ private void DataGridUpdates_PreviewMouseDoubleClick(object sender, MouseButtonE
17931803

17941804
private void ChkShowMissingFolderProjects_CheckedChanged(object sender, RoutedEventArgs e)
17951805
{
1806+
if (this.IsActive == false) return; // dont run code on window init
1807+
17961808
Settings.Default.showProjectsMissingFolder = (bool)chkShowMissingFolderProjects.IsChecked;
17971809
Settings.Default.Save();
17981810
}
17991811

18001812
private void ChkAllowSingleInstanceOnly_CheckedChanged(object sender, RoutedEventArgs e)
18011813
{
1814+
if (this.IsActive == false) return; // dont run code on window init
1815+
18021816
Settings.Default.AllowSingleInstanceOnly = (bool)chkAllowSingleInstanceOnly.IsChecked;
18031817
Settings.Default.Save();
18041818
}
@@ -1966,17 +1980,21 @@ void CreateNewEmptyProject(string targetFolder = null)
19661980

19671981
private void ChkAskNameForQuickProject_Checked(object sender, RoutedEventArgs e)
19681982
{
1969-
Properties.Settings.Default.askNameForQuickProject = (bool)chkAskNameForQuickProject.IsChecked;
1970-
Properties.Settings.Default.Save();
1983+
if (this.IsActive == false) return; // dont run code on window init
1984+
1985+
Settings.Default.askNameForQuickProject = (bool)chkAskNameForQuickProject.IsChecked;
1986+
Settings.Default.Save();
19711987
}
19721988

19731989
bool isInitializing = true; // used to avoid doing things while still starting up
19741990
private void ChkStreamerMode_Checked(object sender, RoutedEventArgs e)
19751991
{
1992+
if (this.IsActive == false) return; // dont run code on window init
1993+
19761994
var isChecked = (bool)((CheckBox)sender).IsChecked;
19771995

1978-
Properties.Settings.Default.streamerMode = isChecked;
1979-
Properties.Settings.Default.Save();
1996+
Settings.Default.streamerMode = isChecked;
1997+
Settings.Default.Save();
19801998

19811999
// Create cellstyle and assign if streamermode is enabled
19822000
Style cellStyle = new Style(typeof(DataGridCell));
@@ -1999,6 +2017,8 @@ private void ChkStreamerMode_Checked(object sender, RoutedEventArgs e)
19992017

20002018
private void ChkShowPlatform_Checked(object sender, RoutedEventArgs e)
20012019
{
2020+
if (this.IsActive == false) return; // dont run code on window init
2021+
20022022
var isChecked = (bool)((CheckBox)sender).IsChecked;
20032023

20042024
Settings.Default.showTargetPlatform = isChecked;
@@ -2072,6 +2092,8 @@ public void MoveRecentGridItem(int to)
20722092

20732093
private void ChkEnableProjectRename_Checked(object sender, RoutedEventArgs e)
20742094
{
2095+
if (this.IsActive == false) return; // dont run code on window init
2096+
20752097
Properties.Settings.Default.enableProjectRename = (bool)chkEnableProjectRename.IsChecked;
20762098
Properties.Settings.Default.Save();
20772099
}
@@ -2565,8 +2587,8 @@ private void ChkUseCustomTheme_Checked(object sender, RoutedEventArgs e)
25652587
if (this.IsActive == false) return; // dont run code on window init
25662588

25672589
var isChecked = (bool)((CheckBox)sender).IsChecked;
2568-
Properties.Settings.Default.useCustomTheme = isChecked;
2569-
Properties.Settings.Default.Save();
2590+
Settings.Default.useCustomTheme = isChecked;
2591+
Settings.Default.Save();
25702592

25712593
btnReloadTheme.IsEnabled = isChecked;
25722594

@@ -2616,9 +2638,11 @@ private void BtnExploreFolder_Click(object sender, RoutedEventArgs e)
26162638

26172639
private void ChkEnablePlatformSelection_Checked(object sender, RoutedEventArgs e)
26182640
{
2641+
if (this.IsActive == false) return; // dont run code on window init
2642+
26192643
var isChecked = (bool)((CheckBox)sender).IsChecked;
2620-
Properties.Settings.Default.enablePlatformSelection = isChecked;
2621-
Properties.Settings.Default.Save();
2644+
Settings.Default.enablePlatformSelection = isChecked;
2645+
Settings.Default.Save();
26222646
chkEnablePlatformSelection.IsChecked = isChecked;
26232647
}
26242648

@@ -2642,9 +2666,10 @@ private void CmbPlatformSelection_DropDownClosed(object sender, EventArgs e)
26422666
private void ChkRunAutomatically_Checked(object sender, RoutedEventArgs e)
26432667
{
26442668
if (this.IsActive == false) return; // dont run code on window init
2669+
26452670
var isChecked = (bool)((CheckBox)sender).IsChecked;
2646-
Properties.Settings.Default.runAutomatically = isChecked;
2647-
Properties.Settings.Default.Save();
2671+
Settings.Default.runAutomatically = isChecked;
2672+
Settings.Default.Save();
26482673
chkRunAutomatically.IsChecked = isChecked;
26492674
// set or unset registry, NOTE should not do this on debug build.. (otherwise 2 builds try to run?)
26502675
Tools.SetStartupRegistry(isChecked);
@@ -2741,6 +2766,7 @@ bool ValidateIntRange(TextBox textBox, int min, int max)
27412766
private void ChkHumanFriendlyDateTime_Checked(object sender, RoutedEventArgs e)
27422767
{
27432768
if (this.IsActive == false) return; // dont run code on window init
2769+
27442770
var isChecked = (bool)((CheckBox)sender).IsChecked;
27452771

27462772
// cannot have both date formats
@@ -2796,6 +2822,7 @@ void OpenSelectedBuildReportFile()
27962822
private void ChkRunAutomaticallyMinimized_Checked(object sender, RoutedEventArgs e)
27972823
{
27982824
if (this.IsActive == false) return; // dont run code on window init
2825+
27992826
var isChecked = (bool)((CheckBox)sender).IsChecked;
28002827

28012828
Settings.Default.runAutomaticallyMinimized = isChecked;
@@ -2974,6 +3001,7 @@ private void Window_SourceInitialized(object sender, EventArgs e)
29743001
private void ChkSearchProjectPath_Checked(object sender, RoutedEventArgs e)
29753002
{
29763003
if (this.IsActive == false) return; // dont run code on window init
3004+
29773005
var isChecked = (bool)((CheckBox)sender).IsChecked;
29783006

29793007
searchProjectPathAlso = isChecked;
@@ -3011,6 +3039,7 @@ private void MenuBatchBuildIOS_Click(object sender, RoutedEventArgs e)
30113039
private void ChkCheckPlasticBranch_Checked(object sender, RoutedEventArgs e)
30123040
{
30133041
if (this.IsActive == false) return; // dont run code on window init
3042+
30143043
Settings.Default.checkPlasticBranch = (bool)chkCheckPlasticBranch.IsChecked;
30153044
Settings.Default.Save();
30163045
RefreshRecentProjects();
@@ -3315,7 +3344,7 @@ private void btnPatchHubConfig_Click(object sender, RoutedEventArgs e)
33153344
// replace the manual:true with manual:false using regex
33163345
json = json.Replace("\"manual\":true", "\"manual\":false");
33173346

3318-
Console.WriteLine(json);
3347+
//Console.WriteLine(json);
33193348

33203349
// write the config file
33213350
File.WriteAllText(configFile, json);

0 commit comments

Comments
 (0)