Skip to content

Commit a9f9660

Browse files
authored
Merge pull request #18 from utPLSQL/fix/coverage_fix
Fix/coverage fix
2 parents 552b2ea + 77d2013 commit a9f9660

27 files changed

+60
-43
lines changed

Diff for: .azure_templates/t-extend-database-build.yml

+9-9
Original file line numberDiff line numberDiff line change
@@ -54,15 +54,15 @@ steps:
5454
addBaseImageData: false
5555

5656
- ${{ each trg_db in parameters.targetDatabases }}:
57-
- bash: |
58-
# download Oracle Database docker image from private repo and start the DB
59-
time docker pull ${{ parameters.dockerRepo }}:${{ trg_db.oracleVersion }}
60-
# start the docker container (DB)
61-
time docker run -d --name ${{ trg_db.oracleVersion }} ${{ trg_db.dockerOptions }} -p 1521:${{ trg_db.dockerPortMap }} ${{ parameters.dockerRepo }}:${{ trg_db.oracleVersion }}
62-
# Wait for DB startup
63-
time docker logs -f ${{ trg_db.oracleVersion }} | grep -m 1 "DATABASE IS READY TO USE!" --line-buffered
64-
displayName: 'Start Oracle DB Docker container: ${{ trg_db.oracleVersion }}'
65-
57+
- template: t-task-extend-create-docker-database.yml
58+
parameters:
59+
containerRegistry: ${{ parameters.containerRegistry }}
60+
dockerRepo: ${{ parameters.dockerRepo }}
61+
dbname: ${{ trg_db.oracleVersion }}
62+
oracleVersion: ${{ trg_db.oracleVersion }}
63+
dockerOptions: ${{ trg_db.dockerOptions }}
64+
dockerPortMap: ${{ trg_db.dockerPortMap }}
65+
6666
- ${{ each script in trg_db.scripts }}:
6767
- template: t-task-extend-sqlcl.yml
6868
parameters:

Diff for: .azure_templates/t-task-extend-create-docker-database.yml

+1
Original file line numberDiff line numberDiff line change
@@ -28,6 +28,7 @@ steps:
2828
${{ parameters.dockerOptions }} \
2929
-p 1521:${{ parameters.dockerPortMap }} \
3030
--network utplsql_network \
31+
-e "ORACLE_PASSWORD=oracle" \
3132
${{ parameters.dockerRepo }}:${{ parameters.oracleVersion }}
3233
# Wait for DB startup
3334
time docker logs -f ${{ parameters.dbname }} | grep -m 1 "DATABASE IS READY TO USE!" --line-buffered

Diff for: .azure_templates/t-task-extend-flyway.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ steps:
3131
-v ${{ parameters.config_dir }}:/flyway/conf \
3232
-v ${{ parameters.driver_dir }}:/flyway/drivers \
3333
--network utplsql_network \
34-
flyway/flyway migrate \
34+
flyway/flyway:8.5 migrate \
3535
-url=jdbc:oracle:thin:@${{ parameters.jdbcConnectionString }} \
3636
-configFiles="/flyway/conf/${{ parameters.config_file }}" \
3737
-user="${{ parameters.user }}" \

Diff for: .azure_templates/t-task-extend-sqlcl-liquibase.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ steps:
1818
#Issue with 19.3 docker images. fixed in 21
1919
sql ${{ parameters.user }}/${{ parameters.password }}@//${{ parameters.connectionString }}?oracle.net.disableOob=true<<EOF
2020
lb version
21-
lb update -debug -changelog ${{ parameters.masterchangelogfile }}
21+
lb update -debug -changelog-file ${{ parameters.masterchangelogfile }}
2222
exit;
2323
EOF
2424
exit $?

Diff for: .azure_templates/t-task-extend-utplsqlcli.yml

+8
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,15 @@ steps:
1919
cd ${{ parameters.work_dir }}
2020
utplsql run ${{ parameters.test_user }}/${{ parameters.test_pwd }}@//${{ parameters.connectionString }}?oracle.net.disableOob=true \
2121
-source_path=${{ parameters.source_path }} \
22+
-regex_expression="(\w+)/(\w+)/(R__)(\w+)\.(\w+)\.(\w+)$" \
23+
-owner_subexpression=4 \
24+
-name_subexpression=5 \
25+
-type_subexpression=6 \
2226
-test_path=${{ parameters.test_path }} \
27+
-regex_expression="(\w+)/(\w+)/(\w+)\.(\w+)\.(\w+)$" \
28+
-owner_subexpression=1 \
29+
-type_subexpression=5 \
30+
-name_subexpression=4 \
2331
-f=ut_documentation_reporter -c \
2432
-f=ut_coverage_sonar_reporter -o=coverage.xml \
2533
-f=ut_sonar_test_reporter -o=test_results.xml \

Diff for: .github/workflows/build.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ jobs:
2020
runs-on: ubuntu-latest
2121
strategy:
2222
matrix:
23-
utplsql-version: [develop, v3.1.8, v3.1.11]
23+
utplsql-version: [develop, v3.1.13]
2424

2525
services:
2626
oracle:
@@ -45,7 +45,7 @@ jobs:
4545
run: echo Installing ${UTPLSQL_VERSION} && sh ${{ github.workspace }}/scripts/1_install_utplsql.sh
4646

4747
- name: Install utPLSQL-cli
48-
run: curl -Lk -o utPLSQL-cli.zip "https://github.com/utPLSQL/utPLSQL-cli/releases/download/v3.1.8/utPLSQL-cli.zip" && unzip utPLSQL-cli.zip && chmod -R u+x utPLSQL-cli
48+
run: curl -Lk -o utPLSQL-cli.zip "https://github.com/utPLSQL/utPLSQL-cli/releases/download/3.1.9/utPLSQL-cli.zip" && unzip utPLSQL-cli.zip && chmod -R u+x utPLSQL-cli
4949

5050
- name: Install demo project
5151
run: sh ${{ github.workspace }}/scripts/2_install_demo_project.sh

Diff for: scripts/1_install_utplsql.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
git clone --depth=1 --branch=${UTPLSQL_VERSION} https://github.com/utPLSQL/utPLSQL.git utPLSQL
22
chmod -R go+w $(pwd)/utPLSQL/source
33
docker run --rm -v $(pwd)/utPLSQL:/utPLSQL -w /utPLSQL/source --network host \
4-
--entrypoint sqlplus gvenzl/oracle-xe:18-slim sys/oracle@//127.0.0.1:1521/XE as sysdba @install_headless.sql UT3 UT3 users
4+
--entrypoint sqlplus gvenzl/oracle-xe:21-slim sys/oracle@//127.0.0.1:1521/XE as sysdba @install_headless.sql UT3 UT3 users

Diff for: scripts/2_install_demo_project.sh

+2-2
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
docker run --rm -v $(pwd):/work -w /work/ --network host \
2-
--entrypoint sqlplus gvenzl/oracle-xe:18-slim \
2+
--entrypoint sqlplus gvenzl/oracle-xe:21-slim \
33
sys/oracle@//127.0.0.1:1521/XE as sysdba @source/create_user.sql
44

55
docker run --rm -v $(pwd):/work -w /work/ --network host \
6-
--entrypoint sqlplus gvenzl/oracle-xe:18-slim \
6+
--entrypoint sqlplus gvenzl/oracle-xe:21-slim \
77
ut3_demo/ut3_demo@//127.0.0.1:1521/XE @source/install.sql

Diff for: scripts/3_install_tests.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
docker run --rm -v $(pwd):/work -w /work/ --network host \
2-
--entrypoint sqlplus gvenzl/oracle-xe:18-slim \
2+
--entrypoint sqlplus gvenzl/oracle-xe:21-slim \
33
ut3_demo/ut3_demo@//127.0.0.1:1521/XE @test/install.sql

Diff for: scripts/4_run_tests.sh

+14-6
Original file line numberDiff line numberDiff line change
@@ -2,10 +2,18 @@
22

33
set -ev
44

5-
utPLSQL-cli/bin/utplsql run ut3_demo/ut3_demo@//127.0.0.1:1521/XE \
6-
-source_path=source -test_path=test \
5+
utPLSQL-cli/bin/utplsql run ut3_demo/ut3_demo@//127.0.0.1:1521/XE?oracle.net.disableOob=true \
6+
-source_path=source -regex_expression="(\w+)/(\w+)/(R__)(\w+)\.(\w+)\.(\w+)$" \
7+
-owner_subexpression=4 \
8+
-name_subexpression=5 \
9+
-type_subexpression=6 \
10+
-test_path=test -regex_expression="(\w+)/(\w+)/(\w+)\.(\w+)\.(\w+)$" \
11+
-owner_subexpression=1 \
12+
-type_subexpression=5 \
13+
-name_subexpression=4 \
714
-f=ut_documentation_reporter -c \
8-
-f=ut_coverage_sonar_reporter -o=coverage.xml \
9-
-f=ut_sonar_test_reporter -o=test_results.xml \
10-
--failure-exit-code=0
11-
15+
-f=ut_coverage_sonar_reporter -o=coverage.xml \
16+
-f=ut_sonar_test_reporter -o=test_results.xml \
17+
-f=ut_coverage_cobertura_reporter -o=cobertura.xml \
18+
-f=ut_junit_reporter -o=junit_test_results.xml \
19+
--failure-exit-code=0

Diff for: source/award_bonus/award_bonus.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<changeSet author="utplsql" id="02_award_bonus_prc" runOnChange="true">
1717
<sqlFile dbms="oracle"
1818
endDelimiter=";"
19-
path="R__award_bonus.prc"
19+
path="R__ut3_demo.award_bonus.prc"
2020
relativeToChangelogFile="true"
2121
splitStatements="false"
2222
stripComments="false"/>

Diff for: source/between_string/between_string.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<changeSet author="utplsql" id="05_between_string" runOnChange="true">
99
<sqlFile dbms="oracle"
1010
endDelimiter=";"
11-
path="R__betwnstr.fnc"
11+
path="R__ut3_demo.betwnstr.fnc"
1212
relativeToChangelogFile="true"
1313
splitStatements="false"
1414
stripComments="false"/>

Diff for: source/install.sql

+3-3
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
@source/award_bonus/V1.01__employees_test.sql
2-
@source/award_bonus/R__award_bonus.prc
3-
@source/between_string/R__betwnstr.fnc
2+
@source/award_bonus/R__ut3_demo.award_bonus.prc
3+
@source/between_string/R__ut3_demo.betwnstr.fnc
44
@source/remove_rooms_by_name/V1.02__rooms.sql
5-
@source/remove_rooms_by_name/R__remove_rooms_by_name.prc
5+
@source/remove_rooms_by_name/R__ut3_demo.remove_rooms_by_name.prc
66
exit

Diff for: source/remove_rooms_by_name/remove_rooms_by_name.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616
<changeSet author="utplsql" id="04_remove_rooms_by_name_prc" runOnChange="true">
1717
<sqlFile dbms="oracle"
1818
endDelimiter=";"
19-
path="R__remove_rooms_by_name.prc"
19+
path="R__ut3_demo.remove_rooms_by_name.prc"
2020
relativeToChangelogFile="true"
2121
splitStatements="false"
2222
stripComments="false"/>

Diff for: test/install.sql

+6-6
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
@test/award_bonus/test_award_bonus.pks
2-
@test/award_bonus/test_award_bonus.pkb
1+
@test/award_bonus/ut3_demo.test_award_bonus.pks
2+
@test/award_bonus/ut3_demo.test_award_bonus.pkb
33
show errors
4-
@test/between_string/test_betwnstr.pks
5-
@test/between_string/test_betwnstr.pkb
4+
@test/between_string/ut3_demo.test_betwnstr.pks
5+
@test/between_string/ut3_demo.test_betwnstr.pkb
66
show errors
7-
@test/remove_rooms_by_name/test_remove_rooms_by_name.pks
8-
@test/remove_rooms_by_name/test_remove_rooms_by_name.pkb
7+
@test/remove_rooms_by_name/ut3_demo.test_remove_rooms_by_name.pks
8+
@test/remove_rooms_by_name/ut3_demo.test_remove_rooms_by_name.pkb
99
show errors
1010
exit

Diff for: utlplsql-demo-project.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ variables:
99
SQLCL_DIR: $(Build.BinariesDirectory)/sqlcl
1010
UTPLSQL_DIR: $(Build.BinariesDirectory)/utPLSQL
1111
UTPLSQL_CLI_DIR: $(Build.BinariesDirectory)/utPLSQL-cli
12-
UTPLSQL_CLI_VERSION: 'v3.1.8'
13-
UTPLSQL_VERSION: 'v3.1.11'
12+
UTPLSQL_CLI_VERSION: '3.1.9'
13+
UTPLSQL_VERSION: 'v3.1.13'
1414
DOCKHER_HUB_REPO: 'gvenzl/oracle-xe'
1515
DB_USER: ut3_demo
1616
DB_PASS: ut3_demo
@@ -20,8 +20,8 @@ jobs:
2020
displayName: Build utPLSQL-demo-project
2121
strategy:
2222
matrix:
23-
Oracle19_2:
24-
ORACLE_VERSION: "19c-se2-small"
23+
Oracle21_slim:
24+
ORACLE_VERSION: "21-slim"
2525
maxParallel: 2
2626

2727
steps:

Diff for: utplsql-cicd-flyway-demo.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ variables:
1414
- name : UTPLSQL_CLI_DIR
1515
value: $(Build.BinariesDirectory)/utPLSQL-cli
1616
- name : UTPLSQL_CLI_VERSION
17-
value: 'v3.1.8'
17+
value: '3.1.9'
1818
- name : UTPLSQL_VERSION
19-
value: 'v3.1.11'
19+
value: 'v3.1.13'
2020
- name : DB_USER
2121
value: ut3_demo
2222
- name : DB_PASS

Diff for: utplsql-cicd-liquibase-demo.yml

+2-2
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,9 @@ variables:
1414
- name : UTPLSQL_CLI_DIR
1515
value: $(Build.BinariesDirectory)/utPLSQL-cli
1616
- name : UTPLSQL_CLI_VERSION
17-
value: 'v3.1.8'
17+
value: '3.1.9'
1818
- name : UTPLSQL_VERSION
19-
value: 'v3.1.11'
19+
value: 'v3.1.13'
2020
- name : DB_USER
2121
value: ut3_demo
2222
- name : DB_PASS

0 commit comments

Comments
 (0)