refactor: do not return an error from Validate (#228)

## Issue
N/A

## Description
Refactor to align with behaviour in other plugins.

Signed-off-by: Tyler Gillson <[email protected]>

Author: TylerGillson

internal/controller/azurevalidator_controller.go

@@ -104,10 +104,7 @@ func (r *AzureValidatorReconciler) Reconcile(ctx context.Context, req ctrl.Reque
 	vr.Spec.ExpectedResults = validator.Spec.ResultCount()
 
 	// Validate the rules
-	resp, err := validate.Validate(ctx, validator.Spec, r.Log)
-	if err != nil {
-		return ctrl.Result{}, err
-	}
+	resp := validate.Validate(ctx, validator.Spec, r.Log)
 
 	// Patch the ValidationResult with the latest ValidationRuleResults
 	if err := vres.SafeUpdate(ctx, p, vr, resp, r.Log); err != nil {

pkg/validate/validate.go

@@ -8,23 +8,28 @@ import (
 	"time"
 
 	"github.com/go-logr/logr"
+	vapi "github.com/validator-labs/validator/api/v1alpha1"
+	vconstants "github.com/validator-labs/validator/pkg/constants"
 	"github.com/validator-labs/validator/pkg/types"
 
 	"github.com/validator-labs/validator-plugin-azure/api/v1alpha1"
 	"github.com/validator-labs/validator-plugin-azure/pkg/azure"
+	"github.com/validator-labs/validator-plugin-azure/pkg/constants"
 	utils "github.com/validator-labs/validator-plugin-azure/pkg/utils/azure"
 )
 
 // Validate validates the AzureValidatorSpec and returns a ValidationResponse.
-func Validate(ctx context.Context, spec v1alpha1.AzureValidatorSpec, log logr.Logger) (types.ValidationResponse, error) {
+func Validate(ctx context.Context, spec v1alpha1.AzureValidatorSpec, log logr.Logger) types.ValidationResponse {
 	resp := types.ValidationResponse{
 		ValidationRuleResults: make([]*types.ValidationRuleResult, 0, spec.ResultCount()),
 		ValidationRuleErrors:  make([]error, 0, spec.ResultCount()),
 	}
 
 	azureAPI, err := utils.NewAzureAPI()
 	if err != nil {
-		return resp, fmt.Errorf("failed to create Azure API object: %w", err)
+		vrr := buildValidationResult()
+		resp.AddResult(vrr, fmt.Errorf("failed to create Azure API object: %w", err))
+		return resp
 	}
 
 	ctx = context.WithoutCancel(ctx)
@@ -59,5 +64,15 @@ func Validate(ctx context.Context, spec v1alpha1.AzureValidatorSpec, log logr.Lo
 		resp.AddResult(vrr, err)
 	}
 
-	return resp, nil
+	return resp
+}
+
+func buildValidationResult() *types.ValidationRuleResult {
+	state := vapi.ValidationSucceeded
+	latestCondition := vapi.DefaultValidationCondition()
+	latestCondition.Message = "Initialization succeeded"
+	latestCondition.ValidationRule = fmt.Sprintf("%s-%s", vconstants.ValidationRulePrefix, constants.PluginCode)
+	latestCondition.ValidationType = constants.PluginCode
+
+	return &types.ValidationRuleResult{Condition: &latestCondition, State: &state}
 }