Skip to content

Commit f935ea8

Browse files
authored
test(e2e): ensure new instance whenever launch args are set (#5270)
### Description Noticed some e2e failures where a drawer is rendered instead of tab nav for tab tests. Seems like launch args don't get passed through. Setting newInstance to true so this always gets picked up ### Test plan CI ### Related issues N/A ### Backwards compatibility N/A ### Network scalability N/A
1 parent bff505e commit f935ea8

File tree

6 files changed

+6
-4
lines changed

6 files changed

+6
-4
lines changed

e2e/src/Pin.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ describe.each([{ navType: 'drawer' }, { navType: 'tab' }])(
1010
await device.uninstallApp()
1111
await device.installApp()
1212
await launchApp({
13-
newInstance: false,
13+
newInstance: true,
1414
permissions: { notifications: 'YES', contacts: 'YES' },
1515
launchArgs: { statsigGateOverrides: `use_tab_navigator=${navType === 'tab'}` },
1616
})

e2e/src/usecases/ChooseYourAdventure.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@ export default ChooseYourAdventure = () => {
66
await device.uninstallApp()
77
await device.installApp()
88
await launchApp({
9+
newInstance: true,
910
launchArgs: {
1011
statsigGateOverrides: `use_tab_navigator=true,show_cloud_account_backup_setup=true,show_cloud_account_backup_restore=true`,
1112
},

e2e/src/usecases/NewAccountOnboarding.js

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,7 @@ export default NewAccountOnboarding = () => {
157157
await device.uninstallApp()
158158
await device.installApp()
159159
await launchApp({
160+
newInstance: true,
160161
launchArgs: {
161162
statsigGateOverrides: `use_tab_navigator=true,show_cloud_account_backup_setup=true,show_cloud_account_backup_restore=true`,
162163
},

e2e/src/usecases/ResetAccount.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ export default ResetAccount = ({ navType }) => {
77
// statsig gate overrides
88
beforeAll(async () => {
99
await launchApp({
10-
newInstance: false,
10+
newInstance: true,
1111
permissions: { notifications: 'YES', contacts: 'YES' },
1212
launchArgs: { statsigGateOverrides: `use_tab_navigator=${navType === 'tab'}` },
1313
})

e2e/src/usecases/Settings.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ export default Settings = ({ navType }) => {
88
// statsig gate overrides
99
beforeAll(async () => {
1010
await launchApp({
11-
newInstance: false,
11+
newInstance: true,
1212
permissions: { notifications: 'YES', contacts: 'YES' },
1313
launchArgs: { statsigGateOverrides: `use_tab_navigator=${navType === 'tab'}` },
1414
})

e2e/src/usecases/Support.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -54,7 +54,7 @@ export default Support = () => {
5454

5555
it('Send Message to Support (tab)', async () => {
5656
await launchApp({
57-
newInstance: false,
57+
newInstance: true,
5858
permissions: { notifications: 'YES', contacts: 'YES' },
5959
launchArgs: { statsigGateOverrides: `use_tab_navigator=true` },
6060
})

0 commit comments

Comments
 (0)