Skip to content

Commit 5e1766f

Browse files
varadarajanavaradarajana
committed
google#638: changes to media type
1 parent 4a42a1d commit 5e1766f

File tree

4 files changed

+22
-22
lines changed

4 files changed

+22
-22
lines changed

‎github/pulls_reviewers.go

+3-3
Original file line numberDiff line numberDiff line change
@@ -27,7 +27,7 @@ func (s *PullRequestsService) RequestReviewers(ctx context.Context, owner, repo
2727
}
2828

2929
// TODO: remove custom Accept header when this API fully launches
30-
req.Header.Set("Accept", mediaTypePullRequestReviewsPreview)
30+
req.Header.Set("Accept", mediaTypeV3)
3131

3232
r := new(PullRequest)
3333
resp, err := s.client.Do(ctx, req, r)
@@ -54,7 +54,7 @@ func (s *PullRequestsService) ListReviewers(ctx context.Context, owner, repo str
5454
}
5555

5656
// TODO: remove custom Accept header when this API fully launches
57-
req.Header.Set("Accept", mediaTypePullRequestReviewsPreview)
57+
req.Header.Set("Accept", mediaTypeV3)
5858

5959
var users []*User
6060
resp, err := s.client.Do(ctx, req, &users)
@@ -82,7 +82,7 @@ func (s *PullRequestsService) RemoveReviewers(ctx context.Context, owner, repo s
8282
}
8383

8484
// TODO: remove custom Accept header when this API fully launches
85-
req.Header.Set("Accept", mediaTypePullRequestReviewsPreview)
85+
req.Header.Set("Accept", mediaTypeV3)
8686

8787
return s.client.Do(ctx, req, reviewers)
8888
}

‎github/pulls_reviewers_test.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ func TestRequestReviewers(t *testing.T) {
1919

2020
mux.HandleFunc("/repos/o/r/pulls/1/requested_reviewers", func(w http.ResponseWriter, r *http.Request) {
2121
testMethod(t, r, "POST")
22-
testHeader(t, r, "Accept", mediaTypePullRequestReviewsPreview)
22+
testHeader(t, r, "Accept", mediaTypeV3)
2323
testBody(t, r, `{"reviewers":["octocat","googlebot"]}`+"\n")
2424
fmt.Fprint(w, `{"number":1}`)
2525
})
@@ -41,7 +41,7 @@ func TestRemoveReviewers(t *testing.T) {
4141

4242
mux.HandleFunc("/repos/o/r/pulls/1/requested_reviewers", func(w http.ResponseWriter, r *http.Request) {
4343
testMethod(t, r, "DELETE")
44-
testHeader(t, r, "Accept", mediaTypePullRequestReviewsPreview)
44+
testHeader(t, r, "Accept", mediaTypeV3)
4545
testBody(t, r, `{"reviewers":["octocat","googlebot"]}`+"\n")
4646
})
4747

@@ -57,7 +57,7 @@ func TestListReviewers(t *testing.T) {
5757

5858
mux.HandleFunc("/repos/o/r/pulls/1/requested_reviewers", func(w http.ResponseWriter, r *http.Request) {
5959
testMethod(t, r, "GET")
60-
testHeader(t, r, "Accept", mediaTypePullRequestReviewsPreview)
60+
testHeader(t, r, "Accept", mediaTypeV3)
6161
fmt.Fprint(w, `[{"login":"octocat","id":1}]`)
6262
})
6363

@@ -86,7 +86,7 @@ func TestListReviewers_withOptions(t *testing.T) {
8686
testFormValues(t, r, values{
8787
"page": "2",
8888
})
89-
testHeader(t, r, "Accept", mediaTypePullRequestReviewsPreview)
89+
testHeader(t, r, "Accept", mediaTypeV3)
9090
fmt.Fprint(w, `[]`)
9191
})
9292

‎github/pulls_reviews.go

+7-7
Original file line numberDiff line numberDiff line change
@@ -78,7 +78,7 @@ func (s *PullRequestsService) ListReviews(ctx context.Context, owner, repo strin
7878
}
7979

8080
// TODO: remove custom Accept header when this API fully launches
81-
req.Header.Set("Accept", mediaTypePullRequestReviewsPreview)
81+
req.Header.Set("Accept", mediaTypeV3)
8282

8383
var reviews []*PullRequestReview
8484
resp, err := s.client.Do(ctx, req, &reviews)
@@ -105,7 +105,7 @@ func (s *PullRequestsService) GetReview(ctx context.Context, owner, repo string,
105105
}
106106

107107
// TODO: remove custom Accept header when this API fully launches
108-
req.Header.Set("Accept", mediaTypePullRequestReviewsPreview)
108+
req.Header.Set("Accept", mediaTypeV3)
109109

110110
review := new(PullRequestReview)
111111
resp, err := s.client.Do(ctx, req, review)
@@ -132,7 +132,7 @@ func (s *PullRequestsService) DeletePendingReview(ctx context.Context, owner, re
132132
}
133133

134134
// TODO: remove custom Accept header when this API fully launches
135-
req.Header.Set("Accept", mediaTypePullRequestReviewsPreview)
135+
req.Header.Set("Accept", mediaTypeV3)
136136

137137
review := new(PullRequestReview)
138138
resp, err := s.client.Do(ctx, req, review)
@@ -163,7 +163,7 @@ func (s *PullRequestsService) ListReviewComments(ctx context.Context, owner, rep
163163
}
164164

165165
// TODO: remove custom Accept header when this API fully launches
166-
req.Header.Set("Accept", mediaTypePullRequestReviewsPreview)
166+
req.Header.Set("Accept", mediaTypeV3)
167167

168168
var comments []*PullRequestComment
169169
resp, err := s.client.Do(ctx, req, &comments)
@@ -190,7 +190,7 @@ func (s *PullRequestsService) CreateReview(ctx context.Context, owner, repo stri
190190
}
191191

192192
// TODO: remove custom Accept header when this API fully launches
193-
req.Header.Set("Accept", mediaTypePullRequestReviewsPreview)
193+
req.Header.Set("Accept", mediaTypeV3)
194194

195195
r := new(PullRequestReview)
196196
resp, err := s.client.Do(ctx, req, r)
@@ -217,7 +217,7 @@ func (s *PullRequestsService) SubmitReview(ctx context.Context, owner, repo stri
217217
}
218218

219219
// TODO: remove custom Accept header when this API fully launches
220-
req.Header.Set("Accept", mediaTypePullRequestReviewsPreview)
220+
req.Header.Set("Accept", mediaTypeV3)
221221

222222
r := new(PullRequestReview)
223223
resp, err := s.client.Do(ctx, req, r)
@@ -244,7 +244,7 @@ func (s *PullRequestsService) DismissReview(ctx context.Context, owner, repo str
244244
}
245245

246246
// TODO: remove custom Accept header when this API fully launches
247-
req.Header.Set("Accept", mediaTypePullRequestReviewsPreview)
247+
req.Header.Set("Accept", mediaTypeV3)
248248

249249
r := new(PullRequestReview)
250250
resp, err := s.client.Do(ctx, req, r)

‎github/pulls_reviews_test.go

+8-8
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ func TestPullRequestsService_ListReviews(t *testing.T) {
2323
testFormValues(t, r, values{
2424
"page": "2",
2525
})
26-
testHeader(t, r, "Accept", mediaTypePullRequestReviewsPreview)
26+
testHeader(t, r, "Accept", mediaTypeV3)
2727
fmt.Fprint(w, `[{"id":1},{"id":2}]`)
2828
})
2929

@@ -53,7 +53,7 @@ func TestPullRequestsService_GetReview(t *testing.T) {
5353

5454
mux.HandleFunc("/repos/o/r/pulls/1/reviews/1", func(w http.ResponseWriter, r *http.Request) {
5555
testMethod(t, r, "GET")
56-
testHeader(t, r, "Accept", mediaTypePullRequestReviewsPreview)
56+
testHeader(t, r, "Accept", mediaTypeV3)
5757
fmt.Fprint(w, `{"id":1}`)
5858
})
5959

@@ -79,7 +79,7 @@ func TestPullRequestsService_DeletePendingReview(t *testing.T) {
7979

8080
mux.HandleFunc("/repos/o/r/pulls/1/reviews/1", func(w http.ResponseWriter, r *http.Request) {
8181
testMethod(t, r, "DELETE")
82-
testHeader(t, r, "Accept", mediaTypePullRequestReviewsPreview)
82+
testHeader(t, r, "Accept", mediaTypeV3)
8383
fmt.Fprint(w, `{"id":1}`)
8484
})
8585

@@ -105,7 +105,7 @@ func TestPullRequestsService_ListReviewComments(t *testing.T) {
105105

106106
mux.HandleFunc("/repos/o/r/pulls/1/reviews/1/comments", func(w http.ResponseWriter, r *http.Request) {
107107
testMethod(t, r, "GET")
108-
testHeader(t, r, "Accept", mediaTypePullRequestReviewsPreview)
108+
testHeader(t, r, "Accept", mediaTypeV3)
109109
fmt.Fprint(w, `[{"id":1},{"id":2}]`)
110110
})
111111

@@ -132,7 +132,7 @@ func TestPullRequestsService_ListReviewComments_withOptions(t *testing.T) {
132132
testFormValues(t, r, values{
133133
"page": "2",
134134
})
135-
testHeader(t, r, "Accept", mediaTypePullRequestReviewsPreview)
135+
testHeader(t, r, "Accept", mediaTypeV3)
136136
fmt.Fprint(w, `[]`)
137137
})
138138

@@ -161,7 +161,7 @@ func TestPullRequestsService_CreateReview(t *testing.T) {
161161
json.NewDecoder(r.Body).Decode(v)
162162

163163
testMethod(t, r, "POST")
164-
testHeader(t, r, "Accept", mediaTypePullRequestReviewsPreview)
164+
testHeader(t, r, "Accept", mediaTypeV3)
165165
if !reflect.DeepEqual(v, input) {
166166
t.Errorf("Request body = %+v, want %+v", v, input)
167167
}
@@ -199,7 +199,7 @@ func TestPullRequestsService_SubmitReview(t *testing.T) {
199199
json.NewDecoder(r.Body).Decode(v)
200200

201201
testMethod(t, r, "POST")
202-
testHeader(t, r, "Accept", mediaTypePullRequestReviewsPreview)
202+
testHeader(t, r, "Accept", mediaTypeV3)
203203
if !reflect.DeepEqual(v, input) {
204204
t.Errorf("Request body = %+v, want %+v", v, input)
205205
}
@@ -234,7 +234,7 @@ func TestPullRequestsService_DismissReview(t *testing.T) {
234234
json.NewDecoder(r.Body).Decode(v)
235235

236236
testMethod(t, r, "PUT")
237-
testHeader(t, r, "Accept", mediaTypePullRequestReviewsPreview)
237+
testHeader(t, r, "Accept", mediaTypeV3)
238238
if !reflect.DeepEqual(v, input) {
239239
t.Errorf("Request body = %+v, want %+v", v, input)
240240
}

0 commit comments

Comments
 (0)