Throwning runtime error in case of an Abort(). Much easier for the client side.

Author: melroy89

README.md

@@ -133,6 +133,8 @@ More info see: [Doxygen Docs - Client Class](https://vasild.github.io/cpp-ipfs-h
 
 The client constructor and destructor are not thread safe. However, all the API IPFS calls are **thread safe**!
 
+*Note:* A runtime error will be thrown on the request call (in this example the `FilesGet()`) when you call the `Abort()` method, allowing you to stop your code execution inside the thread.
+
 An example of using a thread together with the IPFS Client:
 
 ```cpp

examples/threading_example.cc

@@ -46,7 +46,11 @@ void startThread() {
         // File should not exists, takes forever (until time-out)
         client.FilesGet("QmZp1rrtGTictR2rpNcx4673R7qU9Jdr9DQ6Z7F6Wgo2bQ",
                         &contents);
+
+        // Code below will never be reached, since we abort the request
+        std::cout << "Output: " << contents.str() << std::endl;
       } catch (const std::runtime_error& e) {
+        // Run-time error will be thrown because of the aborting request.
         std::cerr << "Error: " << e.what() << std::endl;
       }
     });

src/http/transport-curl.cc

@@ -309,6 +309,11 @@ void TransportCurl::Perform(const std::string& url, std::iostream* response) {
         throw std::runtime_error(error);
       }
     }
+  } else {
+    /* Throw runtime error if the request was aborted (atomic bool is false)
+     * This is useful for the client-side in order to
+     * stop executing remaining code when a Abort() was triggered. */
+    throw std::runtime_error("Request was aborted");
   }
 }
 

test/test_threading.cc

@@ -39,7 +39,7 @@ int main(int, char**) {
         client.FilesGet("QmZp1rrtGTictR2rpNcx4673R7qU9Jdr9DQ6Z7F6Wgo2bQ",
                         &contents);
       } catch (const std::runtime_error& e) {
-        std::cerr << "Error: " << e.what() << std::endl;
+        std::cerr << "Expected error: " << e.what() << std::endl;
       }
     });