Missing device_id in matrix-android-sdk2 login API

[hugohn]

Description

According to the current spec, the Matrix login API takes in a device_id, but matrix-android-sdk2, which Element Android uses, doesn't seem to expose the device_id param for logging in. There is a PasswordLoginParams class with device_id, but it is an internal class to the SDK. Does anyone know how to log in with device_id?

I checked libQuotient and matrix-ios-sdk and they both provide the login API with a device_id param (explicitly in libQuotient and via a dictionary in matrix-ios-sdk).

[bmarty]

You are right, providing a deviceId is not currently possible in the Matrix SDK2 API.
There is really not a big deal to change that, let's do that in the next sprint:
Add a parameter deviceId: String? = null to this method

[hugohn]

Awesome. Thank you @bmarty !

[hugohn]

@bmarty would it be possible to add deviceId to AuthenticationService.directAuthentication() too?

https://github.com/vector-im/element-android/blob/main/matrix-sdk-android/src/main/java/org/matrix/android/sdk/api/auth/AuthenticationService.kt#L109

[bmarty]

Yes, will will add it wherever it makes thanks, thanks for the reminder.

[bmarty]

@hugohn #4344 should cover your needs. Please yell if it's not the case!

[hugohn]

@bmarty it looks good to me!

[bmarty]

This will be in SDK 1.3.7