Skip to content

don't pause timer when call is held #5885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 4, 2022
Merged

Conversation

chagai95
Copy link
Contributor

@chagai95 chagai95 commented May 2, 2022

This is also the way it is implemented in web and the correct way

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

Motivation and context

Screenshots / GIFs

Tests

  • Step 1
  • Step 2
  • Step ...

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

Signed-off-by: Chagai Friedlander [email protected]

chagai95 added 2 commits May 2, 2022 09:11
This is also the way it is implemented in web and the correct way
@bmarty bmarty requested review from a team, yostyle and fedrunov and removed request for a team May 2, 2022 10:50
@bmarty bmarty added the Z-Community-PR Issue is solved by a community member's PR label May 2, 2022
Copy link
Contributor

@yostyle yostyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but @ganfra should review this change

@yostyle yostyle requested a review from ganfra May 4, 2022 08:57
Copy link
Member

@ganfra ganfra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@bmarty bmarty merged commit a11c0b7 into element-hq:develop May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants