-
Notifications
You must be signed in to change notification settings - Fork 28.2k
/
Copy pathparallel-routes-revalidation.test.ts
461 lines (367 loc) · 16.5 KB
/
parallel-routes-revalidation.test.ts
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
import { nextTestSetup } from 'e2e-utils'
import { check, retry } from 'next-test-utils'
describe('parallel-routes-revalidation', () => {
const { next, isNextDev, isNextStart, isNextDeploy } = nextTestSetup({
files: __dirname,
})
// This test is skipped when deployed as it relies on a shared data store
// For testing purposes we just use an in-memory object, but when deployed
// this could hit a separate lambda instance that won't share the same reference
if (!isNextDeploy) {
it('should submit the action and revalidate the page data', async () => {
const browser = await next.browser('/')
await check(() => browser.hasElementByCssSelector('#create-entry'), false)
// there shouldn't be any data yet
expect((await browser.elementsByCss('#entries li')).length).toBe(0)
await browser.elementByCss("[href='/revalidate-modal']").click()
await check(() => browser.hasElementByCssSelector('#create-entry'), true)
await browser.elementById('create-entry').click()
// we created an entry and called revalidate, so we should have 1 entry
await retry(async () => {
expect((await browser.elementsByCss('#entries li')).length).toBe(1)
})
await browser.elementById('create-entry').click()
// we created an entry and called revalidate, so we should have 2 entries
await retry(async () => {
expect((await browser.elementsByCss('#entries li')).length).toBe(2)
})
await browser.elementByCss("[href='/']").click()
// following a link back to `/` should close the modal
await check(() => browser.hasElementByCssSelector('#create-entry'), false)
await check(() => browser.elementByCss('body').text(), /Current Data/)
})
}
it('should handle router.refresh() when called in a slot', async () => {
const browser = await next.browser('/')
await check(() => browser.hasElementByCssSelector('#refresh-router'), false)
const currentRandomNumber = (
await browser.elementById('random-number')
).text()
await browser.elementByCss("[href='/refresh-modal']").click()
await check(() => browser.hasElementByCssSelector('#refresh-router'), true)
await browser.elementById('refresh-router').click()
await check(async () => {
const randomNumber = (await browser.elementById('random-number')).text()
return randomNumber !== currentRandomNumber
}, true)
await browser.elementByCss("[href='/']").click()
// following a link back to `/` should close the modal
await check(() => browser.hasElementByCssSelector('#create-entry'), false)
await check(() => browser.elementByCss('body').text(), /Current Data/)
})
it('should handle a redirect action when called in a slot', async () => {
const browser = await next.browser('/')
await check(() => browser.hasElementByCssSelector('#redirect'), false)
await browser.elementByCss("[href='/redirect-modal']").click()
await check(() => browser.hasElementByCssSelector('#redirect'), true)
await browser.elementById('redirect').click()
await check(() => browser.hasElementByCssSelector('#redirect'), false)
await check(() => browser.elementByCss('body').text(), /Current Data/)
})
it.each([
{ path: '/detail-page' },
{ path: '/dynamic/foobar', param: 'foobar' },
{ path: '/catchall/foobar', param: 'foobar' },
])(
'should not trigger interception when calling router.refresh() on an intercepted route ($path)',
async (route) => {
const browser = await next.browser(route.path)
// directly loaded the detail page, so it should not be intercepted.
expect(await browser.elementById('detail-title').text()).toBe(
'Detail Page (Non-Intercepted)'
)
const randomNumber = (await browser.elementById('random-number')).text()
// confirm that if the route contained a dynamic parameter, that it's reflected in the UI
if (route.param) {
expect(await browser.elementById('params').text()).toBe(route.param)
}
// click the refresh button
await browser.elementByCss('button').click()
await retry(async () => {
const newRandomNumber = await browser
.elementById('random-number')
.text()
// we should have received a new random number, indicating the non-intercepted page was refreshed
expect(randomNumber).not.toBe(newRandomNumber)
// confirm that the page is still not intercepted
expect(await browser.elementById('detail-title').text()).toBe(
'Detail Page (Non-Intercepted)'
)
// confirm the params (if previously present) are still present
if (route.param) {
expect(await browser.elementById('params').text()).toBe(route.param)
}
})
}
)
it('should not trigger full page when calling router.refresh() on an intercepted route', async () => {
const browser = await next.browser('/dynamic')
await browser.elementByCss('a').click()
// we soft-navigated to the route, so it should be intercepted
expect(await browser.elementById('detail-title').text()).toBe(
'Detail Page (Intercepted)'
)
const randomNumber = (await browser.elementById('random-number')).text()
// confirm the dynamic param is reflected in the UI
expect(await browser.elementById('params').text()).toBe('foobar')
// click the refresh button
await browser.elementByCss('button').click()
await retry(async () => {
// confirm that the intercepted page data was refreshed
const newRandomNumber = await browser.elementById('random-number').text()
// confirm that the page is still intercepted
expect(randomNumber).not.toBe(newRandomNumber)
expect(await browser.elementById('detail-title').text()).toBe(
'Detail Page (Intercepted)'
)
// confirm the paramsare still present
expect(await browser.elementById('params').text()).toBe('foobar')
})
})
it('should not trigger the intercepted route when lazy-fetching missing data', async () => {
const browser = await next.browser('/')
// trigger the interception page
await browser.elementByCss("[href='/detail-page']").click()
// we should see the intercepted page
expect(await browser.elementById('detail-title').text()).toBe(
'Detail Page (Intercepted)'
)
// refresh the page
await browser.refresh()
// we should see the detail page
expect(await browser.elementById('detail-title').text()).toBe(
'Detail Page (Non-Intercepted)'
)
// go back to the previous page
await browser.back()
// reload the page, which will cause the router to no longer have cache nodes
await browser.refresh()
await browser.waitForIdleNetwork()
// go forward, this will trigger a lazy fetch for the missing data, and should restore the detail page
await browser.forward()
expect(await browser.elementById('detail-title').text()).toBe(
'Detail Page (Non-Intercepted)'
)
})
// This test is skipped when deployed as it relies on a shared data store
// For testing purposes we just use an in-memory object, but when deployed
// this could hit a separate lambda instance that won't share the same reference
if (!isNextDeploy) {
it('should refresh the correct page when a server action triggers a redirect', async () => {
const browser = await next.browser('/redirect')
await browser.elementByCss('button').click()
await browser.elementByCss("[href='/revalidate-modal']").click()
await check(() => browser.hasElementByCssSelector('#create-entry'), true)
await browser.elementById('clear-entries').click()
await retry(async () => {
// confirm there aren't any entries yet
expect((await browser.elementsByCss('#entries li')).length).toBe(0)
})
await browser.elementById('create-entry').click()
await retry(async () => {
// we created an entry and called revalidate, so we should have 1 entry
expect((await browser.elementsByCss('#entries li')).length).toBe(1)
})
})
}
describe.each([
{ basePath: '/refreshing', label: 'regular', withSearchParams: false },
{ basePath: '/refreshing', label: 'regular', withSearchParams: true },
{
basePath: '/dynamic-refresh/foo',
label: 'dynamic',
withSearchParams: false,
},
{
basePath: '/dynamic-refresh/foo',
label: 'dynamic',
withSearchParams: true,
},
])(
'router.refresh ($label) - searchParams: $withSearchParams',
({ basePath, withSearchParams }) => {
it('should correctly refresh data for the intercepted route and previously active page slot', async () => {
const browser = await next.browser(basePath)
let initialSearchParams: string | undefined
if (withSearchParams) {
// add some search params prior to proceeding
await browser.elementById('update-search-params').click()
await retry(async () => {
initialSearchParams = await browser
.elementById('search-params')
.text()
expect(initialSearchParams).toMatch(/^Params: "0\.\d+"$/)
})
}
let initialRandomNumber = await browser.elementById('random-number')
await browser.elementByCss(`[href='${basePath}/login']`).click()
// interception modal should be visible
let initialModalRandomNumber = await browser
.elementById('modal-random')
.text()
// trigger a refresh
await browser.elementById('refresh-button').click()
await retry(async () => {
const newRandomNumber = await browser
.elementById('random-number')
.text()
const newModalRandomNumber = await browser
.elementById('modal-random')
.text()
expect(initialRandomNumber).not.toBe(newRandomNumber)
expect(initialModalRandomNumber).not.toBe(newModalRandomNumber)
// reset the initial values to be the new values, so that we can verify the revalidate case below.
initialRandomNumber = newRandomNumber
initialModalRandomNumber = newModalRandomNumber
})
// trigger a revalidate
await browser.elementById('revalidate-button').click()
await retry(async () => {
const newRandomNumber = await browser
.elementById('random-number')
.text()
const newModalRandomNumber = await browser
.elementById('modal-random')
.text()
expect(initialRandomNumber).not.toBe(newRandomNumber)
expect(initialModalRandomNumber).not.toBe(newModalRandomNumber)
if (withSearchParams) {
// add additional search params in the new modal
await browser.elementById('update-search-params-modal').click()
expect(
await browser.elementById('search-params-modal').text()
).toMatch(/^Params: "0\.\d+"$/)
// make sure the old params are still there too
expect(await browser.elementById('search-params').text()).toBe(
initialSearchParams
)
}
})
// reload the page, triggering which will remove the interception route and show the full page
await browser.refresh()
const initialLoginPageRandomNumber = await browser
.elementById('login-page-random')
.text()
// trigger a refresh
await browser.elementById('refresh-button').click()
await retry(async () => {
const newLoginPageRandomNumber = await browser
.elementById('login-page-random')
.text()
expect(newLoginPageRandomNumber).not.toBe(
initialLoginPageRandomNumber
)
})
})
it('should correctly refresh data for previously intercepted modal and active page slot', async () => {
const browser = await next.browser(basePath)
await browser.elementByCss(`[href='${basePath}/login']`).click()
// interception modal should be visible
let initialModalRandomNumber = await browser
.elementById('modal-random')
.text()
await browser.elementByCss(`[href='${basePath}/other']`).click()
// data for the /other page should be visible
let initialOtherPageRandomNumber = await browser
.elementById('other-page-random')
.text()
// trigger a refresh
await browser.elementById('refresh-button').click()
await retry(async () => {
const newModalRandomNumber = await browser
.elementById('modal-random')
.text()
const newOtherPageRandomNumber = await browser
.elementById('other-page-random')
.text()
expect(initialModalRandomNumber).not.toBe(newModalRandomNumber)
expect(initialOtherPageRandomNumber).not.toBe(
newOtherPageRandomNumber
)
// reset the initial values to be the new values, so that we can verify the revalidate case below.
initialOtherPageRandomNumber = newOtherPageRandomNumber
initialModalRandomNumber = newModalRandomNumber
})
// trigger a revalidate
await browser.elementById('revalidate-button').click()
await retry(async () => {
const newModalRandomNumber = await browser
.elementById('modal-random')
.text()
const newOtherPageRandomNumber = await browser
.elementById('other-page-random')
.text()
expect(initialModalRandomNumber).not.toBe(newModalRandomNumber)
expect(initialOtherPageRandomNumber).not.toBe(
newOtherPageRandomNumber
)
})
})
}
)
describe('server action revalidation', () => {
it('handles refreshing when multiple parallel slots are active', async () => {
const browser = await next.browser('/nested-revalidate')
const currentPageTime = await browser.elementById('page-now').text()
expect(await browser.hasElementByCssSelector('#modal')).toBe(false)
expect(await browser.hasElementByCssSelector('#drawer')).toBe(false)
// renders the drawer parallel slot
await browser.elementByCss("[href='/nested-revalidate/drawer']").click()
await browser.waitForElementByCss('#drawer')
// renders the modal slot
await browser.elementByCss("[href='/nested-revalidate/modal']").click()
await browser.waitForElementByCss('#modal')
// Both should be visible, despite only one "matching"
expect(await browser.hasElementByCssSelector('#modal')).toBe(true)
expect(await browser.hasElementByCssSelector('#drawer')).toBe(true)
// grab the current time of the drawer
const currentDrawerTime = await browser.elementById('drawer-now').text()
// trigger the revalidation action in the modal.
await browser.elementById('modal-submit-button').click()
await retry(async () => {
// Revalidation should close the modal
expect(await browser.hasElementByCssSelector('#modal')).toBe(false)
// But the drawer should still be open
expect(await browser.hasElementByCssSelector('#drawer')).toBe(true)
// And the drawer should have a new time
expect(await browser.elementById('drawer-now').text()).not.toEqual(
currentDrawerTime
)
// And the underlying page should have a new time
expect(await browser.elementById('page-now').text()).not.toEqual(
currentPageTime
)
})
})
it('should not trigger a refresh for the page that is being redirected to', async () => {
const rscRequests = []
const prefetchRequests = []
const browser = await next.browser('/redirect', {
beforePageLoad(page) {
page.on('request', async (req) => {
const headers = await req.allHeaders()
if (headers['rsc']) {
const pathname = new URL(req.url()).pathname
if (headers['next-router-prefetch']) {
prefetchRequests.push(pathname)
} else {
rscRequests.push(pathname)
}
}
})
},
})
await browser.elementByCss('button').click()
await browser.waitForElementByCss('#root-page')
await browser.waitForIdleNetwork()
await retry(async () => {
if (!isNextDev) {
expect(rscRequests.length).toBe(0)
}
if (isNextStart) {
expect(prefetchRequests.length).toBe(4)
}
})
})
})
})