Skip to content

Commit 1ee170c

Browse files
committed
update test
1 parent 8c3227e commit 1ee170c

File tree

7 files changed

+22
-28
lines changed

7 files changed

+22
-28
lines changed
Original file line numberDiff line numberDiff line change
@@ -1,9 +1,14 @@
11
export default function Layout({ bar, foo }) {
22
return (
33
<div>
4-
<h1>Parallel Routes Layout</h1>
4+
<h1>Parallel Routes Layout - No Children</h1>
55
<div id="foo-slot">{foo}</div>
66
<div id="bar-slot">{bar}</div>
77
</div>
88
)
99
}
10+
11+
export const metadata = {
12+
title: 'parallel-routes-no-children layout title',
13+
description: 'parallel-routes-no-children layout description',
14+
}

test/e2e/app-dir/metadata-streaming/app/parallel-routes-no-children/page.tsx

-17
This file was deleted.

test/e2e/app-dir/metadata-streaming/app/parallel-routes-no-children/test-page/page.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export default function TestPage() {
66

77
export async function generateMetadata() {
88
await connection()
9-
await new Promise((resolve) => setTimeout(resolve, 3000))
9+
await new Promise((resolve) => setTimeout(resolve, 2000))
1010
return {
1111
title: `Dynamic api ${Math.random()}`,
1212
}

test/e2e/app-dir/metadata-streaming/app/parallel-routes/no-bar/page.tsx

+2-1
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,9 @@ export default function TestPage() {
66

77
export async function generateMetadata() {
88
await connection()
9-
await new Promise((resolve) => setTimeout(resolve, 3000))
9+
await new Promise((resolve) => setTimeout(resolve, 1000))
1010
return {
1111
title: `Dynamic api ${Math.random()}`,
12+
description: 'no-bar description',
1213
}
1314
}

test/e2e/app-dir/metadata-streaming/app/parallel-routes/page.tsx

+1
Original file line numberDiff line numberDiff line change
@@ -14,4 +14,5 @@ export default function Page() {
1414

1515
export const metadata = {
1616
title: 'parallel title',
17+
description: 'parallel description',
1718
}

test/e2e/app-dir/metadata-streaming/app/parallel-routes/test-page/page.tsx

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ export default function TestPage() {
66

77
export async function generateMetadata() {
88
await connection()
9-
await new Promise((resolve) => setTimeout(resolve, 3000))
9+
await new Promise((resolve) => setTimeout(resolve, 1000))
1010
return {
1111
title: `Dynamic api ${Math.random()}`,
1212
}

test/e2e/app-dir/metadata-streaming/metadata-streaming.test.ts

+11-7
Original file line numberDiff line numberDiff line change
@@ -115,25 +115,29 @@ describe('app-dir - metadata-streaming', () => {
115115
const browser = await next.browser('/parallel-routes')
116116
await browser.elementByCss('[href="/parallel-routes/no-bar"]').click()
117117

118+
// Wait for navigation is finished and metadata is updated
118119
await retry(async () => {
119120
expect(await browser.elementByCss('title').text()).toContain(
120121
'Dynamic api'
121122
)
122123
})
123124

124-
expect((await browser.elementsByCss('title')).length).toBe(1)
125+
await retry(async () => {
126+
expect((await browser.elementsByCss('title')).length).toBe(1)
127+
})
125128
})
126129

127130
it('should still render layout metadata if children is not rendered but rest slots are', async () => {
128-
const browser = await next.browser('/parallel-routes-no-children')
131+
const browser = await next.browser('/parallel-routes-no-children/test-page')
129132

130-
expect((await browser.elementsByCss('head title')).length).toBe(1)
131-
expect((await browser.elementsByCss('body title')).length).toBe(0)
132-
expect(await browser.elementByCss('title').text()).toBe('parallel title')
133+
expect((await browser.elementsByCss('title')).length).toBe(1)
134+
expect(await browser.elementByCss('title').text()).toMatch(
135+
/Dynamic api \d+/
136+
)
133137

134-
const $ = await next.render$('/parallel-routes-no-children')
138+
const $ = await next.render$('/parallel-routes-no-children/test-page')
135139
expect($('title').length).toBe(1)
136-
expect($('head title').text()).toBe('parallel title')
140+
expect($('head title').text()).toMatch(/Dynamic api \d+/)
137141
})
138142

139143
describe('dynamic api', () => {

0 commit comments

Comments
 (0)