[metadata] remove the duplicate metadata in the error boundary (#76791)

huozhi · web-flow · commit 51ffc255e185 · 2025-03-05T08:31:06.000+01:00
### What 

Those metadata were added into error boundaries but they're actually duplicated, we already have the actual metadata in the page and the metadata outlet can trigger the error boundary. The metadata element in the error boundary is not necessary.
diff --git a/packages/next/src/server/app-render/create-component-tree.tsx b/packages/next/src/server/app-render/create-component-tree.tsx
@@ -411,23 +411,20 @@ async function createComponentTreeInternal({
   const notFoundElement = NotFound ? (
     <>
       <NotFound />
-      {metadata}
       {notFoundStyles}
     </>
   ) : undefined
 
   const forbiddenElement = Forbidden ? (
     <>
       <Forbidden />
-      {metadata}
       {forbiddenStyles}
     </>
   ) : undefined
 
   const unauthorizedElement = Unauthorized ? (
     <>
       <Unauthorized />
-      {metadata}
       {unauthorizedStyles}
     </>
   ) : undefined
@@ -858,7 +855,6 @@ async function createComponentTreeInternal({
                     {notFoundStyles}
                     <NotFound />
                   </SegmentComponent>
-                  {metadata}
                 </>
               ) : undefined
             }
diff --git a/test/e2e/app-dir/parallel-routes-not-found/app/layout.tsx b/test/e2e/app-dir/parallel-routes-not-found/app/layout.tsx
@@ -6,11 +6,15 @@ export default function Layout({
   slot: React.ReactNode
 }) {
   return (
-    <html>
+    <html lang="en" className="layout">
       <body>
         {children}
         {slot}
       </body>
     </html>
   )
 }
+
+export const metadata = {
+  title: 'layout title',
+}
diff --git a/test/e2e/app-dir/parallel-routes-not-found/next.config.js b/test/e2e/app-dir/parallel-routes-not-found/next.config.js
@@ -1,8 +1,6 @@
 /**
  * @type {import('next').NextConfig}
  */
-const nextConfig = {
-  pageExtensions: ['tsx', 'ts'],
-}
+const nextConfig = {}
 
 module.exports = nextConfig
diff --git a/test/e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts b/test/e2e/app-dir/parallel-routes-not-found/parallel-routes-not-found.test.ts
@@ -1,7 +1,9 @@
 import { nextTestSetup } from 'e2e-utils'
 
+const isPPR = process.env.__NEXT_EXPERIMENTAL_PPR === 'true'
+
 describe('parallel-routes-and-interception', () => {
-  const { next, skipped } = nextTestSetup({
+  const { next, isNextDev, skipped } = nextTestSetup({
     files: __dirname,
     // TODO: remove after deployment handling is updated
     skipDeployment: true,
@@ -21,5 +23,28 @@ describe('parallel-routes-and-interception', () => {
 
     // we also check that the #children-slot id is not present
     expect(await browser.hasElementByCssSelector('#children-slot')).toBe(false)
+
+    if (isPPR && !isNextDev) {
+      let $ = await next.render$('/')
+      expect($('title').text()).toBe('')
+
+      $ = await next.render$('/', null, {
+        headers: {
+          'User-Agent': 'Discordbot',
+        },
+      })
+      expect($('title').text()).toBe('layout title')
+    } else {
+      const $ = await next.render$('/')
+      expect($('title').text()).toBe('layout title')
+    }
+  })
+
+  it('should render the title once for the non-existed route', async () => {
+    const browser = await next.browser('/non-existed')
+    const titles = await browser.elementsByCss('title')
+
+    // FIXME: (metadata), the title should only be rendered once and using the not-found title
+    expect(titles).toHaveLength(3)
   })
 })
diff --git a/test/e2e/app-dir/parallel-routes-not-found/tsconfig.json b/test/e2e/app-dir/parallel-routes-not-found/tsconfig.json
@@ -21,5 +21,5 @@
     "target": "ES2017"
   },
   "include": ["next-env.d.ts", ".next/types/**/*.ts", "**/*.ts", "**/*.tsx"],
-  "exclude": ["node_modules"]
+  "exclude": ["node_modules", "**/*.test.ts", "**/*.test.tsx"]
 }

Original file line number	Diff line number	Diff line change
`@@ -21,5 +21,5 @@`
`21`	`21`	`"target": "ES2017"`
`22`	`22`	`},`
`23`	`23`	`"include": ["next-env.d.ts", ".next/types/*/.ts", "*/.ts", "*/.tsx"],`
`24`		`- "exclude": ["node_modules"]`
	`24`	`+ "exclude": ["node_modules", "*/.test.ts", "*/.test.tsx"]`
`25`	`25`	`}`