fix static metadata helpers

Author: huozhi

packages/next/src/build/webpack/plugins/next-trace-entrypoints-plugin.ts

@@ -18,7 +18,7 @@ import picomatch from 'next/dist/compiled/picomatch'
 import { getModuleBuildInfo } from '../loaders/get-module-build-info'
 import { getPageFilePath } from '../../entries'
 import { resolveExternal } from '../../handle-externals'
-import { isStaticMetadataRoutePathname } from '../../../lib/metadata/is-metadata-route'
+import { isStaticMetadataRoutePage } from '../../../lib/metadata/is-metadata-route'
 import { getCompilationSpan } from '../utils'
 
 const PLUGIN_NAME = 'TraceEntryPointsPlugin'
@@ -243,7 +243,7 @@ export class TraceEntryPointsPlugin implements webpack.WebpackPluginInstance {
 
           const entryIsStaticMetadataRoute =
             appDirRelativeEntryPath &&
-            isStaticMetadataRoutePathname(appDirRelativeEntryPath)
+            isStaticMetadataRoutePage(appDirRelativeEntryPath)
 
           // Include the client reference manifest in the trace, but not for
           // static metadata routes, for which we don't generate those.

packages/next/src/lib/metadata/is-metadata-route.ts

@@ -128,25 +128,24 @@ export function isMetadataRouteFile(
   )
 }
 
-function isStaticMetadataRoutePage(appDirRelativePath: string) {
+export function isStaticMetadataRoutePage(appDirRelativePath: string) {
   return isMetadataRouteFile(appDirRelativePath, [], true)
 }
 
 // Check if the route is a static metadata route, with /route suffix
-// e.g. /robots.txt/route, /sitemap.xml/route, /favicon.ico/route, /manifest/route, /icon/route, etc.
+// e.g. /favicon.ico/route, /icon.png/route, etc.
+// But skip the text routes like robots.txt since they might also be dynamic.
+// Checking route path is not enough to determine if text routes is dynamic.
 export function isStaticMetadataRoute(route: string) {
   const pathname = route.slice(0, -'/route'.length)
-  return isAppRouteRoute(route) && isStaticMetadataRoutePage(pathname)
-}
-
-// Check if the page is a static metadata route file
-// e.g. /robots, /manifest, /favicon.ico, /sitemap.xml, /icon.png, etc.
-export function isStaticMetadataRoutePathname(page: string) {
   return (
-    // TODO: avoid directly checking pathnames as they can also be page routes
-    page === '/robots' ||
-    page === '/manifest' ||
-    isStaticMetadataRoutePage(page)
+    isAppRouteRoute(route) &&
+    isStaticMetadataRoutePage(pathname) &&
+    // These routes can either be built by static or dynamic entrypoints,
+    // so we assume they're dynamic
+    pathname !== '/robots.txt' &&
+    pathname !== '/manifest.webmanifest' &&
+    !pathname.endsWith('/sitemap.xml')
   )
 }
 

packages/next/src/server/route-matcher-providers/dev/dev-app-route-route-matcher-provider.ts

@@ -7,7 +7,7 @@ import { isAppRouteRoute } from '../../../lib/is-app-route-route'
 import { DevAppNormalizers } from '../../normalizers/built/app'
 import {
   isMetadataRouteFile,
-  isStaticMetadataRoutePathname,
+  isStaticMetadataRoute,
 } from '../../../lib/metadata/is-metadata-route'
 import { normalizeMetadataPageToRoute } from '../../../lib/metadata/get-metadata-route'
 import path from '../../../shared/lib/isomorphic/path'
@@ -53,7 +53,7 @@ export class DevAppRouteRouteMatcherProvider extends FileCacheRouteMatcherProvid
         true
       )
 
-      if (!isStaticMetadataRoutePathname(page) && isEntryMetadataRouteFile) {
+      if (isEntryMetadataRouteFile && !isStaticMetadataRoute(page)) {
         // Matching dynamic metadata routes.
         // Add 2 possibilities for both single and multiple routes:
         {