Skip to content

Commit 8e5c914

Browse files
committed
return the completion
1 parent 74e337f commit 8e5c914

File tree

2 files changed

+7
-3
lines changed

2 files changed

+7
-3
lines changed

packages/next/src/server/typescript/index.ts

+2-3
Original file line numberDiff line numberDiff line change
@@ -79,14 +79,13 @@ export const createTSPlugin: tsModule.server.PluginModuleFactory = ({
7979
if (!entryInfo.client) {
8080
// Remove specified entries from completion list
8181
prior.entries = serverLayer.filterCompletionsAtPosition(prior.entries)
82-
8382
// Provide autocompletion for metadata fields
84-
prior.entries = metadata.filterCompletionsAtPosition(
83+
prior = metadata.filterCompletionsAtPosition(
8584
fileName,
8685
position,
8786
options,
8887
prior
89-
).entries
88+
)
9089
}
9190

9291
// Add auto completions for export configs.

packages/next/src/server/typescript/rules/metadata.ts

+5
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,11 @@ const metadata = {
163163
if (completions) {
164164
const ts = getTs()
165165
completions.isIncomplete = true
166+
// https://github.com/microsoft/TypeScript/blob/4dc677b292354f4b9162452b2e00f4d7dd118221/src/services/types.ts#L1428-L1433
167+
if (completions.optionalReplacementSpan) {
168+
// Adjust the start position of the text span to original source.
169+
completions.optionalReplacementSpan.start -= newPos - position
170+
}
166171
completions.entries = completions.entries
167172
.filter((e) => {
168173
return [

0 commit comments

Comments
 (0)